Received-SPF: pass (google.com: domain of linux-kernel+bounces-168613-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sat, 4 May 2024 12:39:27 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>, Lars-Peter Clausen
 <lars@metafoo.de>, linux-kernel@vger.kernel.org,
 kernel-janitors@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: temperature: max30208: Remove an unused field in
 struct max30208_data
Message-ID: <20240504123927.2d47c232@jic23-huawei>
In-Reply-To: <73f9f540ecdc7c10e833e6fc782324ae7d34ba9c.1714555144.git.christophe.jaillet@wanadoo.fr>
References: <73f9f540ecdc7c10e833e6fc782324ae7d34ba9c.1714555144.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed,  1 May 2024 11:19:41 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> In "struct max30208_data", the 'indio_dev' field is unused.
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied,

Thanks,

J
> ---
> Compile tested only.
> 
> It was added in the initial commit 9ee95ae4cffd ("iio: temperature: Add
> driver support for Maxim MAX30208") but was never used.
> ---
>  drivers/iio/temperature/max30208.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/temperature/max30208.c b/drivers/iio/temperature/max30208.c
> index 48be03852cd8..720469f9dc36 100644
> --- a/drivers/iio/temperature/max30208.c
> +++ b/drivers/iio/temperature/max30208.c
> @@ -34,7 +34,6 @@
>  
>  struct max30208_data {
>  	struct i2c_client *client;
> -	struct iio_dev *indio_dev;
>  	struct mutex lock; /* Lock to prevent concurrent reads of temperature readings */
>  };
>