Received-SPF: pass (google.com: domain of linux-kernel+bounces-168614-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 4 May 2024 12:41:31 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Peter Rosin <peda@axentia.se>, Lars-Peter Clausen <lars@metafoo.de>,
 linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
 linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: multiplexer: Remove an unused field in struct mux
Message-ID: <20240504124131.6c6e3e8e@jic23-huawei>
In-Reply-To: <7bb04abdc2815caf090a6c9ecab2a51d837792a7.1714556499.git.christophe.jaillet@wanadoo.fr>
References: <7bb04abdc2815caf090a6c9ecab2a51d837792a7.1714556499.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed,  1 May 2024 11:41:54 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> In "struct mux", the 'indio_dev' field is unused.
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied,

Thanks,

> ---
> Compile tested only.
> 
> It was added in the initial commit 7ba9df54b091 ("iio: multiplexer: new iio
> category and iio-mux driver") but was never used.
> ---
>  drivers/iio/multiplexer/iio-mux.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
> index edd8c69f6d2e..2953403bef53 100644
> --- a/drivers/iio/multiplexer/iio-mux.c
> +++ b/drivers/iio/multiplexer/iio-mux.c
> @@ -30,7 +30,6 @@ struct mux {
>  	int cached_state;
>  	struct mux_control *control;
>  	struct iio_channel *parent;
> -	struct iio_dev *indio_dev;
>  	struct iio_chan_spec *chan;
>  	struct iio_chan_spec_ext_info *ext_info;
>  	struct mux_child *child;