Received-SPF: pass (google.com: domain of linux-kernel+bounces-168626-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 4 May 2024 12:52:42 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= <trabarni@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
 <conor+dt@kernel.org>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Danila Tikhonov
 <danila@jiaxyga.com>
Subject: Re: [PATCH 2/2] dt-bindings: iio: imu: bmi160: add bmi120
Message-ID: <20240504125228.0efe24bf@jic23-huawei>
In-Reply-To: <20240504-bmi120-v1-2-478470a85058@gmail.com>
References: <20240504-bmi120-v1-0-478470a85058@gmail.com>
	<20240504-bmi120-v1-2-478470a85058@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sat, 04 May 2024 01:45:25 +0200
Barnab=C3=A1s Cz=C3=A9m=C3=A1n <trabarni@gmail.com> wrote:

> From: Danila Tikhonov <danila@jiaxyga.com>
>=20
> Document bosch,bmi120 compatible.
>=20
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> Signed-off-by: Barnb=C3=A1s Cz=C3=A9m=C3=A1n <trabarni@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml =
b/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml
> index 47cfba939ca6..9ca874aea837 100644
> --- a/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml
> @@ -16,7 +16,9 @@ description: |
> =20
>  properties:
>    compatible:
> -    const: bosch,bmi160
> +    enum:
> +      - bosch,bmi120
> +      - bosch,bmi160

Please use a fallback compatible for the bmi120 similar to handling
done for st,asm330lhhx in st,lsm6dsx.yaml

Whilst the driver would currently reject the chip ID, the binding should
assume the driver does fallback handling correctly.

Jonathan

> =20
>    reg:
>      maxItems: 1
>=20