Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp387331lqh; Sat, 4 May 2024 05:34:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUOHofLm8Hq8AUQvS9Sgr4sdCIYWTtgD3FsXcwXcMFR4hd0Dh5t/1kGPYDz+y9xEtYw7F189KCKTBOWE/swusJw/lnaZDoHlNSplBz2oA== X-Google-Smtp-Source: AGHT+IGdb26DoNjigb8f0D49bZOi7VhivTw1YQUP050SoSDk606CILIQY38slebOSeUIm+zQ1+tm X-Received: by 2002:a05:6358:618d:b0:186:102b:777 with SMTP id w13-20020a056358618d00b00186102b0777mr5332092rww.10.1714826096236; Sat, 04 May 2024 05:34:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714826096; cv=pass; d=google.com; s=arc-20160816; b=0HBWVhAZwIA8xeN0GDExphMnC2lEmQJc4Gq1X6iX9a2EQ6gk80vQNdE4EbaJRAzcD6 xTbtaNrT/NtWGiUKl462g11YbxGayRRbEjkx9r/57aQPSmVJ2zao/LjXNn9nMD3rIrsP L/gE4HOYiMMMMgiiwy5POp+7tQ6X5wvli9lfwAgQvG6bXOfCNjbkdgo5eZp8WaUvrtdE vwcU9vMuKDX09kJybSU+RE/aLhGiCqVA+Z/6qQi7VRXBJeheuoBEmsWFPxrk5a6mDIn+ Ry0JcmgwgNlSB4rSifji9oy8F5TFTG2cMl42D4l4WS1LzPbrxx1VFnxwZh1EmFlkXvTB 4V2A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=Dw0wxRu3LYsn0DKAaT4XAl0e0WxvZkPx1TNVOzFQ9z4=; fh=C7Jn2U/WETzVsMJjhbYxzztl64NGnNOYkJhe6GfSPuc=; b=iQlSbMrU1I0UCN8qt1pjU8X9wHDpKZXiRdJCSTzyldDL36ENymYK841VMCR7YqtKK6 TYPirZGdtH7PO2Z39Q9OgErLsHeZSkdaPXy4OkXL0I97LzOQvcRZsrOKWGq4o9sogAVh +Ay8WFJeSt2w64L2F2S2FlZwsRntPU0L1UUwyL3hAddoIOM3zuz27Mp7OibxTy0BqPUY gHp43IIZnV74gyycfhQP79LwUSHOhZaRA8OLbCgbm7Hct/tdzNz3Z7hS3b2LPvYoro8d CrCVV1y2w2IAyEbmVOtQ9/565uBFFU5rxdvcOrEpGuT1I4NKR15ouY4UnCPz6woqqXRY LItA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=LBWlm1z+; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-168648-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168648-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id i9-20020a654849000000b005c661524f67si4675334pgs.26.2024.05.04.05.34.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 May 2024 05:34:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-168648-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=LBWlm1z+; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-168648-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168648-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 69794B20FD9 for ; Sat, 4 May 2024 12:34:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0ACFF22F0D; Sat, 4 May 2024 12:34:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="LBWlm1z+" Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0D038F6D; Sat, 4 May 2024 12:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714826083; cv=none; b=W+whtp+z59pdbYCmPOIDBdUHXnNbz43CdMRR5jMMTO3hdaMx3AF096Y5HIbNPyiLlZy/RbrMaFIsaYXUnxM5TVCg6HXEYXBE9P3X7igQlK+EklJ85XyLlZrCw5YnOHevVpO3w5/mq7yHa/RYQ/NifalcKTPFkELTZkJdNK75fEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714826083; c=relaxed/simple; bh=Yoe79Eg/PZgOm5Mey4BVO1eNMWWZbUND/eB3W2VBhP8=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=o5WTWhdbmtEJaUNKfwoePOiUVTUX831bxgJMeYOM81qhunzvx8vlxMxX+PeX6ioJ40G7ZnCsVqfsPu/M1zL5aBPAkWFab/CudkID2SuYiQOLaGWvkW6mPwjKAje7YVrtmXkv5HB2x5JKv9nghLCqeUvm/tkLqprYcTexQP42TEo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=LBWlm1z+; arc=none smtp.client-ip=212.227.17.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1714826050; x=1715430850; i=markus.elfring@web.de; bh=Dw0wxRu3LYsn0DKAaT4XAl0e0WxvZkPx1TNVOzFQ9z4=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=LBWlm1z+TprBHaq4hs79isSLqS/7ZZKPiUAyhPGMUmrLBvgIPqJYiXvDb/4M9aDo I0LlL/JqCBK1Jc5PI+nf6d3Z/a4Di3++4FMhidtA14SPfnyrQzV4Y2VtM/p5kBohW Q62yhVaGcxUJUAjPaR/xVWgQJKz4z0X8SZySOeZ7+ZeV4uHASE+9u8x472MiUDPzm ysTC/8rjbHe3wdFEuRKlI2umwgDTTO59xikSXGKgeGmzyOBvB+bQy+Fuf1x4E2NHr 8HkDKrKI+ct06Fj1eFMq7WqfMauVukbHZZBfqeXz2ZiXf3DnoEwvA2h1m/VM2kS11 1Ex4y/2O5vD21YkTJA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MkVsa-1sUHQC0gOs-00kLda; Sat, 04 May 2024 14:34:10 +0200 Message-ID: <182b7a9d-73f7-4529-b053-463eb3684c3f@web.de> Date: Sat, 4 May 2024 14:34:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Levi Yun , kernel-janitors@vger.kernel.org, Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Ingo Molnar , Johannes Weiner , Juri Lelli , Mel Gorman , Peter Zijlstra , Steven Rostedt , Suren Baghdasaryan , Valentin Schneider , Vincent Guittot Cc: LKML References: <20240226211237.48415-1-ppbuk5246@gmail.com> Subject: Re: [PATCH v2] psi: Fix avg trigger being fired unexpectedly. Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240226211237.48415-1-ppbuk5246@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:rbevdbydq7HBhBf18M2b49EYFp3SFfcSm82k3YedcewesMYIJFA bA0cfw5Nwvcmwl8PVRIcVDOBkGehMObENLRnOtVdB0GeiOpFLnqJPFYLV4+WUn6OsWKgp5i Ei3gh6pE+54goZDG4vyeckTFocPCcitbiSGoRwG8a+5SDcwVtSx+2hDP43K15Dkwy67c0LK 46gF6tkwZq74qWU5y+Xpw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:di5ere2P8Pw=;Jtoe6CFNxGvFyXGjU+gQK4mcbUy OK+75fDBaCYatvTn0ly7SlBYmqKxCW1WS8j1hy/tZ1wS/wMxdG6/2TkFJijNHYntd0ewK4Ta7 mt2RFAnXXPGPJ8EFP1/G3sN4dPSOPRDrVW7m7/xl1BZw8yT/dKaiPdGRmrIa0ENc2PVg3O+OA 0RjyEFR55HU9+4R51rCTsycWkFQzlApJ/c6LrXL4u+z9EKA04ah/+VvKpUsNhv8aLSvTVzOp3 xEzXtV36J8dTV2TULz1954CAjC2DTA0t2TE78jcLC71f2czJh14gD/AIqm9o2vNnP50MCSkre 1KABePaUvHEJx8fL/mzyH8jE+E08id8ZxDJDElYC56xB0kn5f8Z3DXrJ1fhy+uMVb0gDdQVT9 3X16oSR7O1WBdy2d3kzt0349esNYW3PBgQ64aCm3orlGvnkXzcYLV1K19aTjxQxSRsVixh6Lz SRt+xYM8ZFJg79qs2K1x7J1b7tP0ZpS7SXfvxreODu0xJQ9Z7L42f6NFZ1uRGi1ehU4Ba9cPh EHRr8sx7qoJmDe6HmNT4/AsssLueBQEmjeWNqsjDbYGjIN8ugg970UKawnqL2gYeiul64Y9st wqhsGuQrvGebEFdrbVtkFvOAACJwYamNWQUHBQ8tWkzqcxf6vXEUEmjn6MNhizwUo4k26QiwO IOzWPKLugD4Cgrb3Ej28uy1zCZ+n0Jv7efjXnOWHQLEVtqxHNG0zwwQBf/WOhzoWKbeoFNKfw sMREHfuufTkwwDq3tTNjS8TL4J5bueFyyVjRJ7datzWfSi0uyxYz4nShi34hMVbBBn1q74Abg 0P/424JN2UP9wuD+LztZVu5OWbs/qlbV/LuZ4cnjOuwwUpYCem602sTzUprwI9yZDr =E2=80=A6 > But, for PSI_AVGS, win->value should be initialized with group->total[PS= I_AVGS]. > Moreover, to get exact initial value for win->value, it should be set > under each trigger lock to avoid concurrent changes to group->total[]. =E2=80=A6 > kernel/sched/psi.c | 8 +++++--- =E2=80=A6 * Can imperative wordings be desirable for such a change description? * Is there a need to perform proposed adjustments as separate update steps= ? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= Documentation/process/submitting-patches.rst?h=3Dv6.9-rc6#n81 * Would you like to add the tag =E2=80=9CFixes=E2=80=9D accordingly? Regards, Markus