Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp396519lqh; Sat, 4 May 2024 05:56:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVPfP7n8mF/Kw7UjGzc8Ru0uhefxO2QxO6PdntsnlCCOKJUE+/mMKceRXu5FgEfbgwN4bkMfzfTCs1bk6be/2eIoc4biJKUncQDtY6qBQ== X-Google-Smtp-Source: AGHT+IHBccjRU4Vd5sXam7VUmWx5vUgmlLRmTptJ1+WxcZoQigAAOhwA9ntw9fB5xDUddGm68CJ5 X-Received: by 2002:a50:ab5e:0:b0:570:1de6:8a2d with SMTP id t30-20020a50ab5e000000b005701de68a2dmr3303646edc.10.1714827393676; Sat, 04 May 2024 05:56:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714827393; cv=pass; d=google.com; s=arc-20160816; b=FdTPBLq/3X35ee/veADLfXX1eNz/TdtXGDA08a8mNM8qdsDHEw9ktSUPL0Av4WR+KU hsA44FWxfYyU220ql0kcMI8xB8+kqxZGg9GH6v66hsF1B1gukFVJPGc1Ak/Rkp/HnZKE sBjGoA10BIcCm1QtVaZ663v6giisU7OjFnhqxozmr98O+Ik6HAxqnaEvg6Fes/LGSbih tlhJ23OxEeuQeV3jYV7YF4p4cPaJDz1n+RqxLXmJ1Ty5bw6TadPSDQKAl6/u2N73KDN/ dByifJXEqZg66RXzVt8ikoHHZjc9CurCPyjepYBR0spgyf3+ypBaFG19+6eh9IDUb4r1 tfhw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bs4ANsje8Q7nYM1NaIZVIymPIPwQemK300tz33Vv+Pk=; fh=lxcLD4MP3gK7uoYpPIXrrd2t5CZolXsWf/qTT29N/k4=; b=SLjTR3ypjz546MwNzFTvmaKjx9+PWhaLj17adSntAJgXgUG53nGa71Zav54PLsuzOh IjrQYD0RB7PFMWur9QHKkSxZ/6Bdbt4h8z3yJO0MZnkrSR7oqC6iuXIfgDCLeRypvijT zmwqBQUL+NRBH6c1BC31i7n9TiLk8Swp7V8elV2utU9R7sJrgAjBrTDzBRf+m6mqgoBz T3B86Cmga30anskgEAArY29Mo3p7xfd8KU6dwCgLfzkynxIJ/R1uHt5131hQCz0GTz/K GrW38nJbzJ0tvqRiG0wM99mIxhPknLLiNWBjG1KhnMjBKT/YKNvKQLpT5MOwadsW5rnq ScEQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FsLDu2wt; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-168660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168660-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id t7-20020aa7d4c7000000b005725f2d4f41si2599427edr.379.2024.05.04.05.56.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 May 2024 05:56:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-168660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FsLDu2wt; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-168660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168660-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6B21B1F21F9D for ; Sat, 4 May 2024 12:56:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3D83322EEF; Sat, 4 May 2024 12:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FsLDu2wt" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 649CF1C695; Sat, 4 May 2024 12:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714827386; cv=none; b=E014eDqp8JsldcCZd0IKtOTH3mPCFKHZKN6zTv6LJ5MclLVucJsulJnOH7ZGXl9Buz5wfJLkbWQMyySROWe5u8+igzjVc2UURuPtd7S3MN1c0fv41Su6l2cz1wZ9NIi6Q+PtdtGjTCOiUtI88bCLreJwZ2+pqfL3MeBQfQBKTCw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714827386; c=relaxed/simple; bh=/S4G8XfJkMpXGtDusfPkIrZMVnvP5OxcQ6MlRbPqAHc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AP/8hlZq5h37zKZrn3ywnsx4c82wQkUO7shmrkCJVDM3qOCYzraq9DxI+J0wHT+ixf4muq5BU/iSm3S+RxWq3m6iMEthXfkGT9Xp6SwwyiMNUbzO3wGsTBF6LDVa93rLcynwJfCMZSaeIO23K51Qt0x83ovi71FgrjWyPySPoFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FsLDu2wt; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE462C072AA; Sat, 4 May 2024 12:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714827385; bh=/S4G8XfJkMpXGtDusfPkIrZMVnvP5OxcQ6MlRbPqAHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FsLDu2wtbbytY8Ch0AKfpA4OSEON8edqnyWuKkQ09denVcmCnV7iWA0YDwPOFq63l 70ntRUHR3gIeHsjaPQxaeBv26IUK3q0wAjVtf57t5NKYApUrlJ684S5JEaT4rZM8s+ RacWf45lG5h+qtfmSm4wCgp6rJfLcT5Ze9diOk5G9t20ZfT+o8a3SXbsl/O3AZcSuC KZQJUFhcuilMfFTjncyHgsUCk0SZhlkFFGqfjLFsk/XPpKkL7WGJCGFZqA3fzMoC0z lCzsGMhVcOu5/F5YyVPc1ing5l4ZWtMNPijiEfd3oOL6hhMhPfcFm7IJKDgFFb/BUS daHChHerP5FsA== Date: Sat, 4 May 2024 18:26:20 +0530 From: Vinod Koul To: Bard Liao Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, bard.liao@intel.com Subject: Re: [PATCH] soundwire: fix usages of device_get_named_child_node() Message-ID: References: <20240429004935.2400191-1-yung-chuan.liao@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240429004935.2400191-1-yung-chuan.liao@linux.intel.com> On 29-04-24, 00:49, Bard Liao wrote: > From: Pierre-Louis Bossart > > The documentation for device_get_named_child_node() mentions this > important point: > > " > The caller is responsible for calling fwnode_handle_put() on the > returned fwnode pointer. > " > > Add fwnode_handle_put() to avoid leaked references. This fails on sdw/next for me -- ~Vinod