Received-SPF: pass (google.com: domain of linux-kernel+bounces-168653-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Vinod Koul <vkoul@kernel.org>
To: Dave Jiang <dave.jiang@intel.com>, Fenghua Yu <fenghua.yu@intel.com>
Cc: dmaengine@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>, 
 Lijun Pan <lijun.pan@intel.com>
In-Reply-To: <20240130013954.2024231-1-fenghua.yu@intel.com>
References: <20240130013954.2024231-1-fenghua.yu@intel.com>
Subject: Re: [PATCH] dmaengine: idxd: Avoid unnecessary destruction of
 file_ida
Message-Id: <171482683528.61200.11644725480487646401.b4-ty@kernel.org>
Date: Sat, 04 May 2024 18:17:15 +0530
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


On Mon, 29 Jan 2024 17:39:54 -0800, Fenghua Yu wrote:
> file_ida is allocated during cdev open and is freed accordingly
> during cdev release. This sequence is guaranteed by driver file
> operations. Therefore, there is no need to destroy an already empty
> file_ida when the WQ cdev is removed.
> 
> Worse, ida_free() in cdev release may happen after destruction of
> file_ida per WQ cdev. This can lead to accessing an id in file_ida
> after it has been destroyed, resulting in a kernel panic.
> 
> [...]

Applied, thanks!

[1/1] dmaengine: idxd: Avoid unnecessary destruction of file_ida
      commit: 76e43fa6a456787bad31b8d0daeabda27351a480

Best regards,
-- 
~Vinod