Received-SPF: pass (google.com: domain of linux-kernel+bounces-168718-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <31f1bbfb-733c-4027-834c-98f155562941@linaro.org>
Date: Sat, 4 May 2024 08:00:46 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 14/14] alpha: drop pre-EV56 support
To: Arnd Bergmann <arnd@kernel.org>, linux-alpha@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, Ivan Kokshaysky
 <ink@jurassic.park.msu.ru>, Matt Turner <mattst88@gmail.com>,
 Alexander Viro <viro@zeniv.linux.org.uk>, Marc Zyngier <maz@kernel.org>,
 Linus Torvalds <torvalds@linux-foundation.org>,
 "Paul E. McKenney" <paulmck@kernel.org>, linux-kernel@vger.kernel.org
References: <20240503081125.67990-1-arnd@kernel.org>
 <20240503081125.67990-15-arnd@kernel.org>
Content-Language: en-US
From: Richard Henderson <richard.henderson@linaro.org>
In-Reply-To: <20240503081125.67990-15-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/3/24 01:11, Arnd Bergmann wrote:
>   
> -/* Flush just one page in the current TLB set.  We need to be very
> -   careful about the icache here, there is no way to invalidate a
> -   specific icache page.  */
> -
> -__EXTERN_INLINE void
> -ev4_flush_tlb_current_page(struct mm_struct * mm,
> -			   struct vm_area_struct *vma,
> -			   unsigned long addr)
> -{
> -	int tbi_flag = 2;
> -	if (vma->vm_flags & VM_EXEC) {
> -		__load_new_mm_context(mm);
> -		tbi_flag = 3;
> -	}
> -	tbi(tbi_flag, addr);
> -}
> -
>   __EXTERN_INLINE void
>   ev5_flush_tlb_current_page(struct mm_struct * mm,
>   			   struct vm_area_struct *vma,

The comment being removed applied to both functions and still applies to 
ev5_flush_tlb_current_page.  (Thus __load_new_mm_context instead of a tbi.)


r~