Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp462836lqh; Sat, 4 May 2024 08:03:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVGkMGfx06IKEFuhQDVeT9XNxFCdlcbSCQ6fxjCg0y3ztRRnxF7Cu+5QLnof8rrU34wfWEE7cWnGNCEMGTwK8bhhp2tv1P/FvUgktPjTQ== X-Google-Smtp-Source: AGHT+IF3dkFR5YHJkV+ZOSzifREQx3WS72zXqX6HHG/kFIE2nwDx3IbPGBqYlGb3Ifa8/pJfCuMA X-Received: by 2002:a05:6a00:4b08:b0:6ea:e2d2:5e68 with SMTP id kq8-20020a056a004b0800b006eae2d25e68mr7972404pfb.27.1714835036947; Sat, 04 May 2024 08:03:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714835036; cv=pass; d=google.com; s=arc-20160816; b=gqeH5NovD1cnZ6uzl3//rT9BHV7Sf32ESsAn4lh+OJPuCtzHvrXqr5CWFyR8hReDgh 8z/KMXsLW3f0RhJjG4f5bwO7NN5XgGQm/oRWTxqFLFOgK1lnGRdClQxv3MC2A/EpYoin nxNRhtxipir1mSRBN2sQXbPJmmfccmhCV2QZKP4Or4Rjsw7jzVl3sksa14/LUrAxOFRP 5BpUW0NZo4ckb9hX+Knxhi+75FutcybU9xVAf44faj536jlsLYlZ6rrxXG54glMkTwdC MPMpYKMNusnA4ebFCuEQCCyHDhp+t3cUMa8FUGPkSR+mMnNIv7jTdUeRNNhbSAXKdmaM NhUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xKX/fEW8DWnYgbHX5LwwBK36nAj55HV2JiDX2ILFyrs=; fh=CnfO0PEWHANvE4DJKjo1fsLHfnNk+BkHZonTCtbYfG4=; b=YW9Dxd/03PyyT34hUPyOhXLd5G6m8Bhz27YZhGAGLgr36vwikHMojbydsOA83cbqBw RLuk7Ikfa9eIx5NFm3Y+bA/P1dG9LCoQ6rGUOHAl9iuetXSHqFjsi28sMdzh+ds9OjIi tT0C0ZcutE0b99wIpxTY18ysV2LA9DYNcYaV8P56vEsSSIytaNaGJWGHXLbSWTjGVn7l YQlGs9wDkuRRwAPWBpPaTnTvET3zK234vEnZgMMFQMjs+TRMK38E+qP2JKrepiVAdNgy AeFJ/5OgFaGqOdLPzkPKthhVDC9mF/NjTT3d/Tiq3NmhsZAf5bCSKDlUKismoSWPB/hP uLwQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A2WYKMKw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-168721-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168721-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id k6-20020aa788c6000000b006ecea2c6a4csi5180707pff.380.2024.05.04.08.03.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 May 2024 08:03:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-168721-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A2WYKMKw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-168721-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168721-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 22E03B218E4 for ; Sat, 4 May 2024 15:03:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7A6244AEE9; Sat, 4 May 2024 15:03:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A2WYKMKw" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9695C4F890; Sat, 4 May 2024 15:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714835003; cv=none; b=ipWhSUidahn/L7oW3MgzUDOeBLyQvl4gS1fW1nUjNcBfnbh8kX7v0e5WkNMWmXJnODXfqUeLkhNAUiOHWTHYVP9YaR3F7/bEHIhZZ79httHAsrPdLgrykMn+UMQ9FKrocjOjnLOTKhyHgToinCEXFRjVzb6Otxf8mA3QJAzBbHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714835003; c=relaxed/simple; bh=jLGPDd62/VmNapLCYXtF14n4GE2XFUNRJLO80edDP9s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GvmoErQXki1OJhMb4+kHmw0MaYM7d8xFIs16Zqib9rIvFFqFkk8hbDz/M8iF2XFQ/3x2P/yhk2caR0zPUT51MYeSwtMmUoRl8EQvurD/je2jbJ5nEuE/NkgupZNw55D+vNku6DI8j5KeY6ZZr5+eRvyOL587d8g+FbzNJ5Lxp+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A2WYKMKw; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F536C072AA; Sat, 4 May 2024 15:03:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714835003; bh=jLGPDd62/VmNapLCYXtF14n4GE2XFUNRJLO80edDP9s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A2WYKMKwx6cltikOJwmSgNOCJMaZ0PFn6LMyBEVfRrgEzhiE4OfKyCaK7xsXFG6yC 8eZDayYNxgSIkJ/AjqYJ3QOG1+J1zZ7BX9r7EbXYWT0bzzPQFNSt/a67SYqFlQzKle 2jx/w/v6j2zzD1iYKhmx0ah9C2eKs4lbKCJjte86BXaAfIjVeli8k5bAIr705ot0b2 86NS7iritlXR3ScKXMRJFtmP8LieprUTRDEhrDKGGljsVZF5BfSlxaEC+0vuq+kyXY A9xkIC89z0aquXC1KdmntemaHbndqhclsvH7YsWioLmCCDLAseZED6zqfu2TZd34Bo Q1WBH4rlhwvcA== Date: Sat, 4 May 2024 16:03:19 +0100 From: Simon Horman To: Breno Leitao Cc: Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , netdev@vger.kernel.org, "open list:HFI1 DRIVER" , open list Subject: Re: [PATCH net-next 2/2] IB/hfi1: Remove generic .ndo_get_stats64 Message-ID: <20240504150319.GH2279@kernel.org> References: <20240503111333.552360-1-leitao@debian.org> <20240503111333.552360-2-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503111333.552360-2-leitao@debian.org> On Fri, May 03, 2024 at 04:13:32AM -0700, Breno Leitao wrote: > Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is > configured") moved the callback to dev_get_tstats64() to net core, so, > unless the driver is doing some custom stats collection, it does not > need to set .ndo_get_stats64. > > Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it > doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 > function pointer. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman