Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp467699lqh; Sat, 4 May 2024 08:12:17 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUJk1yng2hc5KouCoaY+/E90S7XxhkdywXREmiGQWeTaX1zZ07HDXvtBRlkslHYI5x9wWLu23vgchmz87GiZRWyK2pY/BqOahRny+z41w== X-Google-Smtp-Source: AGHT+IGxLq9tSdUP8BSTLItk21ljftK2DnlPVu82gLBDqx1dI7cPYg+Uk7FO5CFFdaPecYyJeijt X-Received: by 2002:a17:906:493:b0:a59:63da:f8b with SMTP id f19-20020a170906049300b00a5963da0f8bmr3418506eja.48.1714835537084; Sat, 04 May 2024 08:12:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714835537; cv=pass; d=google.com; s=arc-20160816; b=rdd6CrVr3hQMEfcmQHgjSsCz6p/lSxnTzuVZqm3QG3wXbMkDXPmF8mnAFOpvVVjn7l zHcLARY9twuk4Oi5HNb4TbPaIPFm1P3xylIONt3dpdtWvfsMLsF/VDUMF9M8LkP3Xi71 i8b/AMdrIPQtTFt6mlEOz23WnHDO5853tIeQJPHBkzJL01wFNPWTdw7/oiUUr+H+03iI 13ujuLUYGyJRYY8lARQIY+nrlveWcv3EuFYYWvvyGP5gYAtzPASivoim3ogh2/l4peGc FTZbTJYuyJ4BXwO30NziJ2MXWtAjbDKzrIJIfV5QXbJWKoibPiWvJn6bE3jzQn/Eo97U Z7Vw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3qmqIM3Kbt1Esq38JTJzcLFLx/RxtdVJ+xVuREObmtk=; fh=CnfO0PEWHANvE4DJKjo1fsLHfnNk+BkHZonTCtbYfG4=; b=EsEFVoGfREQRiTs98EGZMvOS8k0+1zqF0uB6nG7EbD6yVoBDOEGUGM1NpgTK7rM7PO yIqFs9tuStmz+KMlp7iM9otMBGiHxbuFKBD682ArLq7XTKW7FyKiQZp79gdvdh4pvQWJ p/bLwhZbh5TzBA3TRgbV4OvV/YF0NDRIr+NxshVADKesPeFf3Roes/eL1NKQFxDgsAbv s5EkmrWUdV9g2HwDx0qVH78asaLG38Um2JYGt04Jtym0isQBHEVnTnxSCzntPJXTVfwF ylZDnaC+DEO1rkjbhhLE15WOky36Ce9fk49bD4T5TtbiZlatIyYEbHjV9kaZoSl5dmxO +6TQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kHYXS9gq; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-168720-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168720-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id gb38-20020a170907962600b00a5986ad0d63si2261717ejc.344.2024.05.04.08.12.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 May 2024 08:12:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-168720-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kHYXS9gq; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-168720-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168720-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2EC3E1F224B6 for ; Sat, 4 May 2024 15:03:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A3B4F3C467; Sat, 4 May 2024 15:03:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kHYXS9gq" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFD773BBC9; Sat, 4 May 2024 15:03:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714834991; cv=none; b=enbBJWdrMy5h8D/fkgWs1dKyD2BaVCtE0AUiGuC7kiyLpE1xLihRbM/O4LIlFaTq59ISZS/GroRDxQdT90A2haXwLWkNS2qOOkHbQuLw4diRevz9Mp9RWSHP5oGibojZE81ytaUYAeB/3RQJYUUd7FyyrM+CBhXZyQoVFQYQKos= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714834991; c=relaxed/simple; bh=nlHEbbDlAr9zsDN0ZnWIgUl+/rNIUoQHhTMpZKbt2p8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BpjhZpyg087x9e6mI32mggS1I1yIXvRF2o5nsDYlARoxGJ+yl3GoEbRUiN7eNJm+aXWADdrwaWpIGcDl6lwwWq6srtc7pRtTq9kbpllRRR3gBjwyDAR04ZAb0Souf/X0jaUir2vFf67W4Cmqwxz8VxSju1Ndf8W0fLAmgPTOMuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kHYXS9gq; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEDD5C072AA; Sat, 4 May 2024 15:03:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714834991; bh=nlHEbbDlAr9zsDN0ZnWIgUl+/rNIUoQHhTMpZKbt2p8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kHYXS9gqNtubOVh4mLAcjfhbAWHcavAF0ANAfBuqwD1y/jPJGqJ24tERiZQwwJ+Lc iIV7pQuXycGvAvOhNRHxkWvu6hlDOouzHXEU9hZn5FJYgsopQtonGsw9Gf2WqKWyk7 H3DC2aTrr3/HJeu3hqa+QZ16spqawGDiRWMHiAtAm0FfMrRceZXvAAnoIF7pV5iVU5 c5/LzvVXwxrjnTcHuc+7xhRZDlSVZXNulFjcqQoickcCNJKGUDIgT5Ixiv1YPBgw9s Bg+sqLqynaYGG/tn21NTT1wH8hhKPTyd7bZpH5Exj/zMuBd5h0Ug3E9QAm1/7DOggt 2dEBkPbwwg/og== Date: Sat, 4 May 2024 16:03:07 +0100 From: Simon Horman To: Breno Leitao Cc: Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , netdev@vger.kernel.org, "open list:HFI1 DRIVER" , open list Subject: Re: [PATCH net-next 1/2] IB/hfi1: Do not use custom stat allocator Message-ID: <20240504150307.GG2279@kernel.org> References: <20240503111333.552360-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503111333.552360-1-leitao@debian.org> On Fri, May 03, 2024 at 04:13:31AM -0700, Breno Leitao wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of in this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Remove the allocation in the hfi1 driver and leverage the network > core allocation instead. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman