Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp479134lqh; Sat, 4 May 2024 08:36:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW6Bq3J7CEZjCLKoPx9gGuIqzThCxnUbq6LlFBPN/Dfy4RGLWAL4EMKUYkDo92m1axk4+Sq2OBS2p1a4LcqTGdWPEoYcakRvYE89DZmzw== X-Google-Smtp-Source: AGHT+IEJGbOja/bQfciqnR10JLmsKVs6zqVlhuRnfgVpvh+DqbW1Sk893odQSUiLwtJLvXSFGpYA X-Received: by 2002:a17:90a:8c5:b0:2b4:a767:193e with SMTP id 5-20020a17090a08c500b002b4a767193emr1663496pjn.38.1714837015898; Sat, 04 May 2024 08:36:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714837015; cv=pass; d=google.com; s=arc-20160816; b=fyx4TnuWRQZZ2TTxlAhbgsjfM8fngekJsOqji6otpZSFCrLxvA+deDNTC53xCips2V 2eA4R/nf2ToXdRsPo+zKhJ4z6r3g8mNQfwEr6sMkIn3wDzsvRQKm1aNqGmCnZjVvRdYB NOIS7O+Q3ig2cIKh2qvuUgcWri21nxFbZQLj6FXcGkACFTbTn5qaICQ/BRf2D2SVt5Zl +AsGlkTwZSDEmTJQ2uLH1Bq9qssDpgoqGu+IajrUTEvyJ8QBB4PGdiiE/2ZTXrOKr8mt 2ebbTXfvOdDJAS5ZGfBYbhUI2NN5rlJDfayPEMAE2+PaVmrp6NS/KYw7QFlvXl/y9nry cyUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=BEHfgGo/0W1gAL/HvOUGuMMBGSuTJXz3WVsWmH84pNc=; fh=oE223nOduY06XtwBruVQxcT0l6Npa2QvQClrlquSf6A=; b=Q/M1T7gS+S0MK8PS8+Hd13q1R/dZq6MYJ8BunmZum36p4CUfBWA2vgC7nyzTVSRRqT v2SAz47ttFuCudnWHavyUiaon2oB+OavnSdA05/nP7YjjLS9Sw3UR8zHy2ix6iue3Q8x y80IsqknlEQpvYpVNG/1VaMJzI1IBe4LACzq5mhz+PS7feMliQlcdR0chDcNqKR2RZLy xO5QxisSkpjQ/aQJC5z8OrSTy1x3UPSrd6WKiZFQa/82WYc4aSAwv2dih3EOkUz6OPGM Vn9ohpyc3PEn1YqldYLlCg07feodfNsfn9219Msd3a4+4A8p6y4zDXt16M7Zt3I56GVd lgcA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gOU9LDkG; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-168730-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168730-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id i3-20020a63cd03000000b005f806507f96si5225392pgg.847.2024.05.04.08.36.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 May 2024 08:36:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-168730-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gOU9LDkG; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-168730-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168730-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5CD29B21606 for ; Sat, 4 May 2024 15:36:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8682A4EB52; Sat, 4 May 2024 15:36:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gOU9LDkG" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 950431EF15; Sat, 4 May 2024 15:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714836983; cv=none; b=E5Qo2Uwp7awEGE1Fk5ZI+NKg2fBV3X69YM8O/oXSrXXDtYrMdwGeK470YfUNtrNi97IsB5AF3m9u9cDkS6Qe8At2R4i2UFV6n0m3Eu8YyctVEd1F+n4q2q6s+PYEf3idkOTkGd08Ma8tNLJTjrcM/ERaeIMomJgjrMrH5HIfqUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714836983; c=relaxed/simple; bh=nwu87VDHK729eGU2R6RqtqlA5jPb1XtrfjcVNZX2UW8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J21/PYB7qQ2+f0S3VyffdpUEX8AnVZuizU+THbuxGVAXkjodOpWl7hWWD3mzzgbjJgXgj48uUlR0AQL93hdqFivcEcW0NZbJzjUEaScPaoMkGfLsu1aAh3fN3JaTnRcMg9MBZXrMFKjBVCgm+7O+wdFiT9F2F2quwQOMPkUAeQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gOU9LDkG; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92CBEC072AA; Sat, 4 May 2024 15:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1714836983; bh=nwu87VDHK729eGU2R6RqtqlA5jPb1XtrfjcVNZX2UW8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gOU9LDkGC/Nk0n7vDBEZnWdd/OxMBxqcUv0bWurd537fHJ4jcdyDDcv+QbZAK3nE/ ++E8Cs160Smi3bmrYhGFtE6q5sBfTKr4b7AubdwbVrdiO9sZW2n1rHLERpHgtLVwFL eCOt84oekveT8FaBGhnj3Hf2FmZa93ZVT3j5PrVE= Date: Sat, 4 May 2024 17:36:20 +0200 From: Greg Kroah-Hartman To: Lukas Wunner Cc: "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org, Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, Dennis Dalessandro , linux-rdma@vger.kernel.org, Shuai Xue , Will Deacon , Mark Rutland , Jonathan Cameron , Yicong Yang , Jijie Shao , Bjorn Andersson , Konrad Dybcio , Khuong Dinh , linux-arm-kernel@lists.infradead.org, Corentin Chary , "Luke D. Jones" , Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, Azael Avalos , Hans de Goede , Ilpo Jaervinen , platform-driver-x86@vger.kernel.org, Anil Gurumur thy , Sudarsana Kalluru , Tyrel Datwyler , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, Don Brace , storagedev@microchip.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: Re: [PATCH 0/6] Deduplicate string exposure in sysfs Message-ID: <2024050409-confident-delouse-a976@gregkh> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, May 04, 2024 at 04:31:42PM +0200, Lukas Wunner wrote: > Dear Greg, > > On Sat, Apr 20, 2024 at 10:00:00PM +0200, Lukas Wunner wrote: > > Introduce a generic ->show() callback to expose a string as a device > > attribute in sysfs. Deduplicate various identical callbacks across > > the tree. > > > > Result: Minus 216 LoC, minus 1576 bytes vmlinux size (x86_64 allyesconfig). > > > > This is a byproduct of my upcoming PCI device authentication v2 patches. > > > > > > Lukas Wunner (6): > > driver core: Add device_show_string() helper for sysfs attributes > > hwmon: Use device_show_string() helper for sysfs attributes > > IB/qib: Use device_show_string() helper for sysfs attributes > > perf: Use device_show_string() helper for sysfs attributes > > platform/x86: Use device_show_string() helper for sysfs attributes > > scsi: Use device_show_string() helper for sysfs attributes > > This series hasn't been applied to driver-core-next AFAICS and the > merge window is drawing closer. > > So far only patches 1, 2 and 5 have been ack'ed by the respective > subsystem maintainers. If the missing acks are the reason it hasn't > been applied, would it be possibe to apply only 1, 2 and 5? > > I would then resubmit the other ones individually to the subsystem > maintainers in the next cycle. I'll just pick it up now, thanks! greg k-h