Received-SPF: pass (google.com: domain of linux-kernel+bounces-168744-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 4 May 2024 18:10:36 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/1] serial: 8250_pnp: Simplify "line" related code
Message-ID: <2024050421-daredevil-excess-3b96@gregkh>
References: <20240423134930.67033-1-ilpo.jarvinen@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240423134930.67033-1-ilpo.jarvinen@linux.intel.com>

On Tue, Apr 23, 2024 at 04:49:30PM +0300, Ilpo J?rvinen wrote:
> 8250_pnp sets drvdata to line + 1 if the probe is successful. The users
> of drvdata are in remove, suspend and resume callbacks, none of which
> will be called if probe failed. The line acquired from drvdata can
> never be zero in those functions and the checks for that can be
> removed.
> 
> Eliminate also +/-1 step because all users of line subtract 1 from the
> value.
> 
> Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  drivers/tty/serial/8250/8250_pnp.c | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)

Doesn't apply to my tty-next branch, can you rebase and resend?

thanks,


greg k-h