Received-SPF: pass (google.com: domain of linux-kernel+bounces-168768-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <e4dd9e08-6685-4b67-8410-ccdf91b1597b@gmail.com>
Date: Sat, 4 May 2024 19:20:29 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] selftests: filesystems: add missing stddef header
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
 Shuah Khan <shuah@kernel.org>, Christian Brauner <brauner@kernel.org>,
 Miklos Szeredi <mszeredi@redhat.com>, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Javier Carrasco <javier.carrasco.cruz@gmail.com>
References: <df1df586-188e-4290-9986-7b7cd31710e3@collabora.com>
 <20240422131659.30222-1-amer.shanawany@gmail.com>
 <9cba6633-b1dc-4cde-b326-609855c6418a@collabora.com>
Content-Language: en-US
From: Amer Al Shanawany <amer.shanawany@gmail.com>
In-Reply-To: <9cba6633-b1dc-4cde-b326-609855c6418a@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 4/22/24 15:49, Muhammad Usama Anjum wrote:
> On 4/22/24 6:16 PM, Amer Al Shanawany wrote:
>> fix compiler warning and errors when compiling statmount test.
>>
>> gcc 12.3 (Ubuntu 12.3.0-1ubuntu1~22.04)
>>
>> statmount_test.c:572:24: warning: implicit declaration of function
>> ‘offsetof’ [-Wimplicit-function-declaration]
>>   572 | #define str_off(memb) (offsetof(struct statmount, memb) /
>> sizeof(uint32_t))
>>       |                        ^~~~~~~~
>> statmount_test.c:598:51: note: in expansion of macro ‘str_off’
>>   598 |         test_statmount_string(STATMOUNT_MNT_ROOT,
>> str_off(mnt_root), "mount root");
>>       |
>> ^~~~~~~
>> statmount_test.c:18:1: note: ‘offsetof’ is defined in header
>> ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’?
>>    17 | #include "../../kselftest.h"
>>   +++ |+#include <stddef.h>
>>
>> Signed-off-by: Amer Al Shanawany <amer.shanawany@gmail.com>
> You missed the reviewed-by tag from previous iteration. Putting it here again:
>
> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>
>> ---
>> V1 -> V2 added compiler warning in the patch message
>>
>>  tools/testing/selftests/filesystems/statmount/statmount_test.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/filesystems/statmount/statmount_test.c b/tools/testing/selftests/filesystems/statmount/statmount_test.c
>> index 3eafd7da58e2..e6d7c4f1c85b 100644
>> --- a/tools/testing/selftests/filesystems/statmount/statmount_test.c
>> +++ b/tools/testing/selftests/filesystems/statmount/statmount_test.c
>> @@ -3,6 +3,7 @@
>>  #define _GNU_SOURCE
>>  
>>  #include <assert.h>
>> +#include <stddef.h>
>>  #include <stdint.h>
>>  #include <sched.h>
>>  #include <fcntl.h>
Hi,

Could you please consider this patch?

Thank you

Amer