Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp535888lqh; Sat, 4 May 2024 10:50:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW89SdLa+gAIxF+WEIosltQ3fo1kSBY9TQ15rCasyxP9PIPa47N5TKuiVPixsRRPLf+2bLrQ+We1T+r3sjxhmM3pr3afn+hrYaoYbTZDQ== X-Google-Smtp-Source: AGHT+IFch9RzGo9+82xz3Og1/oJs9cTNMNCs/L98zJMIR58j7yFE+vXdKF7nhOLNsXjQ9Jel7sK7 X-Received: by 2002:a17:906:52c1:b0:a59:2e45:f528 with SMTP id w1-20020a17090652c100b00a592e45f528mr4045956ejn.38.1714845058917; Sat, 04 May 2024 10:50:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714845058; cv=pass; d=google.com; s=arc-20160816; b=IA8Mf1GGl5L1HSR66It9SKjzt1vMHEl+5eU7rnWV0YEU4ZLxd30di5dOn0N2/qRoUf 3xIbz6JFY97do/KAQrE6j05QJcDobG6cRkM/pz8+9pcqZLhjsFUUT5H9eZdHDFPjbCd0 u9vHs2Bvgu+bzm/yJ9Rb9ttcOoiyiJX07dUheb+ezutVPjOX389PGRJBeo8FADjqrU8T +ivMMJzBNmVhY+DY9HIX1t87JcIxJvSJdmO3INhowkJC/l/O2z7rehT06wPnZeg/lL4T d5jJnKUac8l+v5EQ/e8BaKCoJ1qgUtWBr0yz4VEBrAmywniLMPXeKbuTaLRioOdPs9vM 0M4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=TRzbcihXI24SCuYOsVfgrVXS+13k3RWWLtY2qXmne2s=; fh=C0S34c8Iy8hH7K8VAEAcFYnSuBFL85Uj9TSxc27HOpg=; b=HlOmViFAedJoIMwfHg3/p9v1Nu+qvd6tFhRfHOj02dEoDcRcGAw/WU63KHBAmyq25A 0kWlaeHc7x3VmVz/KJpo8vc0Ucr94j0NbAEgwHrRe0z3sqEJHm+nXrmGi0AGsjVCwABA pJHLAzXNzMH2/1Y0VxY/1qKOGOje5LzFr47/LFMKKHGw6qI0EVDhAxhP0J/h+DBZc/o7 MgDBE82HdfI3g95agvVG0vokNuw1bsunLok/wJ5tSr5DPMnReMOSiPBMvxmQV9uIvXQ7 KgZ1uyCtksiqbhxHMiJsWWsjF1lPegNB0uBPtCUDQqd1HSd4QunKRhQem1jKkZooFAt1 QxTA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="A3JyYr/s"; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-168773-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168773-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id f6-20020a17090660c600b00a5906af82e9si1763617ejk.598.2024.05.04.10.50.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 May 2024 10:50:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-168773-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="A3JyYr/s"; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-168773-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168773-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A33711F21BFD for ; Sat, 4 May 2024 17:50:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B280766B5E; Sat, 4 May 2024 17:50:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="A3JyYr/s" Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E934159B78 for ; Sat, 4 May 2024 17:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714845051; cv=none; b=O2rZ5dVKMXZebDO5jpTtMQhqMMLwJ9r0ZbUOAH3SQ0UEOFSF1y63aVd+3GKocf3dlZ8ZkwsiwH1zixoX42VamkUHqXKbPCAWlMHAsg8+uLorz2tzzq87vlD3GNx4oE0sdLVXZfdjcizWZR6bS5PYO/G/1+74Ojyryd87HDjhMyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714845051; c=relaxed/simple; bh=vNJoGAUUvHdGoycuhcgj0oJQMe4+8XP0PvAVk1NVaj8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=OGWXy+/2oTIY3JEgzuPmK7Pk1u7ji85mRhqDvNqgQrdqbzTySv0Utn23jaNqMdkoiAmJU+A/8T0dHfHdjhiAC/wCzlNrDSD/jG+hhfBn4BTRJrsj6zp00PlQFSz5gy46DVXqPxNJqhG2OlKiduEoU8P/UKHfozrhkqQV3MFAy/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=A3JyYr/s; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a598e483ad1so144722766b.1 for ; Sat, 04 May 2024 10:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1714845048; x=1715449848; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TRzbcihXI24SCuYOsVfgrVXS+13k3RWWLtY2qXmne2s=; b=A3JyYr/scBjjeFKvt+K4O2zu8Fhz7LemuwfKnlQDeX+udqpxg1FKSWTD3K78UzKf1J vsbGtoERFBEmNdml8R4QooQciBWmuYh+LVK/4dIP/QYibvoRa8+E9QklTvORbAqeDDdK 3gGNiQZhhwB1YNRh6LbV1ABu2847PIYMbGMvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714845048; x=1715449848; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TRzbcihXI24SCuYOsVfgrVXS+13k3RWWLtY2qXmne2s=; b=EOwaAkSvH3q877K+G4XJQ6uu4J0JDv1Jv7dkVeqbEqamDMYm24hsZBcEJLpLJ7IgQy LcDAXCHlqtw15HP7ICQhN7uGomC8+yF1zOsTDNC9DNmM205aIl7VTRV8tU3f0zE18ZNF 2YDP7uUyPDLNyUb53AI7/H+pfxYIeRw/8S2gnTf6R6V44ITv2/jzk5KNT06mVrBEM5KG I+0mHk4Bj6cEMbNmYgvIGsYlk+Nctxc0xrWDRFJvuaEm5HnjEATHsmfUooYC7yw9WN9P hVZKxwZ/sRx39ldbB5bFA9fWi+NgwRAZHjUS5+XHxMrW6RDSr1XO8TmNuoFIOPsUUt16 +oKg== X-Forwarded-Encrypted: i=1; AJvYcCXzUeGiues9RMBrJySyZ3wdi5WyM+CjECazJQOCEZdzgV6c8emRtj+8MX9Hizhf9H0typcAuswu/EJgdtxNw0IEsRs65uwml7+c5V4n X-Gm-Message-State: AOJu0YzyTd2eE9Y4s2yWn4dKMUEaTy1vrqLtceVWLJaKxNwQIVlkK/vc XXfL+QRoQ0Mbh1/WRT57tl6bkGOKkPckY2AK0SREon4ORN9ve/qTPbHGb1mBl+dcVHKyMnWCtRg d0c2goQ== X-Received: by 2002:a17:907:7243:b0:a59:b490:6e62 with SMTP id ds3-20020a170907724300b00a59b4906e62mr763132ejc.40.1714845048029; Sat, 04 May 2024 10:50:48 -0700 (PDT) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com. [209.85.218.43]) by smtp.gmail.com with ESMTPSA id j21-20020a170906051500b00a59291b5551sm3147363eja.63.2024.05.04.10.50.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 May 2024 10:50:47 -0700 (PDT) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a598e483ad1so144719166b.1 for ; Sat, 04 May 2024 10:50:46 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX4PYowdM0+sv5zwNkigDnEvxHVVkxK6K7Ckl+wCf9rhtRUkQvQik+94pRInIS7S5Q7eDY6mBaR0wB6Mj1zn7rTq9qLlKj88/WTX+iU X-Received: by 2002:a17:906:abd8:b0:a59:bbd6:bb39 with SMTP id kq24-20020a170906abd800b00a59bbd6bb39mr209514ejb.55.1714845046603; Sat, 04 May 2024 10:50:46 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <892324fc-9b75-4e8a-b3b6-cf3c5b4c3506@paulmck-laptop> <1c886023-ae61-46ba-bb3c-b460c30de937@paulmck-laptop> <2beaba9f-6f83-4a7c-8835-fe5fe88a006c@paulmck-laptop> <3f2c415d-dc7e-4647-9002-4beb804d885c@paulmck-laptop> In-Reply-To: <3f2c415d-dc7e-4647-9002-4beb804d885c@paulmck-laptop> From: Linus Torvalds Date: Sat, 4 May 2024 10:50:29 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] tty: tty_io: remove hung_up_tty_fops To: paulmck@kernel.org Cc: Boqun Feng , Marco Elver , Tetsuo Handa , Greg Kroah-Hartman , Dmitry Vyukov , syzbot , linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Nathan Chancellor , Arnd Bergmann , Al Viro , Jiri Slaby Content-Type: text/plain; charset="UTF-8" On Fri, 3 May 2024 at 22:08, Paul E. McKenney wrote: > > You are right, this is going to need some arch-specific code for a few > of the architectures. Hey, I was hoping!!! > > The compilers do not currently optimize these things, but things appear > to me to be heading in that direction. Ok, so it sounds like right now it makes no sense - presumably __atomic_load_n() doesn't actually generate better code than READ_ONCE() does as-is, and we have the issue with having to make it per-architecture anyway. But maybe in a couple of years we can revisit this when / if it actually generates better code and is more widely applicable. Linus