Received-SPF: pass (google.com: domain of linux-kernel+bounces-168843-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 4 May 2024 15:24:02 -0700
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Youling Tang <tangyouling@loongson.cn>,
	Jinyang He <hejinyang@loongson.cn>,
	Huacai Chen <chenhuacai@kernel.org>,
	Tiezhu Yang <yangtiezhu@loongson.cn>, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH] objtool: Provide origin hint for
 elf_init_reloc_text_sym() errors
Message-ID: <20240504222402.p24zt6dc2zkyxqti@treble>
References: <20240430235106.work.680-kees@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240430235106.work.680-kees@kernel.org>

On Tue, Apr 30, 2024 at 04:51:07PM -0700, Kees Cook wrote:
> @@ -891,8 +892,8 @@ struct reloc *elf_init_reloc_text_sym(struct elf *elf, struct section *sec,
>  	int addend = insn_off;
>  
>  	if (!(insn_sec->sh.sh_flags & SHF_EXECINSTR)) {
> -		WARN("bad call to %s() for data symbol %s",
> -		     __func__, sym->name);
> +		WARN("bad call to %s() for %s symbol %s",
> +		     __func__, origin, sym->name);
>  		return NULL;

Thanks for the patch.

That warning was already phrased pretty awkwardly which was probably
part of the confusion.  It could be rephrased to make it a little
clearer:

Something like:

  .cfi_sites: unexpected reference to non-executable symbol 'execute_location'

And ".cfi_sites" is already in 'sec->name', so you wouldn't need to add
the new 'origin' arg.

-- 
Josh