Received-SPF: pass (google.com: domain of linux-kernel+bounces-168847-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 4 May 2024 16:10:04 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: kernel test robot <lkp@intel.com>, Minchan Kim <minchan@kernel.org>,
 llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory
 Management List <linux-mm@kvack.org>, linux-kernel@vger.kernel.org,
 linux-block@vger.kernel.org
Subject: Re: [PATCH 08/14] zram: check that backends array has at least one
 backend
Message-Id: <20240504161004.f5a0aab5e5aa1033d4696c20@linux-foundation.org>
In-Reply-To: <20240504071416.GH14947@google.com>
References: <20240503091823.3616962-9-senozhatsky@chromium.org>
	<202405041440.UTBQZAaf-lkp@intel.com>
	<20240504071416.GH14947@google.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sat, 4 May 2024 16:14:16 +0900 Sergey Senozhatsky <senozhatsky@chromium.org> wrote:

> On (24/05/04 14:54), kernel test robot wrote:
> >          |                            ~~~~~~~~~~~~~~~~~~~~~~
> > >> drivers/block/zram/zcomp.c:214:2: error: call to '__compiletime_assert_285' declared with 'error' attribute: BUILD_BUG_ON failed: ARRAY_SIZE(backends) <= 1
> >      214 |         BUILD_BUG_ON(ARRAY_SIZE(backends) <= 1);
> >          |         ^
> 
> So this is what that BUILD_BUG_ON() is supposed to catch. You don't
> have any backends selected in your .config:
> 
> # CONFIG_ZRAM_BACKEND_LZO is not set
> # CONFIG_ZRAM_BACKEND_LZ4 is not set
> # CONFIG_ZRAM_BACKEND_LZ4HC is not set
> # CONFIG_ZRAM_BACKEND_ZSTD is not set
> # CONFIG_ZRAM_BACKEND_DEFLATE is not set
> CONFIG_ZRAM_DEF_COMP="unset-value"
> 
> Which is invalid configuration because it means that zram has no
> compression enabled.

We don't want s390 defconfig to be doing this!

I guess just pick one if none were selected.