Received-SPF: pass (google.com: domain of linux-kernel+bounces-168911-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240417134237.23888-1-bavishimithil@gmail.com> <2e179356-425d-48cc-84db-0ea3e6203fba@kernel.org>
In-Reply-To: <2e179356-425d-48cc-84db-0ea3e6203fba@kernel.org>
From: Mithil <bavishimithil@gmail.com>
Date: Sun, 5 May 2024 13:06:42 +0530
Message-ID: <CAGzNGR=pvv67UJtNnkDUMhrpnPjNCCYEGeCaM7e_9=4G+Lcfgw@mail.gmail.com>
Subject: Re: [PATCH v4] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 17, 2024 at 7:33=E2=80=AFPM Krzysztof Kozlowski <krzk@kernel.or=
g> wrote:

> How did this happen? I see this was in v1, but I am quite surprised to
> be listed here. I am for sure not a maintainer of this binding. Choose
> driver maintainers or platform maintainers, worse case.

I might have overlooked this, will fix it. There is no driver
maintainer for it as far as I know.
Should I include the module author?

> Not much improved here. You miss $ref and optionally constraints.
Something like this
    $ref: /schemas/types.yaml#/definitions/string
    enum: [mcpdm]
Didnt really understand the "optionally constraints" part.

> Missing constraints, so replace it with maxItems: 1
Similar to how clock-names are handled?

> List the items. I asked to open existing bindings and take a look how it
> is there. Existing bindings would show you how we code this part.
  clock-names:
    items:
      - const: pdmclk
    minItems: 1
    maxItems: 1
Something like this?

> Just one blank line.
Removed.

> That's wrong address. Old code does not have 0. Please do no change
> parts of code without reason. If there is a reason, explain it in the
> changelog.
>
The checks were giving a warning if 0 was not included hence, I'll put
the real address if needed then.

> Include header and use common defines for flags. Just like all other
> recent bindings.
>
There's no defines for them, this is how it is in the dts :(

Best regards,
Mithil