Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp880279lqh; Sun, 5 May 2024 06:12:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXko5DvaclCdMxxGUCtNha7SaDeRZLqYsnCvEbscjvEcVHH5j5B2P/KQtEDTpKSGCvnwSQeNjGX71dRESVqJB7wpITi6M8UPPM4rWtNNg== X-Google-Smtp-Source: AGHT+IHRAcwxAZ4FTkvTejZwss6BeArnF/doyzuB2gyOzUR1X/H4L4lJnDBV4DV+DyQYzOMsjOJf X-Received: by 2002:a17:902:d489:b0:1ec:2e23:4c92 with SMTP id c9-20020a170902d48900b001ec2e234c92mr11183564plg.0.1714914728584; Sun, 05 May 2024 06:12:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714914728; cv=pass; d=google.com; s=arc-20160816; b=l3lG7LWfqfjxb+dTxiumuqdI5VWo3JPb8SFi5C5QYUz5Ka3vTy5OhkPU0ylTMPrZwE oPScqflNd6zpWVirwu72FU2ajJIGjlCMLwix5QqRFkvJs88PZN07J0lPluWUjqGWPmbB hD2DJoagh+EN1mI8KUE7LtOQEvRcXc2SuDqdMvRPw4qySvBbUg4zTABW3M8d2a4uDJ3l bCX1T6Cstpp95mLCvmv/GppHcVm2FzvUScVZFf7eaCH0Om8/zo0ZHoyNbuS4wcG5BtJ0 AoqtdTwf/F9lqhNWkDoFVLYABkeJEIlgTfNuLXzByDf4ogpHol4UBBVfPUYAQwr85g5s gFbw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=mbBxe1SQqgCtww0fRWp5Xv0L8UYRKIb3aOhpR86RxY4=; fh=v1nah8rlTAJytTbJ4otZaeMeCWgSqNtef+84BkVuVnQ=; b=X2/BaMByls0BSwVFasBLUgbBfOLCc3mvsJONGtIIVOrG7zXJIrnfWuLtAr9ESI1cyB vYovRrovQ1cnPkp7qvthBiA5QhIeOpPCP8BEbBLPOiAavry9aso0aiYHCRB1RG0aCCP3 /+CEGTXqRhN2v5UnieKPWpGGKOGfwk2rWalQYccUznRho7jXG0xFzetPU1TRyzsPGvcc u47uVfJ380TAFddXOemVzGInyMJ1OTiD6Ibo08gxyAY1cOaRi++2InILQsvMisZz1dS+ EXnq3kbdZdJPQFzNsX8a1+6bmlfIOEOLiKMx5bDqNRslu/GHrHLjM4OhJHcudHWLUPsf PacQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ayQbzRJL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-168976-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168976-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ju1-20020a170903428100b001e5c6404356si6214132plb.139.2024.05.05.06.12.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 May 2024 06:12:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-168976-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ayQbzRJL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-168976-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168976-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3B2E4281CCC for ; Sun, 5 May 2024 13:12:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 589411D545; Sun, 5 May 2024 13:12:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ayQbzRJL" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CACE1BC31; Sun, 5 May 2024 13:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714914720; cv=none; b=pV8QOWMkahGi0edF8xjaPvNvVKfUzFRlwmSpyjm99OfwGbAAUAMay9cjF3o1wqPAFY+5PT+x6X6Ux9CNE192jhEfKNZiA5t6ce9Pno0itC2NzASnZV5+fo2XRqaG54KeqJLHlnjHnQ9ntn/YMpj6LhPW4VbtkCSv7HOmDfpzyno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714914720; c=relaxed/simple; bh=339kHs5cw0S4Jw9bzqy0KdYyelCRe83EhIFkTfjj06E=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=HBnZImAvBYsYgGltVq2Dyn8JwkgXkO2zNiUGiGzIzkjgfx0e2ZRLajVk5h1FEOBMWYoQ6a7y2fvyDH8GRfdIDPnvIwdb3yJG0J9b1zwOt7cyAIdaD1xtC4hke0zvLFHAKSk2Rm6hL9yUJK01qLx7+fHyVOHkSXVTxMASSeUCZEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ayQbzRJL; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F26EC113CC; Sun, 5 May 2024 13:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714914720; bh=339kHs5cw0S4Jw9bzqy0KdYyelCRe83EhIFkTfjj06E=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=ayQbzRJLppFZ6X7ysAjTs7NeK89fOKRh5ECkUUlpuvdnoY2EQPTjBJ144AuUV/Uzu 6ddwaFLeH7Vtg6sph5bg67lFLY4c8Fqq+JZof4OQEm71vrqObHNXFdqtjQCG8KXMWw Rj0LjKvjw8NPmdZ0vwJYMRZ1pWbnhJLlj5UJr2QNYYmEz0Wmy+nzLqrJNRsCU2dEbI npJthztemfRODI5iowYvgLftTGY9oGGsxiIYrtIltmLmd5rjO8QswojZ4t9fbpZJIh kCNwNh/qWL8g1MDyGbQ5Ih8IjdMGohDodHfdspE7/28Oa7sQ5KIRTW7tnB/9gmp7HX ge43qEkeqhtSQ== From: Leon Romanovsky To: Dennis Dalessandro , Jason Gunthorpe , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Ilpo_J=C3=A4rvinen?= Cc: Lukas Wunner , Dean Luick In-Reply-To: <20240503133640.15899-1-ilpo.jarvinen@linux.intel.com> References: <20240503133640.15899-1-ilpo.jarvinen@linux.intel.com> Subject: Re: [PATCH v2 1/1] RDMA/hfi1: Use RMW accessors for changing LNKCTL2 Message-Id: <171491471637.194239.11215634092351988199.b4-ty@kernel.org> Date: Sun, 05 May 2024 16:11:56 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.14-dev On Fri, 03 May 2024 16:36:40 +0300, Ilpo Järvinen wrote: > Convert open coded RMW accesses for LNKCTL2 to use > pcie_capability_clear_and_set_word() which makes its easier to > understand what the code tries to do. > > In addition, this futureproofs the code. LNKCTL2 is not really owned by > any driver because it is a collection of control bits that PCI core > might need to touch. RMW accessors already have support for proper > locking for a selected set of registers to avoid losing concurrent > updates (LNKCTL2 is not yet among the registers that need protection > but likely will be in the future). > > [...] Applied, thanks! [1/1] RDMA/hfi1: Use RMW accessors for changing LNKCTL2 https://git.kernel.org/rdma/rdma/c/8f3b7103b41314 Best regards, -- Leon Romanovsky