Received-SPF: pass (google.com: domain of linux-kernel+bounces-168979-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: David Laight <David.Laight@ACULAB.COM>
To: 'Justin Stitt' <justinstitt@google.com>, Edward Liaw <edliaw@google.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Shuah Khan
	<shuah@kernel.org>, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers
	<ndesaulniers@google.com>, Bill Wendling <morbo@google.com>, "H. Peter Anvin"
	<hpa@linux.intel.com>, Andy Lutomirski <luto@mit.edu>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
	"kernel-team@android.com" <kernel-team@android.com>, "llvm@lists.linux.dev"
	<llvm@lists.linux.dev>
Subject: RE: [PATCH v3] selftests/vDSO: Explicit unsigned char conversion for
 elf_hash
Thread-Topic: [PATCH v3] selftests/vDSO: Explicit unsigned char conversion for
 elf_hash
Thread-Index: AQHanAFdbmzmhwAPx0KMYxInfI6/rrGIpXPg
Date: Sun, 5 May 2024 13:20:35 +0000
Message-ID: <b55272cb757743548c789aa8c0efa448@AcuMS.aculab.com>
References: <20240501180622.1676340-1-edliaw@google.com>
 <osgrbhnqlyh5yw4y4x6wjggx56dogsgje5yy3mkpu75ubs3zwg@5tliydzky37k>
In-Reply-To: <osgrbhnqlyh5yw4y4x6wjggx56dogsgje5yy3mkpu75ubs3zwg@5tliydzky37k>
Accept-Language: en-GB, en-US
Precedence: bulk
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

From: Justin Stitt
> Sent: 01 May 2024 20:55
..
> > static unsigned long elf_hash(const unsigned char *name)
..
> Is it possible to just change the types of the parameters of vdso_sym()
> or does that trigger even more warnings on the callsites of vdso_sym()?

Isn't the problem the definition of elf_hash()?
A '\0' terminated string really ought to be 'char *' not 'unsigned char *'.

=09David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1=
PT, UK
Registration No: 1397386 (Wales)