Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp906332lqh; Sun, 5 May 2024 07:10:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW+MLPExJvdINjYd9CPTLkTn6y5r7VgMIs6EUkNrvpd6y6hmn2mSjTDg9ucKXCQTtBMqSgeuO8hJBGzMMO0HNsfKjmQvcxYmx1XdYN3qg== X-Google-Smtp-Source: AGHT+IGftXE96iJnEt7bVFLoUYfK5MWYjeiCj48TmfpmvOITWV8Aam1nyQtrRedXYy6ZXMJE0Gp+ X-Received: by 2002:a17:906:c114:b0:a59:b8e2:a0c5 with SMTP id do20-20020a170906c11400b00a59b8e2a0c5mr1755165ejc.51.1714918250732; Sun, 05 May 2024 07:10:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714918250; cv=pass; d=google.com; s=arc-20160816; b=Cr39m4Q+0+OOEwRXbntGmO2qNymz69rlIi2xxjbb+vanitsuLtmX3hHvs73uupMeLj KF/F50PTCGxKQgHgPmd/9rAc0EYYym2yNPmWuIiq1DnyNKWR//w9J3UT1KotHp4jHYpr vmRwDlw3XnaUQxYHLlG58z7FQ9VQCHdr62jGPwx7oLkGs33ahahZtNds/C8c1+NhtLUX ZSiYb8sVGjbJsvMlAiTMpuklAUYtBv7NJnrNd/n7zphRazNWVLjf6OShkujGYGulNkRv c/rjTgwYMCmX+2lacYjAsaaSHs2nAMFCgsa0j/tjziznJenhCwx8rli8RaeghGgfgyU2 l/2w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IjCvIj7sINM1kIT8YsfIinvJN/8pbuE8re49aG6rSKw=; fh=P0jpLMYIK6O82LxNBVNcDcCW+YE0cJEp+LJUu/Qui5A=; b=zSr6yhuH4rsbjuBtbANBj4tp4MkKbZuJs7ch7GifXJCzA2qRjzJ9O8w8my4QkPkKvQ dgYLPPo1u33qx3ivAl1qsa+mLm8PVlm5oXijWMiz5sKHU44LbkEW4+G1buiJzt+eZnoD KgEr7nsSoOKxn5WNFEEbGPhWUD6RxxhsSUeme5JOfWtR6nbWDTg7VK4Wc9G8uUZQts/j i0fydbhb6RbuRatAXhvKT8kfN74UD8CrMCIjeMLbRJlGLz/Wr73J06MOCbcOVzMcTZLW eyRkgxIFmJ5IDP/Wk4uXdRMbmn3KplRBbqXw+s67ptpK1SqIXR9K3u2K6HhJ31vYuDwj LXQQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m+1eoV8j; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-168991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168991-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id sa8-20020a1709076d0800b00a59b495372bsi1397785ejc.948.2024.05.05.07.10.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 May 2024 07:10:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-168991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m+1eoV8j; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-168991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-168991-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 339A71F2185C for ; Sun, 5 May 2024 14:10:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 17B1E2261F; Sun, 5 May 2024 14:10:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m+1eoV8j" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A93CB662; Sun, 5 May 2024 14:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714918237; cv=none; b=Sf+6mF6jpUUR7MB5GSYE+XBrI8p237MfqUuLdVwgZ8DW8Z/pQBNfAtd3ARrL4riFmhbOL7aQY/ipgNeT3+BfCoXBY+5FfgmAphqX6uz9uplU4XhFeMQNBqPf7UOugNeu3z11QNwQ1MF8T5EKZa/9HRlKDxRVzIjz/iZ/B0CSfqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714918237; c=relaxed/simple; bh=F+oMsjUMZqKcGqEpkDqhD9UQMjmC1BnqSHXs9vkjGrA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kfcAWMcROxK3ECTIFXocFtoobHBk+ILomgLAaSNHglqJ/w7+3+yZ1LbhgkaxCgPofPhDHMnbBydy/gxGzOFLAqObTyNCHZzG6kwubNHa9B9oNFzKVSI2n7BMzK+S9M7pJJiotgn5tuptR9i+oWevBUL4jFSsrO1Zqq2Fe7+NfWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m+1eoV8j; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2940FC113CC; Sun, 5 May 2024 14:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714918236; bh=F+oMsjUMZqKcGqEpkDqhD9UQMjmC1BnqSHXs9vkjGrA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m+1eoV8j8rE/DJc61bLn1PGqSLLdrgY6exTclaBYnX6+B5qUczVE6bDDIh6Z42um2 Q5unLSCs9sytW/XAKeog+WdpjmZ8f7YNf64dJOshhXOeChFuVzH0B51zxS1u7ecYpY 9Q0hw2Z1RRzN6tYanOCKmmAw0fPLdqv1NQVWjPcwoD5IKKpkCVFiEj5GywJiYZrp+S +eiN3DLxjfTzi5Om6hiPs2H1s5t1XF3JmTEJVUmluIF2dbGR4JHh35KNYk7f5/JBq/ bSeWOBxmxn2+OJa+Ps3KBBZYwnZeWhqUxvDh3vn+wJIsVFP+Cp4xGukRpvn4R627nB hp0N3N/VsTXzQ== Date: Sun, 5 May 2024 17:10:32 +0300 From: Leon Romanovsky To: Breno Leitao Cc: Dennis Dalessandro , Jason Gunthorpe , netdev@vger.kernel.org, "open list:HFI1 DRIVER" , open list Subject: Re: [PATCH net-next 1/2] IB/hfi1: Do not use custom stat allocator Message-ID: <20240505141032.GE68202@unreal> References: <20240503111333.552360-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503111333.552360-1-leitao@debian.org> On Fri, May 03, 2024 at 04:13:31AM -0700, Breno Leitao wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of in this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Remove the allocation in the hfi1 driver and leverage the network > core allocation instead. > > Signed-off-by: Breno Leitao > --- > drivers/infiniband/hw/hfi1/ipoib_main.c | 19 +++---------------- > 1 file changed, 3 insertions(+), 16 deletions(-) Please use rdma-next in the PATCH subject line, when sending patches for RDMA. Thanks