Received-SPF: pass (google.com: domain of linux-kernel+bounces-169021-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sun, 5 May 2024 23:52:51 +0900
From: Mark Brown <broonie@kernel.org>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Shuah Khan <shuah@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Ivan Orlov <ivan.orlov0322@gmail.com>, linux-sound@vger.kernel.org,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev
Subject: Re: [PATCH] selftests/alsa: fix a build warning: return a value in
 all cases
Message-ID: <ZjedQ6ZH4p_4QI54@finisterre.sirena.org.uk>
References: <20240504021330.33429-1-jhubbard@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kc7/Yw5jYfcwspOn"
Content-Disposition: inline
In-Reply-To: <20240504021330.33429-1-jhubbard@nvidia.com>


--kc7/Yw5jYfcwspOn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 03, 2024 at 07:13:30PM -0700, John Hubbard wrote:
> dump_config_tree() is declared to return an int, but the compiler cannot
> prove that it always returns any value at all. This leads to a clang
> warning, when building via:
>=20
>     make LLVM=3D1 -C tools/testing/selftests
>=20
> Fix this by unconditionally returning the "err" variable if the code
> reaches the end of the function.

Reviewed-by: Mark Brown <broonie@kernel.org>

--kc7/Yw5jYfcwspOn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmY3nUIACgkQJNaLcl1U
h9A0DQf/Sm4T5cLBFo1crAijqgYhia2UFGRUbgX25oBNtteEGtseMCPCna58C8ZE
qsKSLsvmhh69Af7mOs4LAp7b8tlp1tOvTEgbNPIZcHCM9mHJ7c5IHIiZ0gfr50hw
eImQhq5m7nsbQzUoCcpV/e/1W6dL7F8ifAC0zfoa5d4pCpB/G9Vcyvi/efmgENCL
NY6zclPKKNl34shTqOYbxid8Dnj+bad7197D8uAvL933qXxAOeBRwcjeFkSOEqsQ
3xhBdnD1mBk5qfLgz3LNinaLVWQWr3jucVMhYyYlYjODJy631dDT1zv0obK7n3+a
fDF8SNhye8zKNxN6QNnL9BK0VkxQgg==
=CkGU
-----END PGP SIGNATURE-----

--kc7/Yw5jYfcwspOn--