Received-SPF: pass (google.com: domain of linux-kernel+bounces-169086-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sun, 05 May 2024 19:54:36 +0200
Message-Id: <D11WJK47MBWS.3795S2OL21M7R@holesch.de>
Cc: "Valentina Manea" <valentina.manea.m@gmail.com>, "Shuah Khan"
 <shuah@kernel.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
 "Shuah Khan" <skhan@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] usbip: Don't submit special requests twice
From: "Simon Holesch" <simon@holesch.de>
To: "Hongren Zheng" <i@zenithal.me>
References: <20231217194624.102385-1-simon@holesch.de>
 <ZjemYB6CpAx4Kx5f@Sun>
In-Reply-To: <ZjemYB6CpAx4Kx5f@Sun>
UI-OutboundReport: notjunk:1;M01:P0:yk/FWOXkRlA=;iLTnnr1ujQyNqSdircR1HMBB8wu
 v30hocqDdKtgCXQXfZJRb1O3hUoqzL0TnQivT6OxiKpQm+C72DIJFq+q6TvnKWm1Hxb87ZrYu
 P2OTYRKICVMjmvsiMvboFGYml4m7A1V8wXwqC7H3VbeGbCjcvOo6mxulaGEpwiBgGAO9zcW3q
 ZyCizM/68yzzbfj99yQpzuLoihXJ+liD5EOE3XwDgORAtid3MmSzAr36Ro7JTHOl0sDXxFHiT
 gJerevZJfJN787qT/KS2MynBaSqtKfwLipEHdrtzlYblzEfaL8Yn09ZUBg3GEx1WmZkC5b77i
 bovbV07k8BZ1mX7PcZO8vnDfmvdijKZlxThHLb4z3vyrzeH/Nzb1aMfEYjsmcbxiV8ZavCLKD
 1jlG83o4tv+7tkdS/HrkOS7raV0YtEvQ5KyoKz0VNQ1sMV/scEgN1U5Nv0B2RgY8MyKG/IWLm
 sFQNfw2OygRvyCCPckOp0AmwOpmM7usbBC5r9zNpq2udV/cjnZyX+QwYH5OOTHOc46csfueH9
 7sv5fXDDSXuuu/g5cWvcu/+MaHIyvCqVwDvnnb9m8lkdc+Tg12RRF/t110/9UUNmVF2hI9a+V
 nfVM7ghEeeL07g5xxpsN4zUYipkpDDMXdp07vwNEUDUdvbR4TnA7LO8P183nucsa0KBIXnQWN
 Y9gN7nHjBeBASl+s5i4xWT9N3F753XLN6YUOB69huziFPiDsiMFGWgKDdGbEDBe2KDSfA6V6u
 CeVXSQgmY1GYtuWNDKUeSKcrMkVaOkK/MevMyhF2pmy/dSwMDUbenI=

On Sun May 5, 2024 at 5:31 PM CEST, Hongren Zheng wrote:
> On Sun, Dec 17, 2023 at 08:30:40PM +0100, Simon Holesch wrote:
> > Skip submitting URBs, when identical requests were already sent in
> > tweak_special_requests(). Instead call the completion handler directly
> > to return the result of the URB.
>
> Reproduced the behavior and this patch fixed the bahavior

Thank you for testing.

> > @@ -468,6 +477,7 @@ static void stub_recv_cmd_submit(struct stub_device=
 *sdev,
> >  	int support_sg =3D 1;
> >  	int np =3D 0;
> >  	int ret, i;
> > +	int is_tweaked;
> > =20
> >  	if (pipe =3D=3D -1)
> >  		return;
> > @@ -580,8 +590,7 @@ static void stub_recv_cmd_submit(struct stub_device=
 *sdev,
> >  		priv->urbs[i]->pipe =3D pipe;
> >  		priv->urbs[i]->complete =3D stub_complete;
> > =20
> > -		/* no need to submit an intercepted request, but harmless? */
> > -		tweak_special_requests(priv->urbs[i]);
> > +		is_tweaked =3D tweak_special_requests(priv->urbs[i]);
>
> One question though, if there are mutiple urbs and one of them is
> SET CONFIGURATION, then all of them would not be submitted,
> as is_tweaked is a *global* flag instead of a per-urb flag.
>
> Now it is assumed that when the urb is SET CONFIGURATION then
> num_urbs is 1. I assume it just happens to be the case and I do
> not know if it holds for all scenario.

To be honest, I didn't fully understand the num_urbs > 1 case. I assumed
this is for drivers not supporting SG and a long URB is just broken up
into multiple ones.