Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp1007396lqh; Sun, 5 May 2024 11:29:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUnKZuiRgBxrUlIwIXc8J/6cSwhWQPmza9773E/QoiEx7q1Onfn8thqEQD5Q9p4frcsSwxWZwLWXOP2r/y4W2yTelbOljbSL8xrt2fPXg== X-Google-Smtp-Source: AGHT+IFq6wxSbFGDLOBxf3b7SSjzuxdRIt91tborp083WN3522BLfO8mKc8j8iXkRKc+6+lyZKYR X-Received: by 2002:a17:90a:ca8c:b0:2b2:812e:1d8c with SMTP id y12-20020a17090aca8c00b002b2812e1d8cmr6510205pjt.2.1714933770576; Sun, 05 May 2024 11:29:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714933770; cv=pass; d=google.com; s=arc-20160816; b=v2VRqIGt+zTWfiKuyPrCv/0SFANMfbcPywfmA8GxYznztN8IxffxnwhIPDvKYnZxQs Ri+VaA4e09PU9Q+Qvs/mDwprJVxxnJJ2yka6FCPOdtjsfkE1rAtt4BBdynS1CNHWM7pk l4yJVq1f0KDwMoYEZkIQZCcf12usvspDexoaGGUY7QSwkMd2i1AmroOnaO/+iAMObA7N qPBGMnqF43DFXSCwHe/qtH+/7pS+tTsjqXccaDF59gBoVo8RgxFYPbpO47/VBqzWQ19k 9sBSvPHNtXCpsosNZvBKmV4rBqSsfmsPYalj4N6+pWfQ0XL6pVdgMNGliUZYg5N+ceI1 y0lQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2c3rsJd5+C9gOUqICAJkWhmVm4gYvJcQn1yN6aN3iuo=; fh=TK/qA9eA+G9PQf5Hvgxuqmt3rzxw7wvsCy2l7ejXeCI=; b=s9lhZevEyL7ecRjsFY6Pz7BsYmDHOE6vtOhJLKAJGeDR7w4XGsoLaFXIqMZi5JIIYn SBi4Si9NkoL/WFkRlBihOBKOfivfD1Jc8wd+bMvKApJS+jHRYkDTbzdFi4gr/GAuCbxE mpNwiVjFArJz+DuuAdFgaGN5awcvIVoAsw4egJVwAbb/60O9UAKmUNKBChbL0zdeHvP8 +AFNoxdBbdZ8Lj8espFl6h1RUq6R2DxON51+0hu017fF6HoVZp/h3IsGJCyrp8XVjZWr I44qWcfMKWI2ujobatJBtqkPUTwxdgkMraUYpKXDN4kmDzIaRDnXsvvY20WwLvc2VmO+ HqSQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=R0l1QcHP; arc=pass (i=1 spf=pass spfdomain=alien8.de dkim=pass dkdomain=alien8.de dmarc=pass fromdomain=alien8.de); spf=pass (google.com: domain of linux-kernel+bounces-169096-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-169096-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id h11-20020a17090a130b00b002b2740cb64asi9597417pja.148.2024.05.05.11.29.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 May 2024 11:29:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-169096-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=R0l1QcHP; arc=pass (i=1 spf=pass spfdomain=alien8.de dkim=pass dkdomain=alien8.de dmarc=pass fromdomain=alien8.de); spf=pass (google.com: domain of linux-kernel+bounces-169096-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-169096-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5B393B20ECA for ; Sun, 5 May 2024 18:29:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 68D406CDCA; Sun, 5 May 2024 18:29:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="R0l1QcHP" Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 374CE1DFED; Sun, 5 May 2024 18:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714933755; cv=none; b=T23qKoHyGyR18YONUZTwFfH7BsKiJDPJSY7Nbye9od35Q127VJ427Kmwk+ObtAaDGUBPqTYam9kjpapeJmNITLO2O4HXzRUCUempPxi5vtR+KcjOzAUDLSGKTX1atmLwYuWRylL5nJYDULM8iCtht9qQNVN5T2SrBQgFoaIVDgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714933755; c=relaxed/simple; bh=kmr0tE/cFUeLPazltcKBsWdavSb2gYZMg29IrTBr15A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=REoQQIDXYz1gcnJh5MvEkyccEx5eA8tRR40U/uOU8xalNeaByMZz07xgyX2PYJ2danmnhUwZyk5bIdCkWXnMb0dULGIn+sWan20ZXj4MNhbeYVHxg/F7yDMTHWF0aN+DIWLuGo9NK9FiyJ1ULUGZvNH5gmRdBg9vbhUiREQ6By0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=R0l1QcHP; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 5AC9A40E024C; Sun, 5 May 2024 18:29:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id T-3NwLK1gWyt; Sun, 5 May 2024 18:29:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1714933740; bh=2c3rsJd5+C9gOUqICAJkWhmVm4gYvJcQn1yN6aN3iuo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R0l1QcHPcURtc+luuPBnrsq8jO1czQN5/BzhAxRPkLw36GkYIe8a519flkhX/PJP4 JSG8xL7YZPfCL7hklEE8y2UdGecuylXI9rUVaRRK6jPPVjlWTkw+v2O7jVoGI1VeGX F3D9o7yELJP04bHX9q1ECpQwLDHdpw65XghukIJNfDYuJvO56DoExK2f7VDsFKUdJA hcfcwDAUmwp78SfTZrYtsJO9N676Vm+UVnEzZqgFH3DGGSDK6PGRARyFZz9CJKEMUk OnT+Qf3xjiQns4jKyL3KAvzB8GftOm3KGEc3yiNB9W07whKTmRClNOR4XnTTTO+OG1 50ekC/avKv6+M3b78bfc6Id6vD2Iq2SlEln54H1Sg4BIOamC2yidcIDjsb32kLbJXy hqiF9ca5RU5Smg/3ugEj1STdtoYwj4lgUmvsxVVNhBK3PJbCOutXCyaKOhm4yy5Xoe 1gPzWKeR+bJXtJyjbxQ2SwPYTfdv0rFnkDpaREAnt8J2R1NjvfNssf+CzPuE4ggfQ5 OgwNDcIeMCk9KmNJD0xJjKBtX5svvHPY/Ci9RHqcFnKIryPkEacccnDRgsCiWz+els 5uLzMLm6EGGDj8yDUA1h6bzlztrgLnUcMNCqIbe+TT7J0O9WPWBRhE3xzdqTYES9WK 9l3IMFoVPT9iJN58SgHOlHWI= Received: from zn.tnic (pd953020b.dip0.t-ipconnect.de [217.83.2.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6E30340E0187; Sun, 5 May 2024 18:28:34 +0000 (UTC) Date: Sun, 5 May 2024 20:28:29 +0200 From: Borislav Petkov To: Alexey Makhalov Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, hpa@zytor.com, dave.hansen@linux.intel.com, mingo@redhat.com, tglx@linutronix.de, x86@kernel.org, netdev@vger.kernel.org, richardcochran@gmail.com, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, zackr@vmware.com, linux-graphics-maintainer@vmware.com, pv-drivers@vmware.com, timothym@vmware.com, akaher@vmware.com, dri-devel@lists.freedesktop.org, daniel@ffwll.ch, airlied@gmail.com, tzimmermann@suse.de, mripard@kernel.org, maarten.lankhorst@linux.intel.com, horms@kernel.org, kirill.shutemov@linux.intel.com, Nadav Amit Subject: Re: [PATCH v9 2/8] x86/vmware: Move common macros to vmware.h Message-ID: <20240505182829.GBZjfPzeEijTsBUth5@fat_crate.local> References: <20240424231407.14098-1-alexey.makhalov@broadcom.com> <20240424231407.14098-2-alexey.makhalov@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240424231407.14098-2-alexey.makhalov@broadcom.com> On Wed, Apr 24, 2024 at 04:14:07PM -0700, Alexey Makhalov wrote: > +#define VMWARE_CMD_GETVERSION 10 > +#define VMWARE_CMD_GETHZ 45 > +#define VMWARE_CMD_GETVCPU_INFO 68 > +#define VMWARE_CMD_STEALCLOCK 91 Ok, what part in "* first patch: sole code movement, no changes whatsoever" wasn't clear? You're adding those macros above to a patch which claims that it does code movement only. Don't do that. Let me try again: * first patch: *ONLY* code movement. No new code, no new defines, no new functions, no nada! Only move code and do fixups so that it still builds like the export you're doing. * follow-on patches: other changes. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette