Received-SPF: pass (google.com: domain of linux-kernel+bounces-169100-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sun, 05 May 2024 20:52:06 +0200
Message-Id: <D11XRKUAK8EM.20N91SDPCH584@matfyz.cz>
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
        "Krzysztof Kozlowski" <krzk+dt@kernel.org>,
        "Conor Dooley"
 <conor+dt@kernel.org>,
        "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        "Liam
 Girdwood" <lgirdwood@gmail.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
        =?utf-8?q?Duje_Mihanovi=C4=87?= <duje.mihanovic@skole.hr>,
        <~postmarketos/upstreaming@lists.sr.ht>, <phone-devel@vger.kernel.org>
Subject: Re: [PATCH v6 3/5] regulator: add regulators driver for Marvell
 88PM886 PMIC
To: "Mark Brown" <broonie@kernel.org>
From: "Karel Balej" <balejk@matfyz.cz>
References: <20240504194632.2456-1-balejk@matfyz.cz>
 <20240504194632.2456-4-balejk@matfyz.cz>
 <ZjeidfoIbjvejphU@finisterre.sirena.org.uk>
In-Reply-To: <ZjeidfoIbjvejphU@finisterre.sirena.org.uk>

Mark Brown, 2024-05-06T00:15:01+09:00:
> On Sat, May 04, 2024 at 09:37:06PM +0200, Karel Balej wrote:
>
> > +static const struct regulator_ops pm886_ldo_ops =3D {
> > +	.list_voltage =3D regulator_list_voltage_table,
> > +	.map_voltage =3D regulator_map_voltage_iterate,
> > +	.set_voltage_sel =3D regulator_set_voltage_sel_regmap,
> > +	.get_voltage_sel =3D regulator_get_voltage_sel_regmap,
> > +	.enable =3D regulator_enable_regmap,
> > +	.disable =3D regulator_disable_regmap,
> > +	.is_enabled =3D regulator_is_enabled_regmap,
> > +	.get_current_limit =3D pm886_regulator_get_ilim,
>
> Do these regulators actually enforce this limit or is this just a spec
> limit beyond which regulation may fail?  If it's just a spec limit I'd
> not expect this operation to be provided, it's more for a hard limit
> where the regulator will detect and act on issues.  I don't see an error
> interrupt or anything and this would be an unusual feature for a LDO.

I'm afraid I don't have the answer -- my only reference is the vendor
version of the driver and I don't see anything there based on which I
would be able to tell.

But based on what you write, my guess would be that it's just a spec limit.

Should I then drop this op and the max_uA values from all the
regulators?

Thank you,
K. B.