Received-SPF: pass (google.com: domain of linux-kernel+bounces-169104-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240430080019.4242-1-konishi.ryusuke@gmail.com>
 <20240430080019.4242-2-konishi.ryusuke@gmail.com> <650ed9f6-fa50-4a3b-939d-633f9e389137@acm.org>
 <CAKFNMomCzNMU0tjLkEchr=GQwSVW1zr1GAq7vUToeOvX-M3eVg@mail.gmail.com>
 <CAKFNMo=rkHF6urydfDbcvTbGzUEHmsTudVMm517pTE32vzqiwA@mail.gmail.com> <32e6621b-cbd9-42be-8626-49c12c25f139@acm.org>
In-Reply-To: <32e6621b-cbd9-42be-8626-49c12c25f139@acm.org>
From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Date: Mon, 6 May 2024 04:04:58 +0900
Message-ID: <CAKFNMokSLHrB8jyGuNH-HBqcrAmJ5-SFwu-sTgt30X2j+=KykA@mail.gmail.com>
Subject: Re: [PATCH -mm 1/2] nilfs2: use integer type instead of enum req_op
 for event tracing header
To: Bart Van Assche <bvanassche@acm.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-nilfs@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, May 5, 2024 at 9:47=E2=80=AFPM Bart Van Assche wrote:
>
> On 5/2/24 12:01 PM, Ryusuke Konishi wrote:
> > If you haven't given up yet on solving the underlying problem, I would
> > like to withdraw this patch.
>
> Has this untested change been considered?
>
> diff --git a/include/trace/events/nilfs2.h b/include/trace/events/nilfs2.=
h
> index 8efc6236f57c..67fd2e002ca7 100644
> --- a/include/trace/events/nilfs2.h
> +++ b/include/trace/events/nilfs2.h
> @@ -214,7 +214,7 @@ TRACE_EVENT(nilfs2_mdt_submit_block,
>                       __entry->inode,
>                       __entry->ino,
>                       __entry->blkoff,
> -                     __entry->mode)
> +                     (__force u32)__entry->mode)
>   );
>
>   #endif /* _TRACE_NILFS2_H */

No, I didn't think of that.  There was no warning in TP_printk()
declaration of the nilfs2_mdt_submit_block trace point.

If you suggested this as an alternative idea, unfortunately the
following warnings are still output:

  CC [M]  fs/nilfs2/segment.o
  CHECK   fs/nilfs2/segment.c
fs/nilfs2/segment.c: note: in included file (through
include/trace/trace_events.h, include/trace/define_trace.h,
include/trace/events/nilfs2.h):
/include/trace/events/nilfs2.h:191:1: warning: cast to restricted blk_opf_=
t
/include/trace/events/nilfs2.h:191:1: warning: restricted blk_opf_t
degrades to integer
/include/trace/events/nilfs2.h:191:1: warning: restricted blk_opf_t
degrades to integer

I also tried typecasting on the declaration header side of event
tracing, but so far, the sparse warnings don't go away except for the
patch I first proposed.

But, better suggestions or solutions to the underlying problem are welcome.
(Again, should we put the patch on hold?)

Regards,
Ryusuke Konishi