Received-SPF: pass (google.com: domain of linux-kernel+bounces-169214-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Liao, Bard" <bard.liao@intel.com>
To: Vinod Koul <vkoul@kernel.org>, Bard Liao <yung-chuan.liao@linux.intel.com>
CC: "linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"pierre-louis.bossart@linux.intel.com" <pierre-louis.bossart@linux.intel.com>
Subject: RE: [PATCH] soundwire: fix usages of device_get_named_child_node()
Thread-Topic: [PATCH] soundwire: fix usages of device_get_named_child_node()
Thread-Index: AQHamc8pPPDiMFXFXkqJ+A8o6mDxIbGHEUwAgAJWAYA=
Date: Mon, 6 May 2024 00:48:24 +0000
Message-ID: <CH3PR11MB8436BE8232EAB36C35361A00FF1C2@CH3PR11MB8436.namprd11.prod.outlook.com>
References: <20240429004935.2400191-1-yung-chuan.liao@linux.intel.com>
 <ZjYwdHKKNrQDxpKd@matsya>
In-Reply-To: <ZjYwdHKKNrQDxpKd@matsya>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PI+pr/v3sfIdn/i4c9u5N+FQbWG9tZpHD6crHwMX9yn/iftF1wQOErI+ujsP?=
 =?us-ascii?Q?9LNuL783Wnw8dpiN03p8qSIwgtvxhSzY8tv0Yvip47Jp8rJ+gLVMKPd2+tN9?=
 =?us-ascii?Q?TOIAjsR8uBNwVsJx7FRfIPosslZ3kEkNbP7NRQa4brKPuR03oObkNu0UN25q?=
 =?us-ascii?Q?l8LCM+qx2kwfK/W/fVzZdCTTWAp5gCRR9hZoK99ZxqzJQmZtnwdSggmHz0GS?=
 =?us-ascii?Q?A7+tPk4+mN5BX1IntJCswxziyaI0MVzsoLu/ME+fu9jGcPXChlDTUMgHZ76R?=
 =?us-ascii?Q?xXYU1xLHHBTcMBMORyqhxkMRfp2UIrGHpsnHTw46tjMpTvHZRux+1FcYGgeY?=
 =?us-ascii?Q?BO3DQweHR0H34am4egCDJ8W8lqtvl8slocH3YQ1otKTYm53g8pohW7y3MreY?=
 =?us-ascii?Q?h7RtWyMhJq7EgWiclzEsX6n/W6FnNrBh8zsiQdE1e/NlnktYLfeCh5JoHSrT?=
 =?us-ascii?Q?ION9Q0CEID8mHBg6HBAZ8YUYaRXNnSH4OqICYjzhAXTWah+oy5qSaB+/ptP2?=
 =?us-ascii?Q?ihBt4HguqyZ+aSdEFrgmWxRcztTCXA7ojxlp1LLmI7ThTg7U2JLt9xr/XAyY?=
 =?us-ascii?Q?EuqiCGin20bUd6P3Tficwf9YUMuRbPwRG0gVildOr81eiRs5ZHWbqB4kYgVa?=
 =?us-ascii?Q?1bQjNsEHF5rzIzbb7kSw3PTcgwou+6Bk8fGTD0l3lmAE9BF85BCXNR/DC1T5?=
 =?us-ascii?Q?h9UgENjOWcd65mPC/6NiEdsa4BuKvr//1wiyCdJEbtftoRprDpXun0KUsY3k?=
 =?us-ascii?Q?He18irNDe1pBbHU6T1xEV5sFTvI2SsvZptuRFcTlUrLbePno/MFvH75OfcoE?=
 =?us-ascii?Q?Ly65YMcsJIu4TcNV54IxFzNafbt0IHymud5GgSsYBzrlEKwxU6NDgVt7rXos?=
 =?us-ascii?Q?NMR5l805wpnRIYQ2YJsObehDcXeduI14UixOkGCmVyYwYhXW3QpXKf69tCSQ?=
 =?us-ascii?Q?DdOfAYWLQN5hb6Txi/Aa0Lv6dliFoH9krMO6lxqvB0vRFhxWTXksQmtJWwzh?=
 =?us-ascii?Q?rSIXFiKDEfBswVRhFfhKP/ZiY+wwb3LvARnR/IPxToUWD94vTXyVAOenckuA?=
 =?us-ascii?Q?vreIXHLidxcTXRtQ4f2kvl6DvCArfv6ov1p3aBC5g/E6MTd6TyHhMgAxjHWE?=
 =?us-ascii?Q?IFUvqDauMqw86Bl7K2kkmv5BXRhtiZouBREy4HWJF0wne2R0lH3ubN3z0Mvi?=
 =?us-ascii?Q?bSbY+7eP0oZrqvXkaGCxXfpolJG9Oml5czkvZgiWu7u7fq1Zr8G9TY2OIju5?=
 =?us-ascii?Q?4L0BZUeg0/E+Vnj2ve60jXQYgYhFacuewh1qaqaPEy7BmCsbpWqviFZT17Hi?=
 =?us-ascii?Q?kQo5IlaYIdy563HdoiGHFYyU+Z8yvJlWnTRBV7qJyyjYzIABqvyEk4wEQp3B?=
 =?us-ascii?Q?APJ/v9diOCV8nIPvnN1JBrP/GTrxEAC2Lup3s3nKrOHjyDJGFCwW8OdIrvRY?=
 =?us-ascii?Q?Xs9Ci0jam8Ethlda5Lxnp/Ql437jf0yvp92/+gE2Iynv1IkXm5Omrb6/gpAo?=
 =?us-ascii?Q?sG+k2I5uMaSjeRjgL+i8pPoDNys4PbSUf9BNZg6ZljjK1G+1n93kNR1iqyr1?=
 =?us-ascii?Q?8rVfqwus6WCMab43r8A=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8436.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f60428ee-6fdf-4f34-2fbf-08dc6d663c7d
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2024 00:48:24.8188
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AM6txku4+zOLmwbNxc0XghsWPojrSL15Xk7dAOuAczlXLWQ79ucl+m+EiEjLoB0SfqiLvkfBasBYC0KvILWEDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8767
X-OriginatorOrg: intel.com


> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: Saturday, May 4, 2024 8:56 PM
> To: Bard Liao <yung-chuan.liao@linux.intel.com>
> Cc: linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; pierre-
> louis.bossart@linux.intel.com; Liao, Bard <bard.liao@intel.com>
> Subject: Re: [PATCH] soundwire: fix usages of device_get_named_child_node=
()
>=20
> On 29-04-24, 00:49, Bard Liao wrote:
> > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> >
> > The documentation for device_get_named_child_node() mentions this
> > important point:
> >
> > "
> > The caller is responsible for calling fwnode_handle_put() on the
> > returned fwnode pointer.
> > "
> >
> > Add fwnode_handle_put() to avoid leaked references.
>=20
> This fails on sdw/next for me

Sorry I didn't realize this patch depends on" SoundWire: intel_ace2x:
read DOAIS and DODS from _DSD properties."
Could you please try again now?
Sorry about that.

>=20
> --
> ~Vinod