Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp1132776lqh; Sun, 5 May 2024 18:46:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW7XJVFiywht9xm75/wrv2Fk/ovmgn5O5pqViQG4VIB9gUgSrReu/jGamG0HWbM/dwN26aLmD1TcsC3VSXF3gFI0EXRoedWA4f6+IQUAw== X-Google-Smtp-Source: AGHT+IF0JSTowMXfhKnIAC4062BTo+fttsq3Tw/8zCeg1KNeketmqnTQY43E9VIWSbwYEsfreQ6B X-Received: by 2002:a05:622a:11d4:b0:436:6369:f632 with SMTP id n20-20020a05622a11d400b004366369f632mr8756134qtk.20.1714959993865; Sun, 05 May 2024 18:46:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714959993; cv=pass; d=google.com; s=arc-20160816; b=hdFj0iW31gqPvsNy7eNDINg8RSAG3pF/TZBUVbJvuS1/XY7D++UwxnCWtLeCZXeGK7 62d2QqVBaU/bmsV/bu4AO5pMRmWsEGWZPK1v/UXkVI7CHlQ7/JmWhHaRsr3GPxACIced 9rlSfW/4zOmCHf4d2sfXChDNDJaMjx1oaT4xmyK0cXq8JwgGGVBhyInop+JWWmYl1yT1 vyYw3uMgdz/WjHZYC6tj6BkpenI7VOqVP+18uSmkrAZB28tVecQYs3J2Dxd5ty3LpAQ6 kxaS4fXYUS9yEZInVOMDse+HL2k4Naffp9neC6i01C1ewy4V9FUzRtqRh9yxXUNlVrb6 QI7w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=1/DXUBEvuqpvW9vgHBUj1lOdo7CYu69Q0rcw2cg02+k=; fh=q8j2YdkPbUrZtHmMS7ay0ZRrC5Jh/V7n7fjdAOFC1Zc=; b=VGwWe0iJnkJZvMYA2BHaSXe/XSpnzPC0XW3T5WfDKzsv+Y30jmtQO9b6XNbd2vZrzV opilh2B4009V2Bq+RCKCkaHKtTGJ7zOgRnda3RTuX3s2rj+vAO457Y8VtFDJY4r2BOQQ CoGnTnDk1Bk/9XUx9shiPzlYke3OBnciIF5gScki2uC6kgF3HvxJ76iJtl9VA4dkw+Cu pxzTqI669jfF1xc/L3p9l9ylGnEtfBHpg8u/ood51wcOWJnTM1O2quuFTkho9N6q6Utz VUMwBRTjLFshc8rgpgmBoBHYdGlmO8UnHdSA1BFOFWMMggVCEyp46D86mJYmuXpqsfU+ CtwQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=jY25Wczd; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-169238-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-169238-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id u14-20020a05622a14ce00b0043aea523a7asi8672636qtx.103.2024.05.05.18.46.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 May 2024 18:46:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-169238-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=jY25Wczd; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-169238-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-169238-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 95C891C213D1 for ; Mon, 6 May 2024 01:46:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6BAFD3CF6A; Mon, 6 May 2024 01:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jY25Wczd" Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B8F5381AA; Mon, 6 May 2024 01:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714959986; cv=none; b=mzSnMoWhPkLT2rFEGd3XFAO4qT9BdUkC7Gptj0MEhRf7VCUWMZafLUtE6JQLAegwsCm5vA0LAZXiOsdvxJ2HPjBbcfqjx+lja5ZSVajBjpFraxvCY1fP95P2KXgxsaq0qNX34jan5Z+fcv611g/t+6btd/KnJZPdSu7Z2xBPHDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714959986; c=relaxed/simple; bh=i83YdIPPx0R/zg6nAIJzCB1vAwrQ7TEYddQ6IihpENM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=K2x0V6NpDxBOnX+tkLHoWG0cQ8+1njRg1MlebHNeOMTVjOsHzktTVPuF+bqqr9ZAgNsu6ut0M0ZtthFul1vWNSQUV5KTkUCmQyUhb1rO/6T1hwTppvGUHOEZhLeAzNqu9x/a2/lex52yVvxyMnLRLk5XS3hAjZ1NM5ZbSklFCac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jY25Wczd; arc=none smtp.client-ip=209.85.160.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-23d39e4c0d9so997693fac.0; Sun, 05 May 2024 18:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714959984; x=1715564784; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1/DXUBEvuqpvW9vgHBUj1lOdo7CYu69Q0rcw2cg02+k=; b=jY25WczdF/oAYSkYHCpQku3c5Ka5ydOcD9AajdHBFzKl97RaNMFlCpIy2dDdwI38vV XSXBZpkhp/9h2iXV6qg9Doe1m1oumFaeLJoyJnu3RPp48dD2/oadqPih7HIN3wwvftf2 GqzJmDwRFIaNAipSIW2br8tfIdk32oFMX8EnN+6sjYZim5Uochb6oVDVaQgcp7bjz2H/ wT128sHsVJRf1d0AFxPHLJ+sXeyUKcq2A/8IN6lhBAOXP+2YrRRI/kCsoGMy9GqaWRfd 0rWzeaiSMEGGOEcpuxuS6VPxHm7AzvqzgSuXrlrSTQDr6ErHOsBWzuuTE5Ea8/EMGO00 NKKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714959984; x=1715564784; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1/DXUBEvuqpvW9vgHBUj1lOdo7CYu69Q0rcw2cg02+k=; b=hjkMirOGI57MI7YOD5SlJPcForR5lkagHt5x0Vcm/mzkgdT777gjOnWMTvt3H2F9zF +rlJgcE1YGxqb+K+MJx+IY2bHI4EQq9oGhunicHTvOzrqO5Do93HttoneMqbntbTDiNx 8K8uOv7IJsazDi1OhhLlzNwgMMtYyRIv8c3l3mY/2K07IOyICSTuvlTylY1c01vQHA3k S6Xa2VJ45pDfC5Mk3eW1zDSQXYskrY2O0CqoLNy1hIgVB5UqymJSa9MPf8x9Jj6uvym0 bq9UHnabLvGD8nxln9A4j54MDXHkAQ4f3be42212M16EZMzjxXUupjXJ35zHfTwx7VTT wcKw== X-Forwarded-Encrypted: i=1; AJvYcCWKgR6nYCHECiYcFfyAAcaaLrN/Kzm1lf5BFqqCNaMDGeaIqMcU7Ybd4BKP9ixiSRHRSReA4RmdFkUvtzKjuypUAxEk6COtOu6DBpCLE/lYAZ48aoppFwk0aP2NMIs/YjByhf2dgj7mhIos/u7LTbkZIkvf0z6WpwEphibeKSPm8nFv X-Gm-Message-State: AOJu0YwTJtDzGobasQwLY2pKUChsIL9sGaEXEjK5IM/KmXkQYywux5KR MX7/b7O7AaKrU1WeG5iQSSZGGoNlSLjIoBbeDBndF939RyNSlqkR X-Received: by 2002:a05:6870:2486:b0:23d:4997:7692 with SMTP id s6-20020a056870248600b0023d49977692mr11375763oaq.1.1714959984129; Sun, 05 May 2024 18:46:24 -0700 (PDT) Received: from localhost.localdomain ([2407:7000:8942:5500:aaa1:59ff:fe57:eb97]) by smtp.gmail.com with ESMTPSA id fj30-20020a056a003a1e00b006eac4297ed3sm6608511pfb.20.2024.05.05.18.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 May 2024 18:46:23 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: akpm@linux-foundation.org, joe@perches.com, linux-doc@vger.kernel.org Cc: apw@canonical.com, broonie@kernel.org, chenhuacai@loongson.cn, chris@zankel.net, corbet@lwn.net, dwaipayanray1@gmail.com, herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, linux@roeck-us.net, lukas.bulwahn@gmail.com, mac.xxn@outlook.com, sfr@canb.auug.org.au, v-songbaohua@oppo.com, workflows@vger.kernel.org Subject: [PATCH RESEND v6 0/2] codingstyle: avoid unused parameters for a function-like macro Date: Mon, 6 May 2024 13:46:04 +1200 Message-Id: <20240506014606.8638-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Barry Song -v6: * collect ack of Joe, thanks! * refine docs according to Jonathan, thanks! * add checkpatch doc according to Joe, thanks! -v5: * Simplify the code for Patch 2 according to Joe's suggestions. * add s-o-b of Barry according to Jeff Johnson v5 link: https://lore.kernel.org/all/20240401012120.6052-1-21cnbao@gmail.com/ -v4: * fix Xining's email address, s/ma.xxn@outlook.com/mac.xxn@outlook.com/g * fix some false positives of checkpatch.pl * downgrade from ERROR to WARN in checkpatch.pl Thanks for Joe's comments! v4 link: https://lore.kernel.org/all/20240328022136.5789-1-21cnbao@gmail.com/ -v3: https://lore.kernel.org/all/20240322084937.66018-1-21cnbao@gmail.com/ A function-like macro could result in build warnings such as "unused variable." This patchset updates the guidance to recommend always using a static inline function instead and also provides checkpatch support for this new rule. Barry Song (1): Documentation: coding-style: ask function-like macros to evaluate parameters Xining Xu (1): scripts: checkpatch: check unused parameters for function-like macro Documentation/dev-tools/checkpatch.rst | 14 ++++++++++++++ Documentation/process/coding-style.rst | 23 +++++++++++++++++++++++ scripts/checkpatch.pl | 6 ++++++ 3 files changed, 43 insertions(+) -- 2.34.1