Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp1140197lqh; Sun, 5 May 2024 19:15:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXu/L2qXR1fEmk02JWqnDjP8mFR1SqxDEpKoIJdsGzhBzq8AxIaP0EpUCjMlLRnM416a6jkTmji6eHZ9KiCC+z6YbQd9sxvIhaF6boHDA== X-Google-Smtp-Source: AGHT+IEqYT30DXJUpAMQasMVzNioo4mW8yyrepeM2KAhYvMb5CebAEEY6yBJ+yhv7twYDMDslmQ/ X-Received: by 2002:a05:6a20:c91c:b0:1a9:509c:eba6 with SMTP id gx28-20020a056a20c91c00b001a9509ceba6mr12749337pzb.25.1714961731100; Sun, 05 May 2024 19:15:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714961731; cv=pass; d=google.com; s=arc-20160816; b=w6j74L3KfSUGIPj9mXST68/3wQCi5n9m3QnrtdRdbrR4SujekbULFhmFgtK7gfruy3 R2EFBMEqYO/KeAnmg0ZGWxoqdeGhBGD8zKavoa0ypVTtHJn9/yD341N5gNt0zAUUKfN8 evL9ActhiCY3Pa06Tn9ggCpcJVR+/qawV9KlSAk3T3yEbr1HJSszZ3xB81UOuGwRaufP 3VFJk7m4HtlHvhTPLccxSCM11C7MYZ2BhOk25EQ7adDLMo1hfQrMOuoTPORJr1XBpeOn ZmzN16kBA20bwNPSLL+pyFGyErp2UpEWT4r46ZN63fhHwSmREAgo2qKsHpYz0AgeXtIQ emaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:date:message-id:from :references:cc:to:subject; bh=dfiMbKO6jnY4J6LfPPkwis4W3ybLYw7d5ywxWCvuhus=; fh=voLEQ0JOP6ulkm2pSLQ6NwbM6MkOxL1TNfkaMZ348GI=; b=vkFO4Zeme19OLc/zVw3loatgeEY7UA+BId/zsHmxPtTBDOlrDOMfyv9KzC+yHklSFa k/Mejyxkck2PSgJniobXcSg45w3xaQcAPHL/cUcRvfQUywVrsDumpGySWJ6ykFJ+znmU 0puapOQM/rduoiU8U42nT7W9HgckqaJ2Xi8D8SoPag/8JvpD9YTS9CmF1JIdR5w2vn4Q AawBxJEVpkwnd5iWFVrE2dXNx3cC1Vt4Np1yGdkORFKbnK0cb3D1ssaTGrvyEDhEQ56L jtB2JdYXCiRiMOat2g2oG1i36SX04/eRgqc/JBFLVEdtSXWSgAv2bdNIy7DYW/4zsZdS KDCw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-169250-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-169250-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id u8-20020a056a00098800b006ed2669d23fsi6094573pfg.135.2024.05.05.19.15.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 May 2024 19:15:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-169250-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-169250-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-169250-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id ACE38281FB8 for ; Mon, 6 May 2024 02:15:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5EAED40847; Mon, 6 May 2024 02:15:22 +0000 (UTC) Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84215EAD2; Mon, 6 May 2024 02:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714961721; cv=none; b=j8vEbYinYUicSawowNgppf5t1pajo/Bbu5JL0+kQIGo1iJAMgR9/EUzKp74idjbz0ExiAQdQ9xEyNIlUYfxUrmQORth3kpwrn8Nakf9S/fsJIRwPrv3CDm+jQH2w74XzPfczkFXkGtjXx3TiKxlVPAGEpU+rOHG8YFN8QibKZJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714961721; c=relaxed/simple; bh=mUDIFPzPharsssWisgRYGdsHHuDz5PMIOIZIsfNsDNQ=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=ET9wJc3qeZRzamk8OhSS7E4rl8RFm75JGrsUFnAxg+5M9LE7rq3ynBrNa8BoSqqDmiq7JYcy4QoxFrM52P1QcgAgyC4kWY8Od3uTnrq9fb+DYWkD9uHx1RQfsKmt3QaCIfu0Js2AVzniJg1Y3+sZS6JIcmrlsruDJl+56OAnrY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4VXlNt0ByBz4f3lXb; Mon, 6 May 2024 10:15:10 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 44B631A0572; Mon, 6 May 2024 10:15:15 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP1 (Coremail) with SMTP id cCh0CgB3jgctPThmL6mELw--.10749S2; Mon, 06 May 2024 10:15:11 +0800 (CST) Subject: Re: [PATCH 09/10] writeback: factor out wb_dirty_exceeded to remove repeated code To: Dan Carpenter , oe-kbuild@lists.linux.dev, willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, tj@kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <6d3471cd-f491-4949-ba75-9fae63198b59@moroto.mountain> From: Kemeng Shi Message-ID: Date: Mon, 6 May 2024 10:15:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <6d3471cd-f491-4949-ba75-9fae63198b59@moroto.mountain> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:cCh0CgB3jgctPThmL6mELw--.10749S2 X-Coremail-Antispam: 1UD129KBjvJXoW7uFykXryDWw18uF4DAFy8AFb_yoW8Gw18pF 4rua98KF4rXr1xtayDJrW7Za1Yqws5Jw17WwnxWw1fZFW29F9Fgr1I9rWagrsF9rn7KryY yrsIvFyDtw1UK3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvab4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IE e2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q 6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv 67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyT uYvjxUrR6zUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ on 4/30/2024 3:24 PM, Dan Carpenter wrote: > Hi Kemeng, > > kernel test robot noticed the following build warnings: > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Kemeng-Shi/writeback-factor-out-wb_bg_dirty_limits-to-remove-repeated-code/20240429-114903 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20240429034738.138609-10-shikemeng%40huaweicloud.com > patch subject: [PATCH 09/10] writeback: factor out wb_dirty_exceeded to remove repeated code > config: i386-randconfig-141-20240429 (https://download.01.org/0day-ci/archive/20240430/202404300231.bnb28iB8-lkp@intel.com/config) > compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202404300231.bnb28iB8-lkp@intel.com/ > > New smatch warnings: > mm/page-writeback.c:1903 balance_dirty_pages() error: we previously assumed 'mdtc' could be null (see line 1886) Will fix this in next version. Thanks a lot for the report. Kemeng