Received-SPF: pass (google.com: domain of linux-kernel+bounces-169292-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 5 May 2024 21:07:42 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, Ira Weiny <ira.weiny@intel.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC: Dave Jiang <dave.jiang@intel.com>, Fan Ni <fan.ni@samsung.com>, "Navneet
 Singh" <navneet.singh@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>,
	<linux-btrfs@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 07/26] cxl/port: Add dynamic capacity size support to
 endpoint decoders
Message-ID: <6638578e2d7ed_258421294f@iweiny-mobl.notmuch>
References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com>
 <20240324-dcd-type2-upstream-v1-7-b7b00d623625@intel.com>
 <20240405145444.0000437f@Huawei.com>
 <66351a55a38db_e1f58294ce@iweiny-mobl.notmuch>
 <66351d0f9ac2e_1aefb29492@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <66351d0f9ac2e_1aefb29492@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xBbcKnQvGICUMtMlP+seQXA/LfzVvbR1uSKq16g/pY60m046pIUrjiTfpJW+?=
 =?us-ascii?Q?khiwrypf5zW87v0hytqz9dLSn6XvmCtvqDgg6VtsYxPC0DLSjfCTg1Gw/Y2t?=
 =?us-ascii?Q?HKEtzimcXqtWF7MaKz93ueTR3Rs4hCaP5HroxY42sTRW+6BRAg6tlrDnpQ+U?=
 =?us-ascii?Q?9Ni1lOz2VvUhlrVtG3wcNOC+Mn1P8ud/nrBbuFMmmWac1R9z01iOPpG3HcvI?=
 =?us-ascii?Q?V/2Q/HQpeMV1wLXM8C2KK5rVjlaKGBOpQZoqn1xy3/sij6WwHNH1B6Bq2px8?=
 =?us-ascii?Q?217S5CkFVv7TbFRzFq1WSlD0VbwZsNs9wyc+S9Jnd2Rp2HJEtah61lMpOTkW?=
 =?us-ascii?Q?fE7MMfwuP5HJ4MCn3812MAcxh4ve7nnd/rCrAfdgQzHYeKLMF15iZNghqDHA?=
 =?us-ascii?Q?gxN7qu8nj2qRKd93krsoj6ANNA2KI/Y+U1Nay8Wdl2lIn53apa5/2UOhJUha?=
 =?us-ascii?Q?6uH8weKqjpA1JpegRijIqZ0Clfjf3nC56B/XqFAA6/j0aLihIALGIDS10lQ2?=
 =?us-ascii?Q?KTheTpouZI5xjJRawzA+yyzZXygPSlSkXZG/P++jyn7xkge1+Y5ftZ+DjEqz?=
 =?us-ascii?Q?iP/axndCs4aL5clurL1FmRXSasolXuwUaZJ574Y6gvFGsqj0F1xJcJPiI44F?=
 =?us-ascii?Q?lJBhv66RA293c3JOVcHPXwjCcwXUHg05kqT0ObQuK3/GFjtsr15rmnCv7grz?=
 =?us-ascii?Q?KD23zwAoAsw/veXJTMN64wfaZDk9t13DF82aY70FkVkT+8QD/qNHE8sFELtu?=
 =?us-ascii?Q?GJIS6Hc86LjpfJtI6/kDPhd/g5HKa++kcjWMuAe3IBx3zdZ7brka5n0jUYHs?=
 =?us-ascii?Q?93bF/4AURHZkugP6/U5gL5QcRDq0/9ASNUp13ceuTdSjVQwH+EnE0rbdQlG7?=
 =?us-ascii?Q?1DQQ/85dSxN4an4+V4CfH45swydRULPTabMCFpGi2IvKbRJoeF/ef3E31pRD?=
 =?us-ascii?Q?4Mv8+AeCIvWGA+lKJKzntG21pW8IesSZVdy8D62M8+cfweu7eEnXs7mI5B1T?=
 =?us-ascii?Q?o+VpYJx+/0BF5GRdm+rUwq9cWXsqRPlHC9Iz4S1kABCLnnSDj1xXMULWiTVS?=
 =?us-ascii?Q?0L6kdvx6Z2Z0AW/h5yyOW4u7Qx3E28lHmJla8JrwPC2uLxvfFQlw75IVwT9Z?=
 =?us-ascii?Q?vaWmVXJTJ6ITP9tQalZF+sX3xxNWPaTrW0amr1HU2RLtYYqu2PJ1BzSHSFl/?=
 =?us-ascii?Q?pE4Ut4YkCTjfgrXJ7HzMtyt4KQTWJaYfd7pSd21Za+OamBwtLYBxbL26orBF?=
 =?us-ascii?Q?NizGgESfeX6f4w84P9UdgUiXKgDbO4cT52csWVCJhgy8cZHwal0DuYgPA5Ro?=
 =?us-ascii?Q?Q9WJTii/oJg7U/CznGs8zCMrUvqtaHTu81qP8gcH2/bpltEVfgBYyMoCFM4d?=
 =?us-ascii?Q?J55vMfMbsNcGrhWCec2ZVHFjQJn/2X1d9+3znifTn8L97f2YzYSKBcz/cLM9?=
 =?us-ascii?Q?g1whoHsS54HCjxXW3Ww6PkuhEdAEk+29XMCsvBs0udQjA4PUb4I3IK2Git3/?=
 =?us-ascii?Q?ABnf0H93iGYAbkp6GSr6g0SUpe0OmfRgVoPTrrabh1feMb+4D7rOq60nqlqp?=
 =?us-ascii?Q?pV6/v1fjGNO4tryyAevlcv4nTN0UloiOEB59NGtI?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f438d348-c21d-4dfd-7ca1-08dc6d821550
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 04:07:45.1734
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VODxQLe9x8GKZkw8Vq8fPbEgz165v8avaFA90S9+OTZlh4q70SmEa7QGuT3ykQm0dIO8TDytWByzUfNtnTdyzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7867
X-OriginatorOrg: intel.com

Dan Williams wrote:
> Ira Weiny wrote:
> > > >  	else
> > > >  		free_pmem_start = cxlds->pmem_res.start;
> > > >  
> > > > +	/*
> > > > +	 * Limit each decoder to a single DC region to map memory with
> > > > +	 * different DSMAS entry.
> > 
> > This prevents more than 1 region per DC partition (region).
> 
> Why? Multiple regions per partition is the current status quo for other
> partition types.
> 
> > > I notice in the pmem equivalent there is a case for part of the region already mapped.
> > > Can that not happen for a DC region as well?
> > 
> > See above check.  Each DC region (partition) was to be associated with a
> > single DSMAS entry.  I'm unclear now why that decision was made.
> 
> The limitation of one DSMAS per partition makes sense otherwise that
> would indicate performance across different spans of the partition.
> 
> > It does not seem hard to add this though.  Do we really need that ability
> > considering dax devices are likely going to be the main boundry for users
> > of a DC region?
> 
> It seems like extra work to make DCD a special case compared to the
> other partition types, so the burden of proof is the other way. Why
> tolerate DCD divergence from the status quo?

I don't remember the details.  But this was discussed before in a call.  I'm ok
adding this support.  I have a test for it now.  Just need to tweek a couple of
things.

Ira