Received-SPF: pass (google.com: domain of linux-kernel+bounces-169334-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f11f09b4-03a8-4020-9f37-4ecafce63105@intel.com>
Date: Mon, 6 May 2024 13:58:36 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v10 09/27] KVM: x86: Rename kvm_{g,s}et_msr()* to menifest
 emulation operations
To: Sean Christopherson <seanjc@google.com>
CC: <pbonzini@redhat.com>, <dave.hansen@intel.com>, <x86@kernel.org>,
	<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<peterz@infradead.org>, <chao.gao@intel.com>, <rick.p.edgecombe@intel.com>,
	<mlevitsk@redhat.com>, <john.allen@amd.com>
References: <20240219074733.122080-1-weijiang.yang@intel.com>
 <20240219074733.122080-10-weijiang.yang@intel.com>
 <ZjKP7_vydkig2FQ4@google.com>
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZjKP7_vydkig2FQ4@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1BXUmxCKy9RU1lvYm1qZy9rN2ZzcGFYLzArNzdQU1pvNVRnN3pYd1diM001?=
 =?utf-8?B?RXFRZkh2azlwNEZSQUVVZUpPU1RnUUpCaHN1YStXZjVwMTBUMDB3Qm9ZSkRn?=
 =?utf-8?B?ZE9NTXRSTnN0VkFVVXQyUmZzczlad2Rxb2hLL0VMWFVaU2xIM2Z5cDhaWkJa?=
 =?utf-8?B?YktBbGZLZHhFZjB2cUFCMnZCS2lSdUFxb3F1cVlZaDFRZWVTa1I2dzkydmtW?=
 =?utf-8?B?cHNmUzZQelE4TTRzdktTaWtIb0hkU2N3blYvU1AvZDZ3QndsK2lUa0pKVURX?=
 =?utf-8?B?Vm8vK0gwMmxIY3kycThNbTdsTXI5QjNKQkxxTEZ6ejZneFBwZGs5NXRpNmRn?=
 =?utf-8?B?bkRsb2lZUTNBNktsT0ZrU0NkdVRSUnRPZTBIcmhqa2gzcTY5UFZCWWl0Wmdx?=
 =?utf-8?B?VklLbkMwZVdYdXkyTUZid1RFRXVrdVhQdFByQklZQ2FsODF2ZnpRU0xUT1lT?=
 =?utf-8?B?b1IvU2JEVi82SGp6cmp2VURTOFFEVmR6bHptNDRjbWYvck1IbUhSa3hPWUZk?=
 =?utf-8?B?eVFOdWF3YStCZmFGaTFNcEh0aE03QjdQdFAwRVp2dTZFR0tvbU1OVDBaUCto?=
 =?utf-8?B?cXJWMS9LeDc1Rm9jU24yZGRnVFlrZ0M5d0JCT3VidTVjdk1DbmFabzgzdUpD?=
 =?utf-8?B?TVpBM1Z2TkNnOUlRdi9TZ0dNRHorMnJCclJCOUNaaTR2N08xQmRWWWhXbXVx?=
 =?utf-8?B?NlhjTFdDdnNveWNPcjdsUXFxNHRiNUpSbnNJN3FjUS9sQXNDVW5JWHY3M081?=
 =?utf-8?B?RWVaOUJ1aWpQSFA3OXFtVWhqTWRmbkFlN3dVTkx2dyt5SHZ0cktoNi8zd1R4?=
 =?utf-8?B?YkdLTXd1YStIbExJTWFCZmJQMHNqMnBwbXBMNS9oSXhoN0ZsZGp2SUVRbk5Q?=
 =?utf-8?B?UDNPOGloQ2NHQThYeHQybFhFSWRlek9CUWNCRHhaOXZhSFZXYXFhL1hmQmo0?=
 =?utf-8?B?RXNVRG1DZU1zcUZTUWEyeVFvS1BKcHEvcTU5TjZ4clpycGZXdk5GMHlHcjhJ?=
 =?utf-8?B?ZThpNVpOdkFHSVZ6N1NnbXJhdFFEb1N0SlpEMHJXWHpNVVY1WnErMUFYTUpI?=
 =?utf-8?B?VHNKMTdYQzZiQm1vRlpXa1k1Ky9EUzBTQU5NcnVTa2R0YTZ6UTlSV0pQM2tz?=
 =?utf-8?B?SUhRbE5qMlJhdFZGTFlBdUpoMXBKbjhQWG5rOW12ZE9rNThUMnJMN2hVRWgy?=
 =?utf-8?B?NHVhS1Y2ZDZ5V3QydFJUZC80bWNudDVHQlI0SWd1Y1lNUWNiRC93UEQ5czlR?=
 =?utf-8?B?MnFXY3JqbWJHcWVnL281ZTdsQU1aNHJvRFdpVXhyUWVYYysrcDNURS8zSUdh?=
 =?utf-8?B?Ujhjd0xtS1FidGlOblNkbmI4Um5yTWdSaWVwWjZRUnVZVlZCZmd6bktOTXJu?=
 =?utf-8?B?RmhRWWRVeWdXUXppMlpGaGRXRHRVUlk5dWc0UHRlS1hXenJLVEUxdWlCdGVP?=
 =?utf-8?B?T3p3bG04ejc0M1VnU2t1THMwM1UzbUlBS3l3QTZabFhLdmh0UHZ4YURINFlG?=
 =?utf-8?B?MFZTd3M2QTRORmdTY1ZROWFXbWQ5Q2RlQy9BYndKRkU2UC9XWUVHRlUvWUZq?=
 =?utf-8?B?a3FxUVFKTUpkb2xDYXhkMHNhTjNTSVFHREc4T0hkbXFBYzZseG1XbnUzREpj?=
 =?utf-8?B?SFZiY0ljS2tUOTVHTDN5SjZtd2dDWHRQS1JqTWk1emdsK2NOK2FCWk95RE9F?=
 =?utf-8?B?V0h1eHY5UjZJUzU3STNWZitLdDdjQ1dUU0NNWVM3d1c4T3VacU5lVm0wVmd1?=
 =?utf-8?B?ajN0cWxaRG9scmVGZ0s5Qk1JclpocnZjWUpWaDNLRG1PMmZjalEybVBhd0Fr?=
 =?utf-8?B?R1VlWkxmMnM0cnhwZXNPVm9CbnREMGhTYW9YQVRSTlQ4TzhudWVaWndCSjlo?=
 =?utf-8?B?cHRLU2NjZ05qd2p1eDFlOXlmUm9qSEVEblYwQWRQTjBlc2pmRnVLS253Y050?=
 =?utf-8?B?SkxTY2pVKzNPWVFiMXJhWlBlYklsUXlwS0NOQzdUbTk1WXlrSHBhTzNXSTJo?=
 =?utf-8?B?S3U3amxqK0RKOXp4RjBtVnF3UlRWRUc1VTRibkhIcS9nR2FmQXBHYmp3VFhY?=
 =?utf-8?B?US80SzVJSG14aXBwK3F5ZmVVR3dtQWovSVVNSHlBRmRrMmhUaHFWU21KWUtX?=
 =?utf-8?B?ZVRWQkVJbitEYkNIMkZGYUJ5QmxMWlN6QnV2bUZ1S0pmNkJPSGdDdEIvcXEy?=
 =?utf-8?B?dmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 719e436c-b506-4bb4-9dc6-08dc6d91972d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 05:58:45.7429
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9ezlHWEolPHxTctgZjp2EFmVNzFzWul4S1EVcnjDIKlR0rEdsTgO5DCaudLCDuZgqbyZeT6Azk7hZvl9+mL+1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7730
X-OriginatorOrg: intel.com

On 5/2/2024 2:54 AM, Sean Christopherson wrote:
> s/menifest/manifest, though I find the shortlog confusing irrespective of the
> typo.  I think this would be more grammatically correct:
>
>    KVM: x86: Rename kvm_{g,s}et_msr()* to manifest their emulation operations
>
> but I still find that unnecessarily "fancy".  What about this instead?
>
>    KVM: x86: Rename kvm_{g,s}et_msr()* to show that they emulate guest accesses
>
> It's not perfect, e.g. it might be read as saying they emulate guest RDMSR and
> WRMSR, but for a shortlog I think that's fine.

Sorry for the delayed reply!
It looks good to me, will change it in next version, thanks!