Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp1202518lqh; Sun, 5 May 2024 23:10:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXYVcjgh03kMTlLEBYaDdhwNk8FuPWcZnChBZoSwoi1ZxhmmU+/CFd7NJyR8OcVW7ObTKg25B1Z7hyKSkVxc2AJXXL5yvtiO9Ke47JYKQ== X-Google-Smtp-Source: AGHT+IFNurlf9DSrU4zzJiAhi+dIlRn7YdRtq7LIO9fVmENLxeoILaWOWjOnNuLyV7bmmUxdTmz9 X-Received: by 2002:a05:6a00:4f83:b0:6ee:1c9d:b471 with SMTP id ld3-20020a056a004f8300b006ee1c9db471mr10632987pfb.25.1714975832869; Sun, 05 May 2024 23:10:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714975832; cv=pass; d=google.com; s=arc-20160816; b=so3uRg7JNJ1up+8xtZlVjBS7JFXgT4c3yC2ht5hOd2ptCNFX4J8OfT8ecAB/WxCkvn ixBG+ik1W40N+Zc5pVQQJc8xamD4fud+G3svFd86J4no1k6HomtYyf1Pef6Dzkgue39A Y+Xp7eoT8fS5gOOQ14JPSrJhfs0YCA6b8R3J7Lo9cPmvjuVE/FLugoDzNgJmqLYFHEF4 8UrdWYtzQWPtRrrU+0NJz+kQ5tuiu1DIdllJoYD3eYORjb64/Q5AAVaopiAKwlwZXcQq WUbw5iykZKaIFMxTkChfaCsArPClDHChUrV0n/HesUOtIS5EU2Bcsd9k+0PBhqloQWH5 lvww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=QonK/Ng6ummVMCkLbPyb9340Dw7wp1zEIpRJ/0DPc2g=; fh=MTq2i4NvcHpfYlg9AEq+s7PDh8DQdPNmXE4qS2CraeU=; b=Udt7Q9wEyLlDXspt0RcU9vmDtONVLEp2t61408pzyKvRtYLvBY8WZygQjYH2o1NhAp ZJvv4XXSva69t8YU6eKInY8cMKom0X2VxsXx5xt2/cxr98IFku2/6nzG0GJs6k1id4pa othlt7/pPzbe8wQObXLrYc7bg8RwU1m9ttoyMjbfaBInLORjZzhqtY6wxpXVlWPEDRlg xdi7XG/QA1pgEZFh9Yc/pV3az8kI7m+7kV/5G+G/r3DUjD1S7fPkcar8J4PDssn9XTEX 3l4U8T8ZSNAdPfOUa8ZhEAQtddU0tM8cnZUwH9uRi7ZFTgKrXtM2rLjLgP+mSne0Re15 qpOw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-169345-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-169345-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id q4-20020a056a00088400b006f455317ce5si4974075pfj.107.2024.05.05.23.10.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 May 2024 23:10:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-169345-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-169345-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-169345-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7AA38281480 for ; Mon, 6 May 2024 06:10:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A2AFD4CB4B; Mon, 6 May 2024 06:10:25 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 95ACC48CCD; Mon, 6 May 2024 06:10:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714975825; cv=none; b=tJ+cG2z+POUUIgOoFjeEH88Bi1enDAZ6cB3SQtm8/TS7rmVZ7J9496v3Fo4lyLEpr1Qi7BdZCOydLt07k+brrGdDkWLLD+odwONsYPnXILwFfsM4mKWutp14+o7eYH0gJKwk7pAqMfOj/wqLgUTdDLwQ3KjSzyejXI0sk4dVhl8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714975825; c=relaxed/simple; bh=d9WvYebWfy7ti2lzrEEL3q0vMZgI9PwJYjd0o/nAgD0=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=K9x0bUb7vjQOStgwW/OVhLogUOakMgswQirTyPg5CwYSOPvka9+uxzonai5MoUL+gWUEkN1L7eGrxnCBCtNAafbAPdrH/s3GPGyrrFGvrtObppjw4KN74wI6akzhNgJPqBgWb9er6HQiyA0lPar4Z1Xh3MUBvIjh4rHffvfy+9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8BC8C1007; Sun, 5 May 2024 23:10:47 -0700 (PDT) Received: from [10.163.35.238] (unknown [10.163.35.238]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B5173F762; Sun, 5 May 2024 23:10:17 -0700 (PDT) Message-ID: Date: Mon, 6 May 2024 11:40:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] arm64/arch_timer: include To: Puranjay Mohan , Catalin Marinas , Will Deacon , Sumit Garg , Stephen Boyd , Douglas Anderson , "Peter Zijlstra (Intel)" , Thomas Gleixner , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org References: <20240502123449.2690-1-puranjay@kernel.org> <7008cd0c-5b65-4289-9015-434cbe3d7e21@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/3/24 15:14, Puranjay Mohan wrote: > Anshuman Khandual writes: > >> On 5/2/24 18:04, Puranjay Mohan wrote: >>> arch_timer.h includes linux/smp.h to use DEFINE_PER_CPU() and it works >>> because smp.h includes percpu.h. The next commit will remove percpu.h >>> from smp.h and it will break this usage. >>> >>> Explicitly include percpu.h and remove smp.h >> >> But this particular change does not seem to be necessary for changing >> raw_smp_processor_id() as current_thread_info()->cpu being done in the >> later patch ? You might still leave header inclusion in >> arch/arm64/include/asm/smp.h while dropping the per cpu cpu_number ? > > commit 57c82954e77f ("arm64: make cpu number a percpu variable") > created this percpu variable and included in > > Now we are removing the percpu variable cpu_number from smp.h, so there > is no need to keep percpu.h in smp.h Fair enough. > > I feel users of DECLARE_PER_CPU_[...], etc. should include percpu.h and > not smp.h as it makes reading the code more easier and can thwart build > issues in the future, when headers are changed. Right, makes sense, hope there is no more such cases using smp.h to pull in DECLARE_PER_CPU_[...]. A quick build on defconfig is successful after this patch.