Received-SPF: pass (google.com: domain of linux-kernel+bounces-169397-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 6 May 2024 15:09:27 +0800
From: Oliver Sang <oliver.sang@intel.com>
To: Borislav Petkov <bp@alien8.de>
CC: Sean Christopherson <seanjc@google.com>, <oe-lkp@lists.linux.dev>,
	<lkp@intel.com>, <linux-kernel@vger.kernel.org>, <x86@kernel.org>, "Ingo
 Molnar" <mingo@kernel.org>, Srikanth Aithal <sraithal@amd.com>,
	<oliver.sang@intel.com>
Subject: Re: [tip:x86/alternatives] [x86/alternatives] ee8962082a:
 WARNING:at_arch/x86/kernel/cpu/cpuid-deps.c:#do_clear_cpu_cap
Message-ID: <ZjiCJz4myN2DLnZ5@xsang-OptiPlex-9020>
References: <202404302233.f27f91b2-oliver.sang@intel.com>
 <20240430172313.GCZjEpAfUECkEZ9S5L@fat_crate.local>
 <ZjE7DkTBSbPlBN8k@google.com>
 <20240430193211.GEZjFHO0ayDXtgvbE7@fat_crate.local>
 <ZjFLpkgI3Zl4dsXs@google.com>
 <20240430223305.GFZjFxoSha7S5BYbIu@fat_crate.local>
 <20240504124822.GAZjYulrGPPX_4w4zK@fat_crate.local>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240504124822.GAZjYulrGPPX_4w4zK@fat_crate.local>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FK6ZT5sUfq8IlEVKjbOaqk3S7vJGPAsKIxigWgQWlVvxvN8H24RHbrKwup0n?=
 =?us-ascii?Q?SWafGnhtWXtSNsqfEQUieSJ48YOxJIcb9Tabeq+fTeTIDN1OXieOcVQ35Rg+?=
 =?us-ascii?Q?yST/99BjM10TohbxI69YBaMCDJMF1VewoPkEY7lIEzmqvXaCkUfjB5Bopjh4?=
 =?us-ascii?Q?CqsybdxMCBVrRLpjNkwXe2PnDQgTbYQe7U6uAeAOnNRVePaB0/t/bRPBhJBy?=
 =?us-ascii?Q?VfnPrK38NQe2zKmqnIEb4qnVp77WEouinRJe61V1xZJxH9Ui3NFI5yxZgHut?=
 =?us-ascii?Q?WltQ/3cEZjFqjhDNBHLxwTVwv3ujKMHGTF/pce7ft82LX545UsKPCAtJeHKF?=
 =?us-ascii?Q?kaIr0lPE3E26zk9AiVxN4apClwyyCefv5iqhUKdGQTkfcY4rviqG0SP7n0ay?=
 =?us-ascii?Q?PrUDLQRfoWh5JqDL9a9jrrYFerJgyegoAmxoGy5+UsEoKj7Fk6EGfs2Gzhm1?=
 =?us-ascii?Q?Nn3cmSZNo9sbP0UoQThAftXrpall9tMabWOZU1fQCgXljh5OY8YiRGICiRdw?=
 =?us-ascii?Q?VU601DuoH6nQNAxnZUb3HVSMCNhwMpY1GX5UC5/Y73Nb+A9Cp1K+LKXy+b+V?=
 =?us-ascii?Q?T19Mfm+TT7zAP9FwDoEojHk1FHqAw2XA801J5r6ibaDyOsn1z6xie3TpIUsf?=
 =?us-ascii?Q?tZeu+tbnh18X5qhhDSz+iG446Cv4n9PDaaj9Nb3O2+VF8dFjk3LuvMZUzfcq?=
 =?us-ascii?Q?JN8RklTzG4H5tSiQFigrPzQ1OA+23I8tv6G1mZT90plRCXe4h0KJ58sU2KJ8?=
 =?us-ascii?Q?38Z5aA2Fhwbt4CgU8ybvOH+7eV8yEKUGR17sfbdJcRZ/Wl3QUzjjjxTYCpar?=
 =?us-ascii?Q?GbESknd9RQeN+Pt/hCmRCTD93rAPm6V2RdoX2DFOZ+1Nqt8g1+kbAljHexHY?=
 =?us-ascii?Q?WDG+q55VwmVT4g2eCwtccCoNeo1vv1pJs5crkAYIcCde57Ni7fCoQbM7yJwd?=
 =?us-ascii?Q?EN4xiM/Vgwi4KQ7E5+vl2cOgh2/RUxWLQUO1uw2bjNNRjKnCakJEWXmTpKSo?=
 =?us-ascii?Q?TKgPkdMyFh+1mUYVp+wCa1s9s+uBD2hnzmwTYbFWaGskMx9Xk7oIqfqLPoFh?=
 =?us-ascii?Q?Fv8/nOxjoY4Ep1vt2zzjtYrL2uWpDaMoEqzRACXGLVvmGFNNUVG/dcIFRYg3?=
 =?us-ascii?Q?8kgdGLwrYlbNqhRgZZs4/Suc855ZELuLmd1HeW7Hyd/AsE0O3GW1xKna5aIn?=
 =?us-ascii?Q?Siy7lYg0wpGfb8QMQTvrHvsoKJi2evOAO+QMVO3eGOlGnWkCRr3U9uFKF+W8?=
 =?us-ascii?Q?BJHo3dWXLTva7KxMbY/sqAmliTJ6JaaQn6RFWevQXfUzBzWbgoNgm9thrMQW?=
 =?us-ascii?Q?je0wtdJsEWnLV4OhrCWMkiGAZ9Hod/53SGhS/kJga+8JmVW+a+3O/4hoNwLc?=
 =?us-ascii?Q?TLwhm6JxtPVfsod+5nGUqGB7+wsYVuVlL7/QvVREJpaVHqwfQ9vxPehwDK9H?=
 =?us-ascii?Q?WawxwfJ+n3AAcsrKxm/iv7ZY+7W6bd38qQOkHKzaqBiFixMYMYTYF7qDGU9n?=
 =?us-ascii?Q?pqGXYKCfpJKJzDwj7DDS1A3eP5F6FCsNwFt+0Gu20MlHfB4KpR8HLB1s+Grc?=
 =?us-ascii?Q?YnAZt3mdZEnLebUxst5hQp9IkbF7/MFbIRSTrxgX?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a6891a3-5500-4728-9f47-08dc6d9b7ce3
X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 07:09:36.3408
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oey3An7AEwt3zz59Y6BJZUjougMLQZP8b9IK+SoAmgevEhZPLh3bI4joNaOjvOZiQ043hclT7kGH4+/w+46/+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5125
X-OriginatorOrg: intel.com

hi, Boris,

On Sat, May 04, 2024 at 02:48:22PM +0200, Borislav Petkov wrote:
> On Wed, May 01, 2024 at 12:33:05AM +0200, Borislav Petkov wrote:
> > On Tue, Apr 30, 2024 at 12:51:02PM -0700, Sean Christopherson wrote:
> > > But that would just mask the underlying problem, it wouldn't actually fix anything
> > > other than making the WARN go away.  Unless I'm misreading the splat+code, the
> > > issue isn't that init_ia32_feat_ctl() clears VMX late, it's that the BSP sees
> > > VMX as fully enabled, but at least one AP sees VMX as disabled.
> > > 
> > > I don't see how the kernel can expect to function correctly with divergent feature
> > > support across CPUs, i.e. the WARN is a _good_ thing in this case, because it
> > > alerts the user that their system is messed up, e.g. has a bad BIOS or something.
> > 
> > Yes, and yes.
> > 
> > There are two issues. Clearing feature flags after alternatives have
> > been applied should not happen, and this particular issue with that box.
> > 
> > Lemme cook up something in the coming days for the former.
> 
> Two simple patches as a reply to this.
> 
> Oliver, can you run them on your box pls?

we confirmed after applying them upon ee8962082a, the WARNING which was reported
in our original report cannot be reproduced any longer.

Tested-by: kernel test robot <oliver.sang@intel.com>

> 
> Thx.
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette