Received-SPF: pass (google.com: domain of linux-kernel+bounces-169404-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 06 May 2024 09:19:31 +0200
Message-ID: <875xvrif0c.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Shuah Khan <shuah@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Ivan Orlov <ivan.orlov0322@gmail.com>,
	linux-sound@vger.kernel.org,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev
Subject: Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree()
In-Reply-To: <20240505210824.55392-1-jhubbard@nvidia.com>
References: <20240505210824.55392-1-jhubbard@nvidia.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Sun, 05 May 2024 23:08:24 +0200,
John Hubbard wrote:
> 
> dump_config_tree() is declared to return an int, but the compiler cannot
> prove that it always returns any value at all. This leads to a clang
> warning, when building via:
> 
>     make LLVM=1 -C tools/testing/selftests
> 
> Furthermore, Mark Brown noticed that dump_config_tree() isn't even used
> anymore, so just delete the entire function.
> 
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>

Thanks, applied now.


Takashi