Received-SPF: pass (google.com: domain of linux-kernel+bounces-169401-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Barry Song <21cnbao@gmail.com>
To: joe@perches.com
Cc: akpm@linux-foundation.org,
	apw@canonical.com,
	broonie@kernel.org,
	charlemagnelasse@gmail.com,
	chenhuacai@loongson.cn,
	chris@zankel.net,
	corbet@lwn.net,
	dwaipayanray1@gmail.com,
	herbert@gondor.apana.org.au,
	jcmvbkbc@gmail.com,
	linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux@roeck-us.net,
	lukas.bulwahn@gmail.com,
	mac.xxn@outlook.com,
	quic_jjohnson@quicinc.com,
	sfr@canb.auug.org.au,
	v-songbaohua@oppo.com,
	workflows@vger.kernel.org
Subject: Re: [PATCH RESEND v6 2/2] scripts: checkpatch: check unused parameters for function-like macro
Date: Mon,  6 May 2024 19:16:57 +1200
Message-Id: <20240506071657.13434-1-21cnbao@gmail.com>
In-Reply-To: <5e26f82913801050afa4442dfb9a07249895ab98.camel@perches.com>
References: <5e26f82913801050afa4442dfb9a07249895ab98.camel@perches.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

>> From: Xining Xu <mac.xxn@outlook.com>
>> 
>> If function-like macros do not utilize a parameter, it might result in a
>> build warning.  In our coding style guidelines, we advocate for utilizing
>> static inline functions to replace such macros.  This patch verifies
>> compliance with the new rule.
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -6040,6 +6040,12 @@ sub process {
>>  					CHK("MACRO_ARG_PRECEDENCE",
>>  					    "Macro argument '$arg' may be better as '($arg)' to avoid precedence issues\n" . "$herectx");
>>  				}
>> +
>> +# check if this is an unused argument
>> +				if ($define_stmt !~ /\b$arg\b/) {
>> +					WARN("MACRO_ARG_UNUSED",
>> +						"Argument '$arg' is not used in function-like macro\n" . "$herectx");
> 
> trivia:  This should be aligned to the open parenthesis.
> 

Hi Joe,
I assume you mean the below?

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9895d7e38a9f..2b812210b412 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6044,7 +6044,7 @@ sub process {
 # check if this is an unused argument
 				if ($define_stmt !~ /\b$arg\b/) {
 					WARN("MACRO_ARG_UNUSED",
-						"Argument '$arg' is not used in function-like macro\n" . "$herectx");
+					     "Argument '$arg' is not used in function-like macro\n" . "$herectx");
 				}
 			}
> Otherwise:
> Acked-by: Joe Perches <joe@perches.com>

Thanks!

-Barry