Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp1227536lqh; Mon, 6 May 2024 00:28:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW7nV0xc3pCw7bq7ZBZtX9GxaO3Xb/10TkHApDgRrfSPjiyY5vsdhIX++OzEVz88DG8ydbuRoq4/Do+K9zVYOCxhU2tm90LLaQmNTpPGQ== X-Google-Smtp-Source: AGHT+IH2t7i+x20oSZRuSwygmzOtXR40AWdYJ51tpzIx1O9QsHee1Zk16+Ij0uQz1QBqFrSO3un/ X-Received: by 2002:a9d:664e:0:b0:6ef:9594:2c05 with SMTP id q14-20020a9d664e000000b006ef95942c05mr10423941otm.1.1714980491211; Mon, 06 May 2024 00:28:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714980491; cv=pass; d=google.com; s=arc-20160816; b=RXGoP4hoz8RYWLH6F+QjXc2pce4t1scllhwsTYfJ6hm//DgUbgMVwWSdV1zAeZ+ei4 +XCg0PqpfGY/leBwf3CJNTlzwtcGiDqRKdr7sqOQhNWYW7oh7sV6uCqOgoYUlFQA8iZV M6O1XKi8DzTa0LgUQfHOZ3LtWZf29BeaFSyEu8+p5PctRvuLKiCJo4hXW95h0NFHFelH lQADEeDhylzlfJ1xdBuauWLhjtLl+y6hD1krZf1M0jPt7B7tKP9HbNgu9ZxKtRmQ+vyU 0dyLorU2H07kOwl2aFpwGvbaQRCqICiWPvRskDJE7fz1gAac5+eeII36Ap/hqTenuiNF mhLw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature:dkim-filter; bh=DCx0YG4MBsCpVEaSdxyjBHSG2FllCh5usfBlyffo6Cg=; fh=MGVBWfkBuu54U4lB+SUy7faYE1bP9UjkJznYXm51YWs=; b=MPj9T0S9LyvaK4inrMjjAuhUF0v61TzLa7AmPuvVVYpswDKRvs6Ddm3xRCTE3jt/Y7 4N71suKwQGI5E0vUlOYfGjHcn6cWWUb4UzcCkDgVgZCb6d/i8Z3M9NPO+NKgoWEQa8VR sRTXS7+7ogQkgPHyOSrAuGLJIl34onIifERuIXbttz9QCsK3vr7ItMgIosutuhhViIt3 kTI07gG4nClw2vBs7bDcm9+TBzC4OLb5NHvc+1t16gVuN2MzI/228ofHt0Ao1J82ZxmS 9mnyTvfUMN2ALWrgVdTm6dxOW4qIQY/HUwDAEisMabG5TUVtBruTUy6RfON00QPfl97y ZbAA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@perex.cz header.s=default header.b=FpEaWNlW; arc=pass (i=1 spf=pass spfdomain=perex.cz dkim=pass dkdomain=perex.cz dmarc=pass fromdomain=perex.cz); spf=pass (google.com: domain of linux-kernel+bounces-169412-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-169412-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=perex.cz Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id s72-20020a63774b000000b0061a949b8296si7526806pgc.168.2024.05.06.00.28.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 00:28:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-169412-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@perex.cz header.s=default header.b=FpEaWNlW; arc=pass (i=1 spf=pass spfdomain=perex.cz dkim=pass dkdomain=perex.cz dmarc=pass fromdomain=perex.cz); spf=pass (google.com: domain of linux-kernel+bounces-169412-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-169412-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=perex.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C905F281CE0 for ; Mon, 6 May 2024 07:28:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0B023128374; Mon, 6 May 2024 07:28:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=perex.cz header.i=@perex.cz header.b="FpEaWNlW" Received: from mail1.perex.cz (mail1.perex.cz [77.48.224.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD99C43ADC; Mon, 6 May 2024 07:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=77.48.224.245 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714980485; cv=none; b=Jr2CVRbn5z8rKomhlnxk+2eEY+D8Zn3zKGOomV2WycgTuz8Mr+fVINWHaiQP/JiXxJHvwL3WeA4dLPhspvoqzeuQYiBq66nAYcVeq36vXxbgCVEKP9Ski6VHBcwUUgWA078YFI9I3iLl2DGrxxhBmSX/7JxqYMczQn8ca2/oBtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714980485; c=relaxed/simple; bh=Dl9Fp7DzcxJNL16+TIj68l+FgYDBaVnnxi1ZuOdNUdk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SAKN5DKDcG7Q3/md6RKU00nh7bQMZ0MNDlaAnuZbx/pSPQuR/ZAy+s7yXEw2YsfQqtwJ8hXRcGW9OG/JYyzkDGvajKAVo0JL8yVGv6L+8DduxRZqKf6QOhv7YfQ1FqNjqYvBmpq3aw/xmP3dY56YUqOPFCt7qgsy/ienXdSobmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=perex.cz; spf=pass smtp.mailfrom=perex.cz; dkim=pass (1024-bit key) header.d=perex.cz header.i=@perex.cz header.b=FpEaWNlW; arc=none smtp.client-ip=77.48.224.245 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=perex.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=perex.cz Received: from mail1.perex.cz (localhost [127.0.0.1]) by smtp1.perex.cz (Perex's E-mail Delivery System) with ESMTP id 97BF243F7; Mon, 6 May 2024 09:27:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.perex.cz 97BF243F7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perex.cz; s=default; t=1714980471; bh=DCx0YG4MBsCpVEaSdxyjBHSG2FllCh5usfBlyffo6Cg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FpEaWNlWK8RYXdkgtgDwNNTm3IFDmCm4qXejKTLUB0TlR4qyETqu8gzJVotF9jksv iDHpcSmlRaEE95MOpLF5uI0cwi60N/AsYSpDNw8mcGtf6shKp1KvXEP+2NMdjF6M6m xIwuh+5wplUhcIv/7xUGNObKOtMd3h+PaNEoEYj0= Received: from [192.168.100.98] (unknown [192.168.100.98]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: perex) by mail1.perex.cz (Perex's E-mail Delivery System) with ESMTPSA; Mon, 6 May 2024 09:27:40 +0200 (CEST) Message-ID: Date: Mon, 6 May 2024 09:27:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree() Content-Language: en-US To: Takashi Iwai , John Hubbard Cc: Shuah Khan , Mark Brown , Takashi Iwai , Ivan Orlov , linux-sound@vger.kernel.org, Valentin Obst , linux-kselftest@vger.kernel.org, LKML , llvm@lists.linux.dev References: <20240505210824.55392-1-jhubbard@nvidia.com> <875xvrif0c.wl-tiwai@suse.de> From: Jaroslav Kysela Autocrypt: addr=perex@perex.cz; keydata= xsFNBFvNeCsBEACUu2ZgwoGXmVFGukNPWjA68/7eMWI7AvNHpekSGv3z42Iy4DGZabs2Jtvk ZeWulJmMOh9ktP9rVWYKL9H54gH5LSdxjYYTQpSCPzM37nisJaksC8XCwD4yTDR+VFCtB5z/ E7U0qujGhU5jDTne3dZpVv1QnYHlVHk4noKxLjvEQIdJWzsF6e2EMp4SLG/OXhdC9ZeNt5IU HQpcKgyIOUdq+44B4VCzAMniaNLKNAZkTQ6Hc0sz0jXdq+8ZpaoPEgLlt7IlztT/MUcH3ABD LwcFvCsuPLLmiczk6/38iIjqMtrN7/gP8nvZuvCValLyzlArtbHFH8v7qO8o/5KXX62acCZ4 aHXaUHk7ahr15VbOsaqUIFfNxpthxYFuWDu9u0lhvEef5tDWb/FX+TOa8iSLjNoe69vMCj1F srZ9x2gjbqS2NgGfpQPwwoBxG0YRf6ierZK3I6A15N0RY5/KSFCQvJOX0aW8TztisbmJvX54 GNGzWurrztj690XLp/clewmfIUS3CYFqKLErT4761BpiK5XWUB4oxYVwc+L8btk1GOCOBVsp 4xAVD2m7M+9YKitNiYM4RtFiXwqfLk1uUTEvsaFkC1vu3C9aVDn3KQrZ9M8MBh/f2c8VcKbN njxs6x6tOdF5IhUc2E+janDLPZIfWDjYJ6syHadicPiATruKvwARAQABzSBKYXJvc2xhdiBL eXNlbGEgPHBlcmV4QHBlcmV4LmN6PsLBjgQTAQgAOBYhBF7f7LZepM3UTvmsRTCsxHw/elMJ BQJbzXgrAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEDCsxHw/elMJDGAP/ReIRiRw lSzijpsGF/AslLEljncG5tvb/xHwCxK5JawIpViwwyJss06/IAvdY5vn5AdfUfCl2J+OakaR VM/hdHjCYNu4bdBYZQBmEiKsPccZG2YFDRudEmiaoaJ1e8ZsiA3rSf4SiWWsbcBOYHr/unTf 4KQsdUHzPUt8Ffi9HrAFzI2wjjiyV5yUGp3x58ZypAIMcKFtA1aDwhA6YmQ6lb8/bC0LTC6l cAAS1tj7YF5nFfXsodCOKK5rKf5/QOF0OCD2Gy+mGLNQnq6S+kD+ujQfOLaUHeyfcNBEBxda nZID7gzd65bHUMAeWttZr3m5ESrlt2SaNBddbN7NVpVa/292cuwDCLw2j+fAZbiVOYyqMSY4 LaNqmfa0wJAv30BMKeRAovozJy62j0AnntqrvtDqqvuXgYirj2BEDxx0OhZVqlI8o5qB6rA5 Pfp2xKRE8Fw3mASYRDNad08JDhJgsR/N5JDGbh4+6sznOA5J63TJ+vCFGM37M5WXInrZJBM3 ABicmpClXn42zX3Gdf/GMM3SQBrIriBtB9iEHQcRG/F+kkGOY4QDi4BZxo45KraANGmCkDk0 +xLZVfWh8YOBep+x2Sf83up5IMmIZAtYnxr77VlMYHDWjnpFnfuja+fcnkuzvvy7AHJZUO1A aKexwcBjfTxtlX4BiNoK+MgrjYywzsFNBFvNeCsBEACb8FXFMOw1g+IGVicWVB+9AvOLOhqI FMhUuDWmlsnT8B/aLxcRVUTXoNgJpt0y0SpWD3eEJOkqjHuvHfk+VhKWDsg6vlNUmF1Ttvob 18rce0UH1s+wlE8YX8zFgODbtRx8h/BpykwnuWNTiotu9itlE83yOUbv/kHOPUz4Ul1+LoCf V2xXssYSEnNr+uUG6/xPnaTvKj+pC7YCl38Jd5PgxsP3omW2Pi9T3rDO6cztu6VvR9/vlQ8Z t0p+eeiGqQV3I+7k+S0J6TxMEHI8xmfYFcaVDlKeA5asxkqu5PDZm3Dzgb0XmFbVeakI0be8 +mS6s0Y4ATtn/D84PQo4bvYqTsqAAJkApEbHEIHPwRyaXjI7fq5BTXfUO+++UXlBCkiH8Sle 2a8IGI1aBzuL7G9suORQUlBCxy+0H7ugr2uku1e0S/3LhdfAQRUAQm+K7NfSljtGuL8RjXWQ f3B6Vs7vo+17jOU7tzviahgeRTcYBss3e264RkL62zdZyyArbVbK7uIU6utvv0eYqG9cni+o z7CAe7vMbb5KfNOAJ16+znlOFTieKGyFQBtByHkhh86BQNQn77aESJRQdXvo5YCGX3BuRUaQ zydmrgwauQTSnIhgLZPv5pphuKOmkzvlCDX+tmaCrNdNc+0geSAXNe4CqYQlSnJv6odbrQlD Qotm9QARAQABwsF2BBgBCAAgFiEEXt/stl6kzdRO+axFMKzEfD96UwkFAlvNeCsCGwwACgkQ MKzEfD96Uwlkjg/+MZVS4M/vBbIkH3byGId/MWPy13QdDzBvV0WBqfnr6n99lf7tKKp85bpB y7KRAPtXu+9WBzbbIe42sxmWJtDFIeT0HJxPn64l9a1btPnaILblE1mrfZYAxIOMk3UZA3PH uFdyhQDJbDGi3LklDhsJFTAhBZI5xMSnqhaMmWCL99OWwfyJn2omp8R+lBfAJZR31vW6wzsj ssOvKIbgBpV/o3oGyAofIXPYzhY+jhWgOYtiPw9bknu748K+kK3fk0OeEG6doO4leB7LuWig dmLZkcLlJzSE6UhEwHZ8WREOMIGJnMF51WcF0A3JUeKpYYEvSJNDEm7dRtpb0x/Y5HIfrg5/ qAKutAYPY7ClQLu5RHv5uqshiwyfGPaiE8Coyphvd5YbOlMm3mC/DbEstHG7zA89fN9gAzsJ 0TFL5lNz1s/fo+//ktlG9H28EHD8WOwkpibsngpvY+FKUGfJgIxpmdXVOkiORWQpndWyRIqw k8vz1gDNeG7HOIh46GnKIrQiUXVzAuUvM5vI9YaW3YRNTcn3pguQRt+Tl9Y6G+j+yvuLL173 m4zRUU6DOygmpQAVYSOJvKAJ07AhQGaWAAi5msM6BcTU4YGcpW7FHr6+xaFDlRHzf1lkvavX WoxP1IA1DFuBMeYMzfyi4qDWjXc+C51ZaQd39EulYMh+JVaWRoY= In-Reply-To: <875xvrif0c.wl-tiwai@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06. 05. 24 9:19, Takashi Iwai wrote: > On Sun, 05 May 2024 23:08:24 +0200, > John Hubbard wrote: >> >> dump_config_tree() is declared to return an int, but the compiler cannot >> prove that it always returns any value at all. This leads to a clang >> warning, when building via: >> >> make LLVM=1 -C tools/testing/selftests >> >> Furthermore, Mark Brown noticed that dump_config_tree() isn't even used >> anymore, so just delete the entire function. >> >> Cc: Mark Brown >> Signed-off-by: John Hubbard > > Thanks, applied now. This function is nice for debugging. I'd prefer to keep it with the fix. Jaroslav -- Jaroslav Kysela Linux Sound Maintainer; ALSA Project; Red Hat, Inc.