Date: Tue, 29 Jan 2008 10:37:05 -0800
From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       mike.miller@hp.com, k-ueda@ct.jp.nec.com, j-nomura@ce.jp.nec.com
Subject: Re: kernel BUG at drivers/block/cciss.c:1260! (with recent
	linux-2.6  tree)
Message-ID: <20080129183705.GL12400@plap3.qlogic.org>
References: <20080129175426.GJ12400@plap3.qlogic.org> <20080129180242.GZ15220@kernel.dk> <20080129180537.GA15220@kernel.dk> <20080129182217.GK12400@plap3.qlogic.org> <20080129182833.GG15220@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080129182833.GG15220@kernel.dk>
Organization: QLogic Corporation
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1717
Lines: 44

On Tue, 29 Jan 2008, Jens Axboe wrote:

> > Here the final snippet that was logged:
> > 
> > [   12.724997] input: USB HID v1.01 Mouse [HP Virtual Keyboard] on usb-0000:01:04.4-1
> > [   12.728971] usbcore: registered new interface driver usbhid
> > [   12.732866] drivers/hid/usbhid/hid-core.c: v2.6:USB HID core driver
> > [   12.741172] TCP cubic registered
> > [   12.744506] NET: Registered protocol family 1
> > [   12.744884] NET: Registered protocol family 17
> > [   12.749217] Freeing unused kernel memory: 228k freed
> > [   12.885823] cciss rq: dev cciss/c0d0: type=2, flags=104c8
> > [   12.888929] 
> > [   12.888930] sector 6510615555426900570, nr/cnr 0/0
> > [   12.892895] bio ffff81042f130730, biotail ffff81042f130730, buffer 0000000000000000, data 0000000000000000, len 0
> > [   12.896895] cdb: 12 00 00 00 fe 00 00 00 00 00 00 00 00 00 00 00 
> 
> Ah ok, I see the problem... cciss is overriding the data_len for
> BLOCK_PC requests, hence it does not complete them properly. Hmm. Does
> this work?
> 
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index ef50068..b6fa52e 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -2524,7 +2524,6 @@ after_error_processing:
>  		resend_cciss_cmd(h, cmd);
>  		return;
>  	}
> -	cmd->rq->data_len = 0;
>  	cmd->rq->completion_data = cmd;
>  	blk_complete_request(cmd->rq);
>  }


Things look good so far -- with the patch above I can finally boot the
machine.

Thanks, av
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/