Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp1268428lqh; Mon, 6 May 2024 02:20:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUxC4l89JHzaPwLlWLWv74SNymy/ylcF1Vr+RbFgREkzGh0dXuYGJLQIPIedg8lPAvstRI8QHHs17B9pehzsVnP20fruEsUSjQPdtT1hg== X-Google-Smtp-Source: AGHT+IEPsZTW3DpyylmCEtHcGHIimBFtUKQIwLFpIdgfDeGw8dpQDg4RrQ7do+tP3m7ARaz/8fef X-Received: by 2002:a25:2045:0:b0:dcd:5187:a033 with SMTP id g66-20020a252045000000b00dcd5187a033mr9367084ybg.2.1714987246921; Mon, 06 May 2024 02:20:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714987246; cv=pass; d=google.com; s=arc-20160816; b=PJC5USu1r6GtXupcS1tn8wvUj1pkriao0CFbdTrn5eGGCd18mWV7k3uVGykLdplcrw WmvXTQgmmrIll40/bWKtW2mUZ75RvsqQXzsRysHgRvTClmThysHFKNs1RHXe/K8CO22O KQvyhhxE6CgWRH2JuRorqKiiBTqHMf1fR0yq/l7/CXb62VKKVCUIluK+tk7KFuJas+k8 JnfMm+512ptrPhNlOsjl2WBdcsxwZFMThXNbIyUa/8cVhAl0mG6C6M827RtqU61Gw5dt YJ3t2S1gj/+Q6kwBNRrv49Thb4omBwUF2qi42nNFeckacbNcmnGuJRh3NA+7p8z9F3au VLWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=c538WmiDQ+04C3OysjuU5lMSHSzNsqxg2fLUOmugq/0=; fh=TBtmvFgTr1m6RYuRRuv/kKQdeTMWyWZi26SVlj2cvNs=; b=W9D8yPrblhdol39RSVaKTjgVmOoTziOwsWGHJh9Fx/SoWqa/L61trxBKtqJfbp/H/X PmO2fRy4O5qoI9NLJmrVysBIZWkrQLM2YAS6PfBQm3z8yaEMbzqLM1NSlJN7JIr0jdDt 1vdiut7JetKaSt2SknE51xVu8bssK9qGwJq7RQrBQLKRrJ9ynh3PqH3dCLvi0Na8FoWy QT/4xVU2HvyW6JcyR1Jk8S/aVphL/CMcEfk3fLHWwVa4CzX2PipWXZbzuBoLzemudOnG rYnzHLu2THzWsIE2ZFd0nn349/6x7eLbimoS4R+rdqLhMWa4XKDk1CwKo4E7SYiR6WAA GSAQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@fiberby.net header.s=202008 header.b=bia3kAVZ; arc=pass (i=1 spf=pass spfdomain=fiberby.net dkim=pass dkdomain=fiberby.net dmarc=pass fromdomain=fiberby.net); spf=pass (google.com: domain of linux-kernel+bounces-169563-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-169563-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fiberby.net Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t19-20020ac85893000000b0043ab530ba30si9302452qta.257.2024.05.06.02.20.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 02:20:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-169563-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@fiberby.net header.s=202008 header.b=bia3kAVZ; arc=pass (i=1 spf=pass spfdomain=fiberby.net dkim=pass dkdomain=fiberby.net dmarc=pass fromdomain=fiberby.net); spf=pass (google.com: domain of linux-kernel+bounces-169563-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-169563-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fiberby.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9D6E51C21E56 for ; Mon, 6 May 2024 09:20:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 569231422D9; Mon, 6 May 2024 09:20:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="bia3kAVZ" Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACF091422AC; Mon, 6 May 2024 09:20:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714987238; cv=none; b=mqM+zGdxW2++J7mrOmVtEcNPDQfa19STGuONf3oBw80/6S3wH2+bpsOgOgjXNli3aFoauj8HzJSgcI+Z2dDaVwy4eILksW0XdnMzDnu6jKix5CPTPlbsVmrvow5qCOI1pkfuK22AdxgeakUm086DFvt221tEFInB8zAN2S4OVos= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714987238; c=relaxed/simple; bh=PQytnEGjJh8JMaq9PKzKuAqWRJ/iFQlt/JLPHpUp8rA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=krvGlg9y0uCehSeG7iOjwN1ZtmeFwjEQpwRFXBIzcWlSYXdN6YVp2WFQdUfzWlejzqHIm053/19P+WYHlAGhT8Hng/rf3ymYZxKMp485/h/bDKYOd/ReevteRcf5x7gZJya9QErkqArglb5+5C+qK0JyxVuurdo4KdEXDFidsIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=bia3kAVZ; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id B0EC7600A2; Mon, 6 May 2024 09:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1714987232; bh=PQytnEGjJh8JMaq9PKzKuAqWRJ/iFQlt/JLPHpUp8rA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bia3kAVZKNL0yRW4zOVPbcm2km86aipI/gdtPm/xKmr9mQToz+ytRZFkNNHAaADBH 3lZ9LZ84NBBST9D+D1WkQL58T9g8u39Ig6twwGyJCHxxGMoCcYEO/t5eH+WmuBbBim vtsqzpP6AQwrgRFG9hPA+WU1GV3Jkni4XSOXJv8n2iDsDrWXPthavHFKBojokDL4ku LSfY/nhKwfsqx5z2spvVTsGeJ91bUbw92uYp4LvTz3w7b9cVx7F+/GmZuQpr2+0QP2 UPhh2T0Tjp9IuvsDrqVB81Ow6PDNiKn+dlAHcF+anhCOHDzwXpoeZykYZi4hd/CFUj ILfGjYezIjS3A== Received: from [127.0.0.1] (localhost [127.0.0.1]) by x201s (Postfix) with ESMTP id 00A5B20146D; Mon, 06 May 2024 09:20:27 +0000 (UTC) Message-ID: Date: Mon, 6 May 2024 09:20:27 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [PATCH iwl-next] iavf: flower: validate control flags To: "Buvaneswaran, Sujai" , "intel-wired-lan@lists.osuosl.org" Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Eric Dumazet , "Nguyen, Anthony L" , Jakub Kicinski , Paolo Abeni , "David S. Miller" References: <20240416144325.15319-1-ast@fiberby.net> Content-Language: en-US From: =?UTF-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Sujai, Thank you for testing. On 5/6/24 5:30 AM, Buvaneswaran, Sujai wrote: > HW offload is not directly supported on the iavf VF interface. VF traffic can be offloaded only through VF port representor device which uses ice driver. Again, there is a awful lot of flower code in iavf_main.c, if it's not supported. Try with: ethtool -K $iface hw-tc-offload on tc qdisc add dev $iface ingress tc filter add dev $iface protocol ip parent ffff: prio 1 flower dst_mac 3c:fd:fe:a0:d6:70 ip_flags frag skip_sw hw_tc 1 -- Best regards Asbjørn Sloth Tønnesen Network Engineer Fiberby - AS42541