Received-SPF: pass (google.com: domain of linux-kernel+bounces-169568-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <071499ba-16b3-4c79-8b4b-95c03faf7493@intel.com>
Date: Mon, 6 May 2024 17:25:44 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v10 26/27] KVM: nVMX: Enable CET support for nested guest
To: Sean Christopherson <seanjc@google.com>
CC: <pbonzini@redhat.com>, <dave.hansen@intel.com>, <x86@kernel.org>,
	<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<peterz@infradead.org>, <chao.gao@intel.com>, <rick.p.edgecombe@intel.com>,
	<mlevitsk@redhat.com>, <john.allen@amd.com>
References: <20240219074733.122080-1-weijiang.yang@intel.com>
 <20240219074733.122080-27-weijiang.yang@intel.com>
 <ZjLO8FsnJ7NgED0G@google.com>
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZjLO8FsnJ7NgED0G@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3Fwdnh6ZnpPTnVyaEJLdFJRU0xYbXdkV2pLZ21PN0RWQ3RoT01rSFRBUTdh?=
 =?utf-8?B?cWtMZmtQWHpwcEQvazNMbUdPMWNtNG82VS9IUHJDUnQvOGs2TzZSMVdQMnE0?=
 =?utf-8?B?MjJzcnl3U0xuQ1UvM2k2RkVXNEQvVXNLWUJyemxvT3Z4aFhIMUJRS2Vleldz?=
 =?utf-8?B?L1VXVmVIeDlFRXNyTXNNSVpYcXIzeU4wY01DdWFHUHJuRysycUI1WHpsNm9M?=
 =?utf-8?B?Q25ZeEc4dDlsbGo0MC9zMjFzMkt4b2dFbExMY2U4Q3ZRSnoxQ0xhR3JWQUlS?=
 =?utf-8?B?Y20yTWZuRy8wMitPNElLajdIcjBJVWwyd0N1NUVGS04rSDYzV0dGTjV2ajlZ?=
 =?utf-8?B?cjJWaVlZNGxLV1dGZlV0bmhPa2ZZUkhSTTcwNTJ6R1poQmJBR0t2cTFUVEtM?=
 =?utf-8?B?YlY2UGJIcmF1STU4Zy9ud0RCSUhVcUQzSmcybW84QWMvck8yNmFwV25ZeGdS?=
 =?utf-8?B?MzEvWEUxaStIUTJXTDJWQ2phN3VSZ25MUXYvdGQ4TnZ1M2grZXE0c0FhYlhZ?=
 =?utf-8?B?VnRqRzJLQ1hEUXZmNWM1Rm02YTVNMGNueWNXcFJrUkpnbDZZNzJ2VnFnbFJ4?=
 =?utf-8?B?MHFvRVZ0ai80K2NGUXBtbWl2UTMzTW1OeFgrbFkvQkZ0dVJNbEMwb3lEakMx?=
 =?utf-8?B?MkxrbDVMeDVERitIWjhXQWlOcW1ic2ZtUERZZkdkY1dUTTk5akoySm9xWUNR?=
 =?utf-8?B?V1ZqTWI4Y2crOTRGb2hwWGtmM3M0UVJ2OEJRT0VqQmpNMVdTVHFQVEZPWWlN?=
 =?utf-8?B?N2Q2eE80UXZIaVF0dWxxRHp5Zys2clFaSW85Z1A2UTI1M3greDJWWW9kWWUr?=
 =?utf-8?B?bWRJOWxSYWd4dWJCTGV0bTd5VkZzanM5N2ZTK3JKVFZBOFgxUDJ3WWRlOThE?=
 =?utf-8?B?MnJBMXJSbE5kZnNMOENaSkgvNDc2M2xUQTlDWkgxeUZUQ0tWRHBVTVBJWWJo?=
 =?utf-8?B?SVZoOEJKdk80NUdlcC9oSURja3NlVWtBWnVhbDk3WWhNVG1zcXIyd0tySFhS?=
 =?utf-8?B?YWFjSHFXdnZjbUpwUnNhV0FqMzlDQkNTbEhZU1RyNloyaTJpSHI3UG1wNjRZ?=
 =?utf-8?B?RXJvQXJTRjNwQlQ4Ry9CU1NPZlNIaUo5alI2N09qWVlLalZHRzAzemVQMDJp?=
 =?utf-8?B?SHA5Vk5lREJYaHlWTmNxTmNodWxrM2J6ZGVRTEUvYTh0Nk44cS9wRXVyYzI1?=
 =?utf-8?B?S1RWWVE5OUcwOFpQeXhQVzZVbVhyUDBzOFNYcmloeVpPU2NBNWwrRGVvbGdM?=
 =?utf-8?B?SmZVVVJPN2djeHBROVdPZTVVQUtveTdSWnlHZWtvemlVSVF4K0Z5T2hPckhM?=
 =?utf-8?B?VlpVYzhmbGlpRzZydk5ISHdlcUZZTmM2bWtPSFhzVWpoMFpyelZJdXpOVVUx?=
 =?utf-8?B?dFFyQzlnU3kxWEExK0VjZlJyYWppS2thcS9JY1ZnSVY1RlF4cWJuNnN2UXpx?=
 =?utf-8?B?bTNmZE13Mm9VY1lHUDFMRHNkU3JUV0VjY2swMzNVWkttdmVkdkdiNjFjVS92?=
 =?utf-8?B?UTdlQkhqWUZYRUhLcGZUZFFPMkR4VWF0OXJIWFBnTVhUSTc5RWhQTVhJVTVZ?=
 =?utf-8?B?Um16VW5URFovSjBlYlN0STk2b1NnVTRFUFZYd0kzTHplT0MwRENmVm0zM0Uy?=
 =?utf-8?B?QjdyUlo1R2RKcG13RXFMcWxrY3NnMG1qbGxsdHpENkZndnNMRzh4VC9yYmM2?=
 =?utf-8?B?eWpRT2tTRlNsaWx0bUQzWDNLZ2dSUzJNME9GRmQ2ck5XYmNsTVJ4M3lmdFRU?=
 =?utf-8?B?cnJLRDFPM0dBWXExd0ZWZDNIeEY0ejl3ZjBxUXhveUx2RE1PUnhLc1BoT1RV?=
 =?utf-8?B?OVZPVEl3Y2pQRXN3ei9iRGp5TzJ4TU9idStxU0tpQWtEQUpvLytSUU15UXpi?=
 =?utf-8?B?YjFnK3VtdnZHMlF5cmNCWEI5d2lMa3lSSWJZYkYwMEdvckxNUkwzOFVBMCt6?=
 =?utf-8?B?Yzh2UVFjZVlHc1h6b3k5enIxakNRczBqTWJpcUZXeW9CcFE3QWFMSVdSM1ov?=
 =?utf-8?B?eUVzZSs1ZUpQNDFHc21Ta25reGtrcjZsZTNWSG1ManBZQ3NNbXpZZndvcVpn?=
 =?utf-8?B?QzZIT3FDU1lwKzNwV2thWGpGQ2psSkZMUUZBM1BwR0tLdHllR0hzSnZrVzRj?=
 =?utf-8?B?aFBISStXaGwrQk1xN2c0dC9LWTYzVW1aU3NZMy9STkJMekZ1VGdIM0twQ2dH?=
 =?utf-8?B?NlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d66707ff-1dcf-4721-071a-08dc6dae86dc
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 09:25:53.7546
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KBcMeVo6QBxSQ0QBJ4J53xhz7T2gbC/GlHwqIwhFKtlwzs7NOPS9g1Bnm9kb7k9hFW8oiUuF9u3QybH9ykk+ww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7248
X-OriginatorOrg: intel.com

On 5/2/2024 7:23 AM, Sean Christopherson wrote:
> On Sun, Feb 18, 2024, Yang Weijiang wrote:
>> @@ -2438,6 +2460,30 @@ static void prepare_vmcs02_early(struct vcpu_vmx *vmx, struct loaded_vmcs *vmcs0
>>   	}
>>   }
>>   
>> +static inline void cet_vmcs_fields_get(struct kvm_vcpu *vcpu, u64 *ssp,
>> +				       u64 *s_cet, u64 *ssp_tbl)
>> +{
>> +	if (guest_can_use(vcpu, X86_FEATURE_SHSTK)) {
>> +		*ssp = vmcs_readl(GUEST_SSP);
>> +		*s_cet = vmcs_readl(GUEST_S_CET);
>> +		*ssp_tbl = vmcs_readl(GUEST_INTR_SSP_TABLE);
>> +	} else if (guest_can_use(vcpu, X86_FEATURE_IBT)) {
>> +		*s_cet = vmcs_readl(GUEST_S_CET);
>> +	}
> Same comments about accessing S_CET, please do so in a dedicated path.

Will change it, thanks!

>
>> +}
>> +
>> +static inline void cet_vmcs_fields_put(struct kvm_vcpu *vcpu, u64 ssp,
>> +				       u64 s_cet, u64 ssp_tbl)
> This should probably use "set" instead of "put".  I can't think of a single case
> where KVM uses "put" to describe writing state, e.g. "put" is always used when
> putting a reference or unloading state.

Yes, "put" is not proper in this case, will change it.


>
>> +{
>> +	if (guest_can_use(vcpu, X86_FEATURE_SHSTK)) {
>> +		vmcs_writel(GUEST_SSP, ssp);
>> +		vmcs_writel(GUEST_S_CET, s_cet);
>> +		vmcs_writel(GUEST_INTR_SSP_TABLE, ssp_tbl);
>> +	} else if (guest_can_use(vcpu, X86_FEATURE_IBT)) {
>> +		vmcs_writel(GUEST_S_CET, s_cet);
>> +	}
> And here.

OK.