Received-SPF: pass (google.com: domain of linux-kernel+bounces-169569-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <98fab4fd-e7a7-4b1d-aa8c-4c49c4dc7e66@intel.com>
Date: Mon, 6 May 2024 17:26:32 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v10 27/27] KVM: x86: Don't emulate instructions guarded by
 CET
To: Sean Christopherson <seanjc@google.com>
CC: <pbonzini@redhat.com>, <dave.hansen@intel.com>, <x86@kernel.org>,
	<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<peterz@infradead.org>, <chao.gao@intel.com>, <rick.p.edgecombe@intel.com>,
	<mlevitsk@redhat.com>, <john.allen@amd.com>
References: <20240219074733.122080-1-weijiang.yang@intel.com>
 <20240219074733.122080-28-weijiang.yang@intel.com>
 <ZjLPJzh2OmrYW-JN@google.com>
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZjLPJzh2OmrYW-JN@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2tWWE5Ib2Y5RkowazNGNWp6M3dabDgzeDY1b0pGbm5iS2dWd3YwTnBYaVZl?=
 =?utf-8?B?MDhSdVFQa3VaQ3ZHREVsMTNXeWRldXp3TWJ0WVJMbDlRR2ZiS1NvRjM5MFVo?=
 =?utf-8?B?d3MzRFA5L0s2dnBsMDczdG1tVzZiSk52aVdOUFk3MEdGUnk3YWVaazdjSGhv?=
 =?utf-8?B?Vi9HMHBKdEdadjVxR01hL0NJTEorRFpPNGhHS01WVGp4cmxVTWVyVWoxZUox?=
 =?utf-8?B?aEs4clRxTExPOExzeFh4V2JILzY0TEtzaWsyVjQvbUJTUUYrN25BeENTcEdI?=
 =?utf-8?B?ZnYwb0ZLa20xS2IwbjZzcE55dk4zMEpnSG5ERmExSjRWY1h0bWtDcDNhVzJh?=
 =?utf-8?B?VW1YOUQ1Z2NnU0cwRTB6N09UWnNzNXVzQytlY2R6MUNpQVVVa1IwNUkvaEVK?=
 =?utf-8?B?NXI5Uk1TRmsxZ3JqdVhmV2hUY3pTa29qQ1ZIWjJITWd4MnlyWGJRMGc0TVRK?=
 =?utf-8?B?ayt4NVhyTEQyYlBpZ1JXTjNMYnBMQ2dZb0xMT3QyU1BtdS8zUGpqOXpRMGNH?=
 =?utf-8?B?djA1RWx1UVUwejBGYURWanpmcHg3TUQwS0NrOTJLRWVxRkZSVDlmNlIzcEhz?=
 =?utf-8?B?bE5KUm9Tb1pHYVl2K2V4dVZXdHltRFBRcHdJQ2hvSEFTM0srVGk1WVltelNa?=
 =?utf-8?B?eHhUbzVISlBLcmhHV1kwTzRQRVp4UGxvWnZhR0NUZXNRMDNvMFRWK3ZBVDlw?=
 =?utf-8?B?RVVSYmFtZzhGdnZrUWt6d2xZQlBDblp3T0RpZHI4YzRjRmVxMCtoUlNVR3Nh?=
 =?utf-8?B?VXIvbVRVQWhzNllqdnc3d0k0RWVqVHNkUmJXSTl0VnNhVnZWRjl1VDZRd3Er?=
 =?utf-8?B?ajZnUUxMOU01QXd6b295aVFBaVhEZnlsYlpseUtNRWg1VDhCVEZkSUNpeTNq?=
 =?utf-8?B?WEU4M050VFpHcU5Qc1J3RWNnU0FEWEtIMTR3b0Ryd2ZYalBnMVY0ZnJid2xK?=
 =?utf-8?B?Q2ZBT1VlazdvL3lScXMyd0E5ekRSZzQ0UzdQQnhRMEpITmVpRnVDKzBwTSsy?=
 =?utf-8?B?dG1kTDJVYWx1V0E5OU9vNVJ0ZmpLZDhhR0JKZ0xUQWpaNkdPVEJEaUFGQW5n?=
 =?utf-8?B?dDljSzZWTUhFVTBUMWhGRHV3RDJnTytFNS9zamxmOGtSVGtEV1JIWWxaNHJu?=
 =?utf-8?B?azJTNmJsNk4wMnMxdDlWK2lORGp3elRxSzc5NUZOZGtNYSsyczZNTWRZVm0z?=
 =?utf-8?B?eHZsSU9OOWV1ZzU0cEZCbXNIRDVCVG52Y2xtY1EwZW9jSk42bGMzVVdPNDA4?=
 =?utf-8?B?dy9jd1FnTzNVdTNsREpvbzZIdVdlRHVxVm1FWFRTU0Z6anVMZGxvTDgrbTJ0?=
 =?utf-8?B?MCszTzhTSE9WcUE4VnF3S01KcmtlNk02eVlkYkcyTUVLdlA5NWJER0xKNmxW?=
 =?utf-8?B?S0ZDaWVocG16SE1uYXVFNzJUdFJXTVRDd1h3V2ViMXRoR1c0YkFweXcvcEM1?=
 =?utf-8?B?Mzh2UVBmcUlPeGJoams1Sm9pcDZpVGFTSDhuQ1A1WVlrWWtSQmY3aWlheXB0?=
 =?utf-8?B?Ky9jMDBRYVhCZjg5NFVpNTVBZ1lwd0pFUVZUQXNJcG9lUGdQbk1WNld1UENr?=
 =?utf-8?B?Rkg0QmpVWWlzb0xMcitDME56bVliMWJDQko1ZW1qaTlXRC95S2dvM3dyeHRK?=
 =?utf-8?B?V2FsWGkrRXB6T0svTEtxTnhZV251NnRDOHpxcmRBcTlUYzZEcHYyYWprbHRs?=
 =?utf-8?B?M3djRCtNb2wwdmFHc2FDTU5xY3lZNDFza0U4QlIveHZYZ1E5NExHR21HQlhM?=
 =?utf-8?B?MXRUZmlVV1l1bHRXUGp5dUg0TlFFc2xzMDZVZC9nSWRVenY5Snp1K2NlME9y?=
 =?utf-8?B?NjFlalpRMjVEazlPT1JwR2gvSlU1cTRUYThWd0pnS3p6aS8zRmxVR2VDME5K?=
 =?utf-8?B?ajVWSEVjVWhNd3FqZWxsZnUwUENQbXVwT0x4eGxQcnJGa1BvL1l3SER4K0VK?=
 =?utf-8?B?a1RYcnpJSnkrZkdiNmZINDNrYlBBY2s3SHFwYzFMSmowWGxRWWs5eWVjR1pY?=
 =?utf-8?B?b2xLUHQyNnlCc0FNVzlyS2dhMzBMSjY0RVhqUHMwT0R6N2Y0bDdlNGVGcUVl?=
 =?utf-8?B?SXhCTTVOTHZHdFJVODJidzdHWFBGUHIvdWhpeFUvUURvTEd6UWNaYWY4dWxa?=
 =?utf-8?B?YmE0amk2VEc0WUFpVUNFRXN2amNTa1dGdjA2b0VyVGZkeDRHRDhSS1RhZDBl?=
 =?utf-8?B?eWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f5c2ff8-cf6e-4586-592a-08dc6daea314
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 09:26:41.0153
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 29DC26MpK5xXZ3GkqHUoIax/qLHDp4bV/Ug68Ki6hK2v6sq4RzDu0dtlzs2LHc1knzPUV3ZdkSBP8ex7fBbPIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7248
X-OriginatorOrg: intel.com

On 5/2/2024 7:24 AM, Sean Christopherson wrote:
> On Sun, Feb 18, 2024, Yang Weijiang wrote:
>> Don't emulate the branch instructions, e.g., CALL/RET/JMP etc., when CET
>> is active in guest, return KVM_INTERNAL_ERROR_EMULATION to userspace to
>> handle it.
>>
>> KVM doesn't emulate CPU behaviors to check CET protected stuffs while
>> emulating guest instructions, instead it stops emulation on detecting
>> the instructions in process are CET protected. By doing so, it can avoid
>> generating bogus #CP in guest and preventing CET protected execution flow
>> subversion from guest side.
>>
>> Suggested-by: Chao Gao <chao.gao@intel.com>
>> Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>> ---
> This should be ordered before CET is exposed to userspace, e.g. so that KVM's
> ABI is well defined when CET support because usable.

Sure, thanks!