Received-SPF: pass (google.com: domain of linux-kernel+bounces-169634-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 6 May 2024 12:02:44 +0200
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Gregor Herburger <gregor.herburger@ew.tq-group.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, 
	Thomas Kopp <thomas.kopp@microchip.com>, Vincent Mailhol <mailhol.vincent@wanadoo.fr>, 
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, linux-can@vger.kernel.org, 
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, 
	linux@ew.tq-group.com
Subject: Re: [PATCH v2 0/6] can: mcp251xfd: add gpio functionality
Message-ID: <20240506-imperial-taupe-deer-9132a5-mkl@pengutronix.de>
References: <20240506-mcp251xfd-gpio-feature-v2-0-615b16fa8789@ew.tq-group.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="sse27ts3gacsw3dx"
Content-Disposition: inline
In-Reply-To: <20240506-mcp251xfd-gpio-feature-v2-0-615b16fa8789@ew.tq-group.com>


--sse27ts3gacsw3dx
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 06.05.2024 07:59:42, Gregor Herburger wrote:
> Hi all,
>=20
> The mcp251xfd allows two pins to be configured as GPIOs. This series
> adds support for this feature.
>=20
> The GPIO functionality is controlled with the IOCON register which has
> an erratum. The second patch is to work around this erratum. I am not
                  ^^^^^^
> sure if the place for the check and workaround in
> mcp251xfd_regmap_crc_write is correct or if the check could be bypassed
> with a direct call to mcp251xfd_regmap_crc_gather_write. If you have a
> better suggestion where to add the check please let me know.

Yes, better move the workaround to mcp251xfd_regmap_crc_gather_write().
I don't remember under which circumstances regmap uses the
gather_write() or the write() function.

> Patch 1-3 from https://lore.kernel.org/linux-can/20240429-mcp251xfd-runti=
me_pm-v1-0-c26a93a66544@pengutronix.de/

Nitpick: Please add your S-o-b to these patches.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--sse27ts3gacsw3dx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEUEC6huC2BN0pvD5fKDiiPnotvG8FAmY4qsEACgkQKDiiPnot
vG8TYAf9HmPQqBGVCnYkMCu3rzFuWptfpRq+2Ef2dNd1CszgbeuOuEN+Z97BRRHy
KZjA/1Y1Y5185xwvzHH3TFSBB7H1huYN2zekcIEYVGNMExwYBpEPhWzdjWc2IH6w
xdfwz21foHD50PsRk72FGmijpXN46RXBEIuV6KVbyvVVufNXxcNEz6yYcpIjgT+G
TgVmmglnNtZmzYNfUgu9gKVAdbskQkUaziTlIO/QQwXveBTOWisq/83asXFMO9Sb
u68PbNU6Z+/YKUv+OGz73a2cVV7NUcICpZPRHabgqFKmGzGFavFzb+8xXU42jPMN
zgpwVIDPo8o2euA/22RHCkb2vudCDA==
=+dVm
-----END PGP SIGNATURE-----

--sse27ts3gacsw3dx--