Received-SPF: pass (google.com: domain of linux-kernel+bounces-169642-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-437-gcad818a2a-fm-20240502.001-gcad818a2
Precedence: bulk
MIME-Version: 1.0
Message-Id: <ae56021f-1e85-4dd9-a4ca-5a8773d51ea1@app.fastmail.com>
In-Reply-To: <31f1bbfb-733c-4027-834c-98f155562941@linaro.org>
References: <20240503081125.67990-1-arnd@kernel.org>
 <20240503081125.67990-15-arnd@kernel.org>
 <31f1bbfb-733c-4027-834c-98f155562941@linaro.org>
Date: Mon, 06 May 2024 12:06:35 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Richard Henderson" <richard.henderson@linaro.org>,
 "Arnd Bergmann" <arnd@kernel.org>, linux-alpha@vger.kernel.org
Cc: "Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
 "Matt Turner" <mattst88@gmail.com>,
 "Alexander Viro" <viro@zeniv.linux.org.uk>, "Marc Zyngier" <maz@kernel.org>,
 "Linus Torvalds" <torvalds@linux-foundation.org>,
 "Paul E. McKenney" <paulmck@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/14] alpha: drop pre-EV56 support
Content-Type: text/plain

On Sat, May 4, 2024, at 17:00, Richard Henderson wrote:
> On 5/3/24 01:11, Arnd Bergmann wrote:
>>   
>> -/* Flush just one page in the current TLB set.  We need to be very
>> -   careful about the icache here, there is no way to invalidate a
>> -   specific icache page.  */
>> -
>> -__EXTERN_INLINE void
>> -ev4_flush_tlb_current_page(struct mm_struct * mm,
>> -			   struct vm_area_struct *vma,
>> -			   unsigned long addr)
>> -{
>> -	int tbi_flag = 2;
>> -	if (vma->vm_flags & VM_EXEC) {
>> -		__load_new_mm_context(mm);
>> -		tbi_flag = 3;
>> -	}
>> -	tbi(tbi_flag, addr);
>> -}
>> -
>>   __EXTERN_INLINE void
>>   ev5_flush_tlb_current_page(struct mm_struct * mm,
>>   			   struct vm_area_struct *vma,
>
> The comment being removed applied to both functions and still applies to 
> ev5_flush_tlb_current_page.  (Thus __load_new_mm_context instead of a tbi.)

Fixed now, thanks for taking a look!

     Arnd