Received-SPF: pass (google.com: domain of linux-kernel+bounces-169645-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 6 May 2024 12:10:18 +0200
From: Frederic Weisbecker <frederic@kernel.org>
To: Levi Yun <ppbuk5246@gmail.com>
Cc: anna-maria@linutronix.de, tglx@linutronix.de, Markus.Elfring@web.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] time/timgr: Fix wrong reference when level 0 group
 allocation failed
Message-ID: <ZjisiuqiR9p76YcJ@localhost.localdomain>
References: <20240505085709.82688-1-ppbuk5246@gmail.com>
 <20240506041059.86877-1-ppbuk5246@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240506041059.86877-1-ppbuk5246@gmail.com>

Le Mon, May 06, 2024 at 05:10:59AM +0100, Levi Yun a ?crit :
> When tmigr_setup_groups() failed level 0 group allocation,
> wrong reference happens on local stack array while intializing timer hierarchy.
> 
> To prevent this, Check loop condition first before initializing timer hierarchy.
> 
> Fixes: 7ee988770326 ("timers: Implement the hierarchical pull model")
> Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
> ---
> v3:
>     - Fix typo.
> 
> v2:
> 	- Modify commit message.
> 
>  kernel/time/timer_migration.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c
> index ccba875d2234..84413114db5c 100644
> --- a/kernel/time/timer_migration.c
> +++ b/kernel/time/timer_migration.c
> @@ -1596,7 +1596,7 @@ static int tmigr_setup_groups(unsigned int cpu, unsigned int node)
> 
>  	} while (i < tmigr_hierarchy_levels);
> 
> -	do {
> +	while (i > 0) {
>  		group = stack[--i];
> 
>  		if (err < 0) {
> @@ -1645,7 +1645,7 @@ static int tmigr_setup_groups(unsigned int cpu, unsigned int node)
>  				tmigr_connect_child_parent(child, group);
>  			}
>  		}
> -	} while (i > 0);
> +	}

Looks good to me. But let's wait for Anna-Maria's second look. The group setup
is not my favourite area...

Thanks.

> 
>  	kfree(stack);
> 
> --
> 2.41.0