Received-SPF: pass (google.com: domain of linux-kernel+bounces-169647-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <cbd6ed9d5be1d7112d69117a72e0cb0081f9b64b.camel@xry111.site>
Subject: Re: [PATCH] LoongArch: Update the flush cache policy
From: Xi Ruoyao <xry111@xry111.site>
To: lijun <lijun01@kylinos.cn>, chenhuacai@kernel.org, kernel@xen0n.name, 
	lvjianmin@loongson.cn, dongbiao@loongson.cn, zhangbaoqi@loongson.cn
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Date: Mon, 06 May 2024 18:17:51 +0800
In-Reply-To: <cbb24599-8b40-cd27-6ce7-215476c0ddf4@kylinos.cn>
References: <20240506092419.4109941-1-lijun01@kylinos.cn>
	 <8a8135eb0f1dc724cfbb4402dc6daf08db5b0bc7.camel@xry111.site>
	 <cbb24599-8b40-cd27-6ce7-215476c0ddf4@kylinos.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-05-06 at 18:08 +0800, lijun wrote:
> volatile prevents compiler optimization by allowing the compiler
>=20
> =C2=A0=C2=A0to reread the address value of addr every time

But why is this ever needed?  What's wrong if the compiler optimizes it?

If the problem is the compiler may optimize it to cdesc->ways * 3 *
cdesc->sets * cdesc->linesz, unknowing cdesc->ways etc may magically
change, you should use READ_ONCE(cdesc->ways) etc.

I.e. use READ_ONCE on the expression which may magically change, instead
of hacking addr.  addr won't magically change.

> =E5=9C=A8 2024/5/6 17:28, Xi Ruoyao =E5=86=99=E9=81=93:
> > On Mon, 2024-05-06 at 17:24 +0800, Li Jun wrote:
> > > fix when LoongArch s3 resume, Can't find image information
> > >=20
> > > Signed-off-by: Li Jun <lijun01@kylinos.cn>
> > > Signed-off-by: Baoqi Zhang <zhangbaoqi@loongson.cn>
> > > Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>
> > > Signed-off-by: Biao Dong <dongbiao@loongson.cn>
> > > ---
> > > =C2=A0=C2=A0arch/loongarch/mm/cache.c | 24 +++++++++++++++++++++++-
> > > =C2=A0=C2=A01 file changed, 23 insertions(+), 1 deletion(-)
> > >=20
> > > diff --git a/arch/loongarch/mm/cache.c b/arch/loongarch/mm/cache.c
> > > index 6be04d36ca07..52872fa0e5d8 100644
> > > --- a/arch/loongarch/mm/cache.c
> > > +++ b/arch/loongarch/mm/cache.c
> > > @@ -63,6 +63,28 @@ static void flush_cache_leaf(unsigned int leaf)
> > > =C2=A0=C2=A0	} while (--nr_nodes > 0);
> > > =C2=A0=C2=A0}
> > > =C2=A0=20
> > > +static void flush_cache_last_level(unsigned int leaf)
> > > +{
> > > +	u64 addr;
> > > +	int i, j, nr_nodes, way_size;
> > > +	struct cache_desc *cdesc =3D current_cpu_data.cache_leaves
> > > +
> > > leaf;
> > > +
> > > +	nr_nodes =3D loongson_sysconf.nr_nodes;
> > > +
> > > +	addr =3D CSR_DMW1_BASE;
> > > +	iocsr_write32(0x1, 0x280);
> > > +	way_size =3D cdesc->sets * cdesc->linesz;
> > > +	do {
> > > +		for (i =3D 0; i < (cdesc->ways * 3); i++) {
> > > +			for (j =3D 0; j < (cdesc->sets); j++) {
> > > +				*(volatile u32 *)addr;
> > ??? what does this line do?
> >=20
>=20

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University