Received-SPF: pass (google.com: domain of linux-kernel+bounces-169815-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Mon, 6 May 2024 15:30:11 +0300 (EEST)
To: Bjorn Helgaas <helgaas@kernel.org>
cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>, 
    Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, 
    Rob Herring <robh@kernel.org>, 
    =?ISO-8859-2?Q?Krzysztof_Wilczy=F1ski?= <kw@linux.com>, 
    Igor Mammedov <imammedo@redhat.com>, Lukas Wunner <lukas@wunner.de>, 
    Mika Westerberg <mika.westerberg@linux.intel.com>, 
    Andy Shevchenko <andriy.shevchenko@intel.com>, 
    "Rafael J . Wysocki" <rafael@kernel.org>, 
    LKML <linux-kernel@vger.kernel.org>, 
    Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2 2/7] resource: Rename find_resource() to
 find_empty_resource_slot()
In-Reply-To: <20240503204910.GA1602543@bhelgaas>
Message-ID: <1dbfc6c4-eeb1-92c1-3371-1b0afa5683ad@linux.intel.com>
References: <20240503204910.GA1602543@bhelgaas>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-665360433-1714998611=:1111"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-665360433-1714998611=:1111
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Fri, 3 May 2024, Bjorn Helgaas wrote:

> On Thu, Dec 28, 2023 at 06:57:02PM +0200, Ilpo J=C3=A4rvinen wrote:
> > Rename find_resource() to find_empty_resource_slot() to better describe
> > what the functions does. This is a preparation for exposing it beyond
> > resource.c which is needed by PCI core. Also rename the __ variant to
> > match the names.
>=20
> I wonder if "find_resource_space()" or "find_available_resource()"
> would be better than "_slot"?
>=20
> "Slot" *is* already used a few times in kernel/resource.c, but in most
> cases I think it refers to a "resource", and find_resource() basically
> returns a filled-in struct resource.
>=20
> And of course "slot" suggests something entirely different in the PCI
> context.

I picked up it from the existing usage but I've no strong opinion on=20
this so I'll just rework the series to not add more "slot" wording into=20
there.

--=20
 i.
--8323328-665360433-1714998611=:1111--