Received-SPF: pass (google.com: domain of linux-kernel+bounces-169859-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 6 May 2024 10:00:05 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
	thierry.reding@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v6 6/6] iommu/tegra241-cmdqv: Limit CMDs for guest owned
 VINTF
Message-ID: <20240506130005.GH3341011@nvidia.com>
References: <cover.1714451595.git.nicolinc@nvidia.com>
 <4ee1f867e838b90a21de16b12cf2e39ba699eab4.1714451595.git.nicolinc@nvidia.com>
 <20240430170655.GU941030@nvidia.com>
 <ZjE/ZKX7okSkztpR@Asurada-Nvidia>
 <20240501001758.GZ941030@nvidia.com>
 <ZjhUAF07Co25F/qe@Asurada-Nvidia>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZjhUAF07Co25F/qe@Asurada-Nvidia>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UfTFancoezYwJqGWaMyP5xyYi4ajBxPYHqXXXN2hYmRk/bJevuhnnpFNMgQ3?=
 =?us-ascii?Q?ugfeGBOQupC/6Txc+m5C6kdUdIKFb6cQlbvif8yM1tV1RRwPfoqCgIAaOdjL?=
 =?us-ascii?Q?zEjfbUZb6X33L+gI1juW+20WvinnInrbWz4LPVmKM2SpVm8YGNCLIEcCilVo?=
 =?us-ascii?Q?JrpKR9GrCRks+INeQ4mEC6qQ9rS/ets5Kd3Zr3kMTkZW+LxAe97nuw7EATnU?=
 =?us-ascii?Q?sckI/ZsQy8oCSprvnNY79VCAAc/SsJHjbWOdbXlcRss1jAYKBClnqR+qkeyY?=
 =?us-ascii?Q?ZgE3zgwRN718AwlHlW0bkQ50aU3J7y8gRmHSLVc28l81F+PMYG0T7wbc0/lJ?=
 =?us-ascii?Q?ugFIePOkJtOAqry28WdJW1XhIOY5F2UfwZk/yiuVgRLapqXnt2ZhQ56z3JQ4?=
 =?us-ascii?Q?fYuWErngtMpTqSnTEqqc4TAa7rfXWQPZAOZYh/6qBBgI45EH4TeC5nRtIxOZ?=
 =?us-ascii?Q?wmT0V4Cjn7Sy14SOaeWy0uZ3m1z6KWPQ0U9V15agcH6vcyYQesPFWl6+M4IW?=
 =?us-ascii?Q?nZbRiRvEZNHgvTZQHdCCRN+zVk+QiEi2+2dFMT32hM320tXxFzeESFNotVsE?=
 =?us-ascii?Q?CfyTIqDMvwjWvi6mFutuIAC+TeWlgCgTT6iEEAq7fmkdiICmE6DBPsfcwW9k?=
 =?us-ascii?Q?66t+i45sxmJx4gmLGXCXIqowlc98OdKKgyiN7uXqwFYftIJq7JoiIyI5RVdE?=
 =?us-ascii?Q?vhu+nmMYg5a3ZUuBcnfcvQXxVVGgdD9TH3c/F07qWCOWFmxYJdhM7iObumqJ?=
 =?us-ascii?Q?wgnZ9FiZ45mR7wCgzKchpybGSTU1fTjKFdZ/6oY4UVWxZg+cUvCKcqZ/QLMg?=
 =?us-ascii?Q?DbSTEvZKvKdaGtqENDq9cuZ3zER8h4czGMO52Mm49ytunlb6QXMrlKkUL/l4?=
 =?us-ascii?Q?oURNguRWx19piNuiTMAPxPSV8PNvkceoLKqU68eQdBoXZq35kRz159qL7bhY?=
 =?us-ascii?Q?SNCd/bo9c8xPL3H4KLKWcWip0qwN8m2sbUeUWzPWujxfiutWT0f8eFwKQeWp?=
 =?us-ascii?Q?OP7G0EI5gR6+Hs//fGeAfTeHiAC/UMvNGJm5BmJoRnFvSJK1YszRWOJWuEND?=
 =?us-ascii?Q?Y2Z1yYUWWFsn0lqFCao0EcPtZbNTDzR3QCihEoOFSBTTpiq9O43P9ZD9xjoy?=
 =?us-ascii?Q?tBss8/C/Nhx/XG4AW5Kw/08rw5gcf/2KT3r7dHF3J+RO2YgU7YiNJfnwKeEu?=
 =?us-ascii?Q?lKBZ4OsAoT3itb9CEbGAk/tCeicDWwal9Yvbxc2ZgM3mOfqecFd/CM+jMHr+?=
 =?us-ascii?Q?Xc+9EiNVXrLfOoc6rcvg7FKv4QxVzpfiqt4Qy65aPvdep5Ae596Ba/1Mi4M6?=
 =?us-ascii?Q?Wv96usFzKhx3BLempyp7CifYkFdu92Xkq7EIfb6Jh9X/dEQSTRaUaFgkqsZ5?=
 =?us-ascii?Q?NFhfQZlX+Y6cCr1++7omtfkHVgMtgagQ/MleauAx6dKXmGLhIJfWpYFniM2e?=
 =?us-ascii?Q?VlX976i8VxQH09KoAtYSAe6Nvc2efDJwRdvW/KSKK4EUEw1PSn4ngiV4Vcb3?=
 =?us-ascii?Q?eEm9s8gm5m8r3zv0RKLPwP9frBSthhKwkHr53chnw000NjWX11BGu81BFDeC?=
 =?us-ascii?Q?etZd0+UrApbJdbI0BN3GxdOIYmv6+Vm1wbldcDFj?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d44cd75-6fc1-4dc8-2402-08dc6dcc74e3
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 13:00:08.2767
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +pYi1rFBgS4OlpWvnaC7VkBhGtVl7tEcVhMdXE3CziZnyKPptbFPLBTSLAdRaGMf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6076

On Sun, May 05, 2024 at 08:52:32PM -0700, Nicolin Chen wrote:
> On Tue, Apr 30, 2024 at 09:17:58PM -0300, Jason Gunthorpe wrote:
> > On Tue, Apr 30, 2024 at 11:58:44AM -0700, Nicolin Chen wrote:
> > > Otherwise, there has to be a get_suported_cmdq callback so batch
> > > or its callers can avoid adding unsupported commands at the first
> > > place.
> > 
> > If you really feel strongly the invalidation could be split into
> > S1/S2/S1_VM groupings that align with the feature bits and that could
> > be passed down from one step above. But I don't think the complexity
> > is really needed. It is better to deal with it through the feature
> > mechanism.
> 
> Hmm, I tried following your design by passing in a CMD_TYPE_xxx
> to the tegra241_cmdqv_get_cmdq(), but I found a little painful
> to accommodate these two cases:
> 1. TLBI_NH_ASID is issued via arm_smmu_cmdq_issue_cmdlist(), so
>    we should not mark it as CMD_TYPE_ALL. Yet, this function is
>    used by other commands too. So, either we pass in a type from
>    higher callers, or simply check the opcode in that function.

Yes, you'd have to pass in the type there too, which makes it more
ugly.

> So, it feels to me that checking against the opcode is still a
> straightforward solution. And what I ended up with is somewhat
> similar to this v6, yet this time it only checks at batch init
> call as your design does.

Well, the only downside is that the commands have to be same in a
batch, but maybe that is OK anyhow.

Don't forget to take the hunks that fix the queue as well.

Jason