Received-SPF: pass (google.com: domain of linux-kernel+bounces-169868-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <a7ae8fc0-5e53-487a-86c6-f49dc6623688@amd.com>
Date: Mon, 6 May 2024 08:09:07 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/2] platform/chrome: cros_ec_framework_laptop: new driver
To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
 Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
 Guenter Roeck <groeck@chromium.org>, Tzung-Bi Shih <tzungbi@kernel.org>
Cc: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
 "Dustin L. Howett" <dustin@howett.net>, Sebastian Reichel <sre@kernel.org>,
 linux-pm@vger.kernel.org
References: <20240505-cros_ec-framework-v1-0-402662d6276b@weissschuh.net>
 <613369f9-42c5-4a59-b83f-45bd1773ffe4@t-8ch.de>
Content-Language: en-US
From: "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <613369f9-42c5-4a59-b83f-45bd1773ffe4@t-8ch.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Mk9PdzF1MzdWcTdCdTNEQU9jMitUaFNzZWlWRmR3NER4K0crMzdkWDErdlR4?=
 =?utf-8?B?c21WbGhPUTIyRWo3ZU9SbTlqanBkTEY3Y2xQZ2Y4a1lvTWtIdGZwd25hRVVv?=
 =?utf-8?B?SlRkMUhPNjlFdUFvVmpRVm5rdmJLQlFXL0xLUFluMGZUN3hYVU5FZkJrd21C?=
 =?utf-8?B?aGExUjVXSmh2OVlEWWZBVkF4TSs5WlVEVFZaTFNiMkhHSFRPNUxZNnN0TXFs?=
 =?utf-8?B?bk1ZcW9rdWdYditMYWFTSWMybWtEb1RsaEV5SVl0bjliSjhQWEd1ZWJzL3lo?=
 =?utf-8?B?bjRPeVc0ZTE5eXRIaTVhajJWdVRkOXF6NTlvcXgzN2UrL3dPQVdTMEp4Rmwy?=
 =?utf-8?B?QXI4VU0xQ2tLVkIwdGg4cEF2eW54aVIzWW9EY24yY2dJNm9HZkExVkVxWkkx?=
 =?utf-8?B?STk2VWxmaFlkYlNhUnBucXE2MVZ6QlJ0MDNiNlhBN0Y2eTh4Mlc1dlNWVmlU?=
 =?utf-8?B?S2ZwcG5PaUQ0N21FM3g5R3Y4YnZ2dnNnc0ZlUFFMMVE3T2dJMGhhNkMvaVAx?=
 =?utf-8?B?eVhvYUtibVRPS3lIdDlpSS9jakJZczZGTVBMeHhtUUJaODhHOXJ0eWNzSE5h?=
 =?utf-8?B?S2hQRVQ0OXZZeExHa09ld1hsUDhhVUYxVXJkZFdtaCtjcStLWkxlc3ZpUlZs?=
 =?utf-8?B?c1NsR1dTR091dWp0aG9yL1laTWdURE5MUGJ4QVBiYS85RFdSTEZBdk94VXhl?=
 =?utf-8?B?VG9WR2pOeUxxVUdhdnVZejZDbS9xMGdqVlpMc3NZKzhzZ243UVRLQ2Jpa096?=
 =?utf-8?B?MHZidldldWxWMk1HTllGTnVFRW1vTXY0Qk5GYXd3MTdIS0UzeldRTGtvRUpV?=
 =?utf-8?B?Q2NyZXRFWGsrbUN6L3VDczlVVnp1N084bExxamVrMGZ3T2tjWDVCanZmZDdQ?=
 =?utf-8?B?cUJ6bms5VlhOajU2azFuVU9CODhYN2pBeVZVME1zWkpmdmlBV3poRE9TM3Rh?=
 =?utf-8?B?UmRCZGc2ZmIvbXMyU3ArVDJTaS9jaU5qcGlQbUxaOHArMFlvcDdCS0VIamJW?=
 =?utf-8?B?OEhsZWRxa1hJYTdqT3RxTmhYTzNOOTQwYUxFcllzZ2hUSU9NT2l0QVBOWUVD?=
 =?utf-8?B?MVRWemU0YUlqNEw2dldTM0szWTVFY0p3MDJuSVpuS1Q3ODlwUUdlNWNnMGMx?=
 =?utf-8?B?SGhjYzhLZkh6ZEwwRVFkQWREeEsvQXcreGo0Zi9yV0N3ejAyRW5NMVlaL1JX?=
 =?utf-8?B?MmpZQzJpTlVtUEgxR0NNYTBiWDBFTGY1dTV0aVNZYm9scGxYQjBQbVRZQ1Q5?=
 =?utf-8?B?S2tvK0I1bzMrS3h2SU9lcnhEUlFMaUthUVY0bVh3UDk4Y21GM2QyRzFjb0s4?=
 =?utf-8?B?RWtzTGNJZGRoUHNyWUsxRUdaVTVtYkxwZGN1Y2MyUFRWc2JrdXZvZnpxVytv?=
 =?utf-8?B?S281eVpWZ0tGejEyS3oxbmxGTnJIMVhTemVHR3pUSEpGeG1KYVJhVzhwa0dZ?=
 =?utf-8?B?T3JpK0UrZ2U4SW9Nb2RUTWlaNWFyMlgzVkxhWmNXU1M3ZmFia1RMd0NvZHha?=
 =?utf-8?B?SG1maHhBRktwakMycXg5YndQYWtvYjdxUHluSExOWS9aTHZWL1JvQUhOSGJl?=
 =?utf-8?B?ejJNUnNLdnJZTzRTMWdzdEJaUGVMTVhqYzZZUkNzU2dLL3ZhM0d3TlFtZXFp?=
 =?utf-8?B?dWRSOFJrMWVPdkhSQ2lyRTJnQ3ZaanRjN0VVMmJDdjJGSWlXZnlxK0htRGNx?=
 =?utf-8?B?ZFZnT2hEUHJVM2NmYi9iaDA0dlVtTWw2b0xUODJuc2IxbG9wSU9jNW1NR21w?=
 =?utf-8?B?bHdsUkgrNFlUazdsTnRCbzZ2Y2V3RzREZHVhZ2ZvWjltcWptSndoUUFRMHNr?=
 =?utf-8?B?VXQvNHp6d25sS2laTEk0Q0tROXdqK2c4Sk1ybHdCUm9PTDJZdGlSNTVLd2sz?=
 =?utf-8?B?Qk10aUZJUzJWY2RON1MxV282VnVNbW1WVWNXTHBCOTMxNkF4QWhlRlgwcDla?=
 =?utf-8?B?Q1Vja2wwN0NEUnFnR0pZd3ZycVhwK21tRFpGT21TY2t3bVVQeSs3czZ0V1h0?=
 =?utf-8?B?cnpzbGtYaWhQNnRLOENVYWI2dFpPVUtkdWxQRVlZdmhuNmMxRUREd2F3cndu?=
 =?utf-8?B?enRSK2dleGJLd1hPK2FiODBCS2k0SEZ4Q0RBWlNiZUg2aDRJOXJXejU3QUha?=
 =?utf-8?Q?3rWuDtlgfqtc92M0ZOJOl0452?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd3f255f-38c7-4dc5-f1c5-08dc6dcdb7c1
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 13:09:09.9978
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lKcWseJJqIzPaxSaMywo5d5ttcmhR46kUDXtmmXb5W3WYtwTA+dnwd0Qwgpgw25BCsTaS5YmD2N+sjItKatJlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9144


On 5/6/2024 1:09 AM, Thomas Weißschuh wrote:
> On 2024-05-05 22:56:33+0000, Thomas Weißschuh wrote:
>> Framework Laptops are using embedded controller firmware based on the
>> ChromeOS EC project.
>> In addition to the standard upstream commands some vendor-specific
>> commands are implemented.
>>
>> Add a driver that implements battery charge thresholds using these
>> custom commands.
> 
> It turns out that standard ChromesOS EC defines EC_CMD_CHARGE_CONTROL.
> The kernel headers however only define v1 of the protocol, which is very
> limited.
> 
> But in the upstream firmware repo there is a v3 which is much better.
> 
> The Framework laptop only implements v2 which is also fine.
> Given that v3 was only introduced late last year, it seems better to
> stick to v2 anyways for now.
> 
> So please disregard Patch 2, I'll see on how to use this via a normal
> cros_ec driver.
> 
> There are some other Framework-only features that will use Patch 1,
> so feedback for that would still be good.

What other kinds of features do you have in mind?

Considering your above finding I think it's better to put patch 1 into 
the series of "other framework only features" that will use it so it's 
clearer if it's the best way or not.

> 
>> Patch 1 adds the general scaffolding and device binding.
>> Patch 2 implements the battery charge thresholds.
>>
>> This series is based on
>> https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
>>
>> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
>> ---
>> Thomas Weißschuh (2):
>>        platform/chrome: cros_ec_framework_laptop: introduce driver
>>        platform/chrome: cros_ec_framework_laptop: implement battery charge thresholds
>>
>>   MAINTAINERS                                        |   5 +
>>   drivers/mfd/cros_ec_dev.c                          |  13 ++
>>   drivers/platform/chrome/Kconfig                    |  11 ++
>>   drivers/platform/chrome/Makefile                   |   1 +
>>   drivers/platform/chrome/cros_ec_framework_laptop.c | 173 +++++++++++++++++++++
>>   5 files changed, 203 insertions(+)
>> ---
>> base-commit: 2fbe479c0024e1c6b992184a799055e19932aa48
>> change-id: 20240505-cros_ec-framework-10e627c46a0a
>>
>> Best regards,
>> -- 
>> Thomas Weißschuh <linux@weissschuh.net>
>>