Received-SPF: pass (google.com: domain of linux-kernel+bounces-169871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 6 May 2024 15:13:57 +0200
From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Eric Dumazet <edumazet@google.com>
CC: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<soheil@google.com>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: tcp: Update the type of scaling_ratio
Message-ID: <20240506131357.lplgpwj2h4nkdxa6@DEN-DL-M31836.microchip.com>
References: <20240506120400.712629-1-horatiu.vultur@microchip.com>
 <CANn89i+SJiOLLy8azt8NqckUkTLqTS3Wu=16vfTrqCFYLKxTPw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CANn89i+SJiOLLy8azt8NqckUkTLqTS3Wu=16vfTrqCFYLKxTPw@mail.gmail.com>

The 05/06/2024 14:35, Eric Dumazet wrote:
> 
> On Mon, May 6, 2024 at 2:04 PM Horatiu Vultur
> <horatiu.vultur@microchip.com> wrote:

Hi Eric,

> >
> > It was noticed the following issue that sometimes the scaling_ratio was
> > getting a value of 0, meaning that window space was having a value of 0,
> > so then the tcp connection was stopping.
> > The reason why the scaling_ratio was getting a value of 0 is because
> > when it was calculated, it was truncated from a u64 to a u8. So for
> > example if it scaling_ratio was supposed to be 256 it was getting a
> > value of 0.
> > The fix consists in chaning the type of scaling_ratio from u8 to u16.
> >
> > Fixes: dfa2f0483360 ("tcp: get rid of sysctl_tcp_adv_win_scale")
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> 
> This is a wrong patch. We need to fix the root cause instead.
> 
> By definition, skb->len / skb->truesize must be < 1
> 
> If not, a driver is lying to us and this is quite bad.
> 
> Please take a look at the following patch for a real fix.
> 
> 4ce62d5b2f7aecd4900e7d6115588ad7f9acccca net: usb: ax88179_178a: stop
> lying about skb->truesize

Thanks for explanation and for the suggestion.
I have tried this on a driver that is not yet upstream.
Sorry for the noise.

-- 
/Horatiu