Received-SPF: pass (google.com: domain of linux-kernel+bounces-169873-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <c4640af2-a791-848a-bacb-071f0bc8f9b1@amd.com>
Date: Mon, 6 May 2024 08:14:34 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v4 05/15] x86/sev: Use kernel provided SVSM Calling Areas
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev,
 svsm-devel@coconut-svsm.dev, Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
 Peter Zijlstra <peterz@infradead.org>,
 Dan Williams <dan.j.williams@intel.com>, Michael Roth
 <michael.roth@amd.com>, Ashish Kalra <ashish.kalra@amd.com>
References: <cover.1713974291.git.thomas.lendacky@amd.com>
 <07266b47e749267ef9a9ccbc9e8e9df78ed54857.1713974291.git.thomas.lendacky@amd.com>
 <20240503103407.GSZjS9n-XMMKi5ZOek@fat_crate.local>
 <20240506100905.GFZjisQTQwbkv2eKsh@fat_crate.local>
Content-Language: en-US
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20240506100905.GFZjisQTQwbkv2eKsh@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VzB6R04wWnJpTHZCemhmLzdaMjRKNUNzR2Z1NThZZnExeGUzTlU2SEl0cXls?=
 =?utf-8?B?ejFza2VEcUNzSjI2V2VEZ3RRckltdTZjYTZEbVJzK2Qza2JmVk40Z1dVNkZH?=
 =?utf-8?B?QkRBWlNwKzgwVEJTNzd3NFdZSFc2UDNOeFBmTWwyWHM3N0w2OXBJNlJ5MVRE?=
 =?utf-8?B?SDE3T1NndTF5MG9OUXJoOUpaaEwvVE5qT21iVy9XcTJOSTJhcktHOWREbVRY?=
 =?utf-8?B?YTRzTWRrenRLZ1NkUjlxUC9XZS90S2JSOC9XUFl1a1cxaW1OYS9Gb0cxaHhp?=
 =?utf-8?B?VVJjeFBUNFFlbmNxOGNKSEdlbHZIc01lUDU0K0FreTRHRUZvdnNnc2c4RzdP?=
 =?utf-8?B?a3g5TzVubFZrMytRV0ZEWXBrQWZuZktONEo3dnBROFdMSGNUanhxT0xTYUoy?=
 =?utf-8?B?end0a09CVnc3SkE2U0JkZHhUd3Awd0pCOVdvNU1JQVZycXNNSjNtUXEyUjdm?=
 =?utf-8?B?cGorY084M0N6dEZvaEhaYWF5NGdWRjJCa3RGZUNnZzBOSVc1eXpES2lZODFl?=
 =?utf-8?B?NXB4WkdEdjR6NENNd3FUN2dvNHJpNW01SHRNZmQ4WlBSTDhtZ3lvRUhZQWhj?=
 =?utf-8?B?b1NrR2h3YTQ2UUdQcmFsRnZta3hSdXNwcnNQN3I0U3I1a1M4SzluTU4wTGNR?=
 =?utf-8?B?Mk9xYWdQeDE2cXRVNUdrNjJpWnV0c2hESzNFRWNHTTdxcFdSRnZKN21VWmp3?=
 =?utf-8?B?SUFwdTQ5YjNCaVc5OXJMUVpudUZ5VzlyK3FQSDhpZm9iSVMxc05uZnRWVkNr?=
 =?utf-8?B?TmsvSlhHUi9sNFZuK1RqZVBKZmlWOHZZWjhuKzEvQmpSNzd0bzQwSm0xdm00?=
 =?utf-8?B?RVZuK2N2ZTRXVVo4VkE2dkw2ak8wMnJVWE8wemFKZUc1eGNpdjB0Mm1nNXhW?=
 =?utf-8?B?RWhrNUxibDEzR2JFeFhxK0lIdVhEandGQkkwTkpuNGhMejdIYU5Hb013YXZh?=
 =?utf-8?B?Zm9pcTd6dlpMcnFQcVJFRFJnMzJmR3I3eXlJZW5WWk8za0J1OFFaMWpmZ3lJ?=
 =?utf-8?B?NVlkVmZDVkY1eFFaWkJ0eDBHV296ZmIvRFJHSDhvSTdVeEZ2anV3TmZzRVIy?=
 =?utf-8?B?b0p0TXpjV0ZkM1dNdFNNMC95UFdqYTFIV254L3NvSVBtazM2WGUrdkROWmwv?=
 =?utf-8?B?WmE1MU16NXYyOElSc3lFZkRlenU4SWFNeXdxT1VydHFGdjc4bThKUEoycjFO?=
 =?utf-8?B?RzFJK01IYXFpazlrUFZKRTFReDh1OVE3UTBNSHhFYVNsSCtUbU9mdWNWdkhS?=
 =?utf-8?B?dWVQaGNnMklZUVBETmE2ZzRpVEFOWjBBbXlBM2tOdGVpbWFZeW5CQU85bVNK?=
 =?utf-8?B?UE45MFNwS2pvTHd5VVBvQ2lmQ0I2TWxabVhZaWVCbUg0TnJzMkc0Nmw2OUtu?=
 =?utf-8?B?Y0o4Vld0eFQ2Y0wxMmVsQ0hBa2hsVktVcDQ4MHBzQ1dKL3VyS0pHRmkrbzVi?=
 =?utf-8?B?d2pqRHEraXhuZEw5T2Y1UWFSV1pWVXpBRE5Ub1JMdXRJbSswcTR0aXI3b0Fp?=
 =?utf-8?B?SEw1QWpRWjNTQ0dJN1kvczJVMm1RU2Fha01DVmtWbkY0ajNIV0hSQ0kxWTRj?=
 =?utf-8?B?eVVqQk1LS1RXcTA3MXZWVmZJOG9RN1lVSGVuNnRDSUxHN3FKSEJCaG8wZmpo?=
 =?utf-8?B?WmpMb0JkZ0J2dTR0bHM0a24xSHBWNURRbDVNWFhZdjk0ZFRQa1lRTFN3RXEv?=
 =?utf-8?B?ckNkT1FtWVM5aFJKblpuOFBuN3FDQmxZNGVVU2RIZW9hVkYzeHdEM21FcXpY?=
 =?utf-8?B?Mld2am5FbHFwclM3OG53aUs1ZGdrMkYxK1pYem1wQXp3cVo0anJnaWtGcnc4?=
 =?utf-8?B?L2QxQ0w3czBHUm43eTNSSTFYQXRtV3Q5eGlCOXFGak9LcnZIcVowNmdwcDVD?=
 =?utf-8?B?d1VUOEFkbzkvbWNwUEN1MDlibDFMaHdSbjJnSzN0dkpxYVZGQlZHQk5VclNZ?=
 =?utf-8?B?YzNQSFJkckJQMDdzNDVxYWJsSno3OWhOZjdSNmo1VmxWTDgrTlR5TTVKaHVH?=
 =?utf-8?B?bXl3bktkaXZ4enowRGhkMDlGUGNjZWZuRzJvUUEwYlZqdWNzOGdNWElxQUtS?=
 =?utf-8?B?VlBhYzZqOWdlaWZPa2JtWHdLRDF3TXV4d1VXSkR4clN5ZkRWeHo2aDhZOGsz?=
 =?utf-8?Q?sbxv3NJWFgJy6btJzeHd846I/?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86f1c35a-073d-4227-e24c-08dc6dce7aa6
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 13:14:37.0119
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8I+PvOb768xSm+0JBlnYIfroOsoYOYHM9amf1ArYx5/ynWbgUx0YtlOpD2MQPZFkLxAq2e3lCYr7bhpXdNYWpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6870

On 5/6/24 05:09, Borislav Petkov wrote:
> Ok,
> 
> I think this is very readable and clear what's going on:

I'll test it out.

> 
> static __always_inline void issue_svsm_call(struct svsm_call *call, u8 *pending)
> {
>          register unsigned long rax asm("rax") = call->rax;
>          register unsigned long rcx asm("rcx") = call->rcx;
>          register unsigned long rdx asm("rdx") = call->rdx;
>          register unsigned long r8  asm("r8")  = call->r8;
>          register unsigned long r9  asm("r9")  = call->r9;
> 
>          call->caa->call_pending = 1;
> 
>          asm volatile("rep; vmmcall\n\t"
>                       : "+r" (rax), "+r" (rcx), "+r" (rdx), "+r" (r8), "+r" (r9));
> 
>          xchg(pending, 1);

This isn't quite right. The xchg has to occur between pending and 
call->caa->call_pending.

Thanks,
Tom

> 
>          call->rax_out = rax;
>          call->rcx_out = rcx;
>          call->rdx_out = rdx;
>          call->r8_out = r8;
>          call->r9_out = r9;
> }
> 
> and the asm looks ok but the devil's in the detail.
>