Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp1436595lqh; Mon, 6 May 2024 07:44:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV834wMHqc7tWltV206I+Qrwr0mMI/ueRFb3TtsNMLcOQZdw3P/VST2b3p1U+rHjgI14Izf0P55DtDT/At78Mv5aRqjo7TwqtMRtlygbg== X-Google-Smtp-Source: AGHT+IGD7zMGdw5zP+VdLL1j0fJZ35/R0jjkyvf8+8qiMOcXeduBTxGATAjlVbCWl/UwlY9xtClH X-Received: by 2002:a05:6214:202c:b0:6a0:73ee:f776 with SMTP id 12-20020a056214202c00b006a073eef776mr14380106qvf.15.1715006692585; Mon, 06 May 2024 07:44:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715006692; cv=pass; d=google.com; s=arc-20160816; b=JovLdshNHGf0Gd/kgk5dpU/mn1eCHJilbfBDgM3w4zwqbngZ4Gtha4pdtFkaJsxykJ Cy0a53PVhqYJyVmD5rn3zKc1vUBXKaPcRFXYMq8OpKVfLqDf4C53cB9yDo+cdEDsnxNy RuDwspBrGc2PfDDl8gNzw3/PaJwED+p/D7FGZVsRfPhMFoKKujV2pD5ld5mLLorPxWpT sPhfE7JiZxGtefY2YjsnbAY4h2ctG2C9dF8GVS4gBpwmTAQOzG+mqASVtapRtkjRTmYo TIAFtrfV3CSfYA6hih2T5CZN6aAPTzwsY8i3d84LdOpjevYRsqgMck2oVB9gC+9GuoFK ROvg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=uq6oZxeBr7WCufTCHeNPAoz1p+qOGlvaP1M3ucdx7Qs=; fh=00Cc7eVF559QD5kwv7+/9L5M7AXi85Yd99Gp5k8Q6j8=; b=Qdox6js9ZLomtW8x0/deeBaR+eoZFSj6/NUX5vrqLMqUQvMnBCH+wNERhc1vNEiT0J Y0vwaskpOtS7mOSPfsG75Tw131jdgMiQCZyryWewruC++/fdrJ/VTUNgY/RvlDTo4d9A FAFxEw+nf33qqnwS/hFpB4V+4cOIyETl9vPwTm1aTBVpEuacautOl2TmK9nHzBJ6aIRj ahDt2Adt6s2vSnBV3ii/oPg91l9lJP3JMYx4AwXk5W5L9Oxkqq5ffmmQ9V0veL4qxzlT tJnZKD/Hbhp27fam0LCVttS8S8iZ3HkarDqq4crCP2Ts9+/fS/M5AYWDyi6JK9hfIFik Pssg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K2gQ737D; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-170012-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170012-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id o6-20020a0562140e4600b006a0d298644dsi9266234qvc.491.2024.05.06.07.44.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 07:44:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-170012-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K2gQ737D; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-170012-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170012-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 977061C23DAD for ; Mon, 6 May 2024 14:44:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D1AF4153838; Mon, 6 May 2024 14:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K2gQ737D" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBE12153512; Mon, 6 May 2024 14:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715006669; cv=none; b=o6UsoqFOsgf7QHkMe3sfGLs887SxskvXrKqJ0/KqLlGdCrHK+E+xYgfZQZsBtWDuSc5yX1+wpWk9w4LwsI9Yh+yk7RlYIryTyz01YhuIgGy3tZTFXDGw5krFqubYk229MWfFUkmYzulSvTtqXzoXSHxqGrqetF32Ym0OMqToeX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715006669; c=relaxed/simple; bh=uq6oZxeBr7WCufTCHeNPAoz1p+qOGlvaP1M3ucdx7Qs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WnMQfY4zpy2R81vYT9hL0awhE5bq2VPMXLmWZibQD7rvkNEkTuskLnVw9X/EhpyFBD/yeSfAukT5CdIvO4D+9CLTjXzLQYic3dXwPUIpJBfedi4tz2N6qCpHp+W1utp61dO3i6+P/QqTdCEfAaNj0KzUyHE6ppQ2QU97dxvNmLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K2gQ737D; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41F52C116B1; Mon, 6 May 2024 14:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715006668; bh=uq6oZxeBr7WCufTCHeNPAoz1p+qOGlvaP1M3ucdx7Qs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K2gQ737D9gG4vUqBYrskOUvA1/bDrCFQRMFYyq2EzdrAtAes5SS1C4TG7BvgZr74L oalrop/fxRAnzVjQQyg27IzRO7bqt6jvjdVKbgB/sL8GTRS4VUMmWmEd4IlFFd6HyR UhO6sS5QiKRru1qShuj1fjd7yxCEE8qEwMVKozwoKorON93quWPjxfgNLjUcgVkST7 nvQL7cQi1aMnMjHQzLd2i0wAmuU0wgdiess/XRgexR8voWEpWh2gyiV9yozyNCvdiz TMCSRP2gekL/1LunQHsdLAfkrmDBvOPKEgArR9aelW8s7UFGe1nIEjMnNAerMjEoNa Qs+rabREHT6Yg== Date: Mon, 6 May 2024 23:44:25 +0900 From: Mark Brown To: Takashi Iwai Cc: Jaroslav Kysela , John Hubbard , Shuah Khan , Takashi Iwai , Ivan Orlov , linux-sound@vger.kernel.org, Valentin Obst , linux-kselftest@vger.kernel.org, LKML , llvm@lists.linux.dev Subject: Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree() Message-ID: References: <20240505210824.55392-1-jhubbard@nvidia.com> <875xvrif0c.wl-tiwai@suse.de> <87zft3gz8u.wl-tiwai@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WzfPT8Mcv1MPlK5X" Content-Disposition: inline In-Reply-To: <87zft3gz8u.wl-tiwai@suse.de> X-Cookie: lisp, v.: --WzfPT8Mcv1MPlK5X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 06, 2024 at 09:45:21AM +0200, Takashi Iwai wrote: > Jaroslav Kysela wrote: > > This function is nice for debugging. I'd prefer to keep it with the fix. > I'm find in either way; just submit a fix patch, then. The fix was already submitted as v1, I noticed that the function was unused in review. --WzfPT8Mcv1MPlK5X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmY47MYACgkQJNaLcl1U h9C8bAf+LC3W5csuXsXkW345oPaJXG/mlVRt0y6r3fozBgx8Cq5DdPfTJaUQiYRW iZ2f4WDQs5odkSrZ63+uzCuEYl4Go47zHwHiqygtP5Yrk5Yq45VJ2T7lq05mQO8e GMaGefQf1Lg3xNK1+bl996iAQxbipI+Z0cWnyylNKujLsCI9Z04AQzCVGdk85qfO MxtEj1XlncY8uvocr9zl//g0D2LZ0+FBdoFAf8QFa1xQOXTIcHkCGZpLRmQ0TeFQ juk/8jfnhQUYGjw0ihnojiAlSmHfYG0Sq7EnJBMu2Ap3hcJ+uUk356gaHDhz8OfT FiaklaOKMNV9+a47NG7ma+lvHF5wHg== =P5PN -----END PGP SIGNATURE----- --WzfPT8Mcv1MPlK5X--