Received-SPF: pass (google.com: domain of linux-kernel+bounces-170015-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Mon, 6 May 2024 17:44:57 +0300 (EEST)
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
cc: bhelgaas@google.com, linux-pci@vger.kernel.org, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI/ASPM: Fix a typo in ASPM restoring logic
In-Reply-To: <20240506051602.1990743-1-kai.heng.feng@canonical.com>
Message-ID: <c74f0256-1453-3b91-d5a7-d797a0c2da90@linux.intel.com>
References: <20240506051602.1990743-1-kai.heng.feng@canonical.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-470952821-1715006697=:1111"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-470952821-1715006697=:1111
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Mon, 6 May 2024, Kai-Heng Feng wrote:

> There's a typo that makes parent device uses child LNKCTL value and vice
> versa. This causes Micron NVMe to trigger a reboot upon system resume.
>=20
> Correct the typo to fix the issue.
>=20
> Fixes: 64dbb2d70744 ("PCI/ASPM: Disable L1 before configuring L1 Substate=
s")
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  drivers/pci/pcie/aspm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index 2428d278e015..47761c7ef267 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -177,8 +177,8 @@ void pci_restore_aspm_l1ss_state(struct pci_dev *pdev=
)
>  =09/* Restore L0s/L1 if they were enabled */
>  =09if (FIELD_GET(PCI_EXP_LNKCTL_ASPMC, clnkctl) ||
>  =09    FIELD_GET(PCI_EXP_LNKCTL_ASPMC, plnkctl)) {
> -=09=09pcie_capability_write_word(parent, PCI_EXP_LNKCTL, clnkctl);
> -=09=09pcie_capability_write_word(pdev, PCI_EXP_LNKCTL, plnkctl);
> +=09=09pcie_capability_write_word(parent, PCI_EXP_LNKCTL, plnkctl);
> +=09=09pcie_capability_write_word(pdev, PCI_EXP_LNKCTL, clnkctl);

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-470952821-1715006697=:1111--