Received-SPF: pass (google.com: domain of linux-kernel+bounces-170021-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 6 May 2024 16:49:33 +0200
From: Michal Hocko <mhocko@suse.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Xiu Jianfeng <xiujianfeng@huawei.com>, hannes@cmpxchg.org,
	roman.gushchin@linux.dev, shakeel.butt@linux.dev,
	muchun.song@linux.dev, akpm@linux-foundation.org,
	cgroups@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mm: memcg: use meaningful error code for return
 value
Message-ID: <Zjjt_Tv4ZxCCcpcG@tiehlicka>
References: <20240506133643.1124102-1-xiujianfeng@huawei.com>
 <Zjjg60ZW-d7r-DS9@casper.infradead.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zjjg60ZW-d7r-DS9@casper.infradead.org>

On Mon 06-05-24 14:53:47, Matthew Wilcox wrote:
> On Mon, May 06, 2024 at 01:36:43PM +0000, Xiu Jianfeng wrote:
> > alloc_mem_cgroup_per_node_info() returns 1 if failed, use -ENOMEM
> > instead, which is more meaningful.
> 
> This should probably be changed to return true/false instead of
> an int.

Agreed. Or change the only caller to consume the error. Changing to bool
seems like the easiest way.

-- 
Michal Hocko
SUSE Labs